AuroraMiddleware/winpty
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In Agent::handleStartProcessPacket, call GetLastError immediately after

Browse Source 
CreateProcess.
This commit is contained in:
Ryan Prichard 2012-03-19 21:17:43 -07:00
parent 7dbe7537c3
commit 0554f9fbde
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
agent/Agent.cc
View File

@ -139,6 +139,7 @@ void Agent::handlePacket(ReadBuffer &packet)
int Agent::handleStartProcessPacket(ReadBuffer &packet)
{
BOOL success;
ASSERT(m_childProcess == NULL);
std::wstring program = packet.getWString();
@ -164,20 +165,24 @@ int Agent::handleStartProcessPacket(ReadBuffer &packet)
memset(&pi, 0, sizeof(pi));
sui.cb = sizeof(STARTUPINFO);
BOOL ret = CreateProcess(programArg, cmdlineArg, NULL, NULL,
success = CreateProcess(programArg, cmdlineArg, NULL, NULL,
/*bInheritHandles=*/FALSE,
/*dwCreationFlags=*/CREATE_UNICODE_ENVIRONMENT,
/*dwCreationFlags=*/CREATE_UNICODE_ENVIRONMENT |
/*CREATE_NEW_PROCESS_GROUP*/0,
(LPVOID)envArg, cwdArg, &sui, &pi);
int ret = success ? 0 : GetLastError();
Trace("CreateProcess: %s %d", (ret ? "success" : "fail"), (int)pi.dwProcessId);
Trace("CreateProcess: %s %d",
(success ? "success" : "fail"),
(int)pi.dwProcessId);
if (ret) {
if (success) {
CloseHandle(pi.hThread);
m_childProcess = pi.hProcess;
}
// TODO: report success/failure to client
return ret ? 0 : GetLastError();
return ret;
}
int Agent::handleSetSizePacket(ReadBuffer &packet)