AuroraMiddleware/winpty
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add some TODO comments.

Browse Source
This commit is contained in:
Ryan Prichard 2012-02-20 04:54:18 -08:00
parent 8a89620cc3
commit 1901ed62d6
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libpconsole/pconsole.cc
View File

@ -222,6 +222,12 @@ PCONSOLE_API pconsole_t *pconsole_open(int cols, int rows)
// Start the agent. // Start the agent.
startAgentProcess(desktop, controlPipeName, dataPipeName, cols, rows); startAgentProcess(desktop, controlPipeName, dataPipeName, cols, rows);
// TODO: Frequently, I see the CreateProcess call return successfully,
// but the agent immediately dies (e.g. because it can't locate one of
// the Qt DLLs). The following pipe connect calls then hang. These
// calls should probably timeout. Maybe this code could also poll the
// agent process handle?
// Connect the pipes. // Connect the pipes.
bool success; bool success;
success = connectNamedPipe(pc->controlPipe, false); success = connectNamedPipe(pc->controlPipe, false);
@ -266,6 +272,9 @@ static int32_t readInt32(pconsole_t *pc)
return result; return result;
} }
// TODO: We also need to control what desktop the child process is started with.
// I think the right default is for this pconsole.dll function to query the
// current desktop and send that to the agent.
PCONSOLE_API int pconsole_start_process(pconsole_t *pc, PCONSOLE_API int pconsole_start_process(pconsole_t *pc,
const wchar_t *appname, const wchar_t *appname,
const wchar_t *cmdline, const wchar_t *cmdline,

1
unix-adapter/main.cc
View File

@ -280,5 +280,6 @@ int main()
int exitCode = pconsole_get_exit_code(pconsole); int exitCode = pconsole_get_exit_code(pconsole);
restoreTerminalMode(mode); restoreTerminalMode(mode);
// TODO: Call pconsole_close? Shut down one or both I/O threads?
return exitCode; return exitCode;
} }