AuroraMiddleware/winpty
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix for edge case when process list changes between GetConsoleProcessList calls

Browse Source
This commit is contained in:
Tereza Tomcova 2017-10-04 00:28:05 +02:00
parent 1424696a6d
commit 39fe32b15d
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/agent/Agent.cc
View File

@ -435,8 +435,16 @@ void Agent::handleGetConsoleProcessListPacket(ReadBuffer &packet)
auto processList = std::vector<DWORD>(64);
auto processCount = GetConsoleProcessList(&processList[0], processList.size());
if (processList.size() < processCount) {
processList.resize(processCount);
// The process list can change while we're trying to read it
while (processList.size() < processCount) {
// Multiplying by two caps the number of iterations
const int newSize = processList.size() * 2;
if (newSize <= processList.size()) { // Ensure we fail when new size overflows
processCount = 0;
break;
}
processList.resize(newSize);
processCount = GetConsoleProcessList(&processList[0], processList.size());
}