AuroraMiddleware/winpty
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid a possible buffer overflow in winpty-debugserver.exe

Browse Source 
Also: use fwrite directly instead of printf; maybe it's a bit faster.
This commit is contained in:
Ryan Prichard 2015-12-24 21:25:06 -06:00
parent 6c8b7effe5
commit 6720daa07a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/debugserver/DebugServer.cc
View File

@ -37,7 +37,7 @@ int main() {
10 * 1000, 10 * 1000,
NULL); NULL);
char msgBuffer[MSG_SIZE]; char msgBuffer[MSG_SIZE + 1];
while (true) { while (true) {
if (!ConnectNamedPipe(serverPipe, NULL)) { if (!ConnectNamedPipe(serverPipe, NULL)) {
@ -52,8 +52,8 @@ int main() {
DisconnectNamedPipe(serverPipe); DisconnectNamedPipe(serverPipe);
continue; continue;
} }
msgBuffer[bytesRead] = '\0'; msgBuffer[bytesRead] = '\n';
printf("%s\n", msgBuffer); fwrite(msgBuffer, 1, bytesRead + 1, stdout);
fflush(stdout); fflush(stdout);
DWORD bytesWritten = 0; DWORD bytesWritten = 0;