From cfb072870f54353b2e119f3b4292176bca519fdc Mon Sep 17 00:00:00 2001 From: Ryan Prichard Date: Tue, 31 May 2016 19:48:41 -0500 Subject: [PATCH] Zero-initialize the EXPLICIT_ACCESSW objects. This may have fixed a segfault in winpty_open. Fixes https://github.com/rprichard/winpty/issues/80 --- Makefile | 2 +- RELEASES-0.3.md | 8 ++++++++ VERSION.txt | 2 +- src/shared/WindowsSecurity.cc | 4 ++-- 4 files changed, 12 insertions(+), 4 deletions(-) create mode 100755 RELEASES-0.3.md diff --git a/Makefile b/Makefile index 921c3c8..79062ad 100644 --- a/Makefile +++ b/Makefile @@ -125,7 +125,7 @@ install-doc : mkdir -p $(PREFIX)/share/doc/winpty install -m 644 -p LICENSE $(PREFIX)/share/doc/winpty install -m 644 -p README.md $(PREFIX)/share/doc/winpty - install -m 644 -p RELEASES.md $(PREFIX)/share/doc/winpty + install -m 644 -p RELEASES*.md $(PREFIX)/share/doc/winpty .PHONY : install-include install-include : diff --git a/RELEASES-0.3.md b/RELEASES-0.3.md new file mode 100755 index 0000000..7e6308e --- /dev/null +++ b/RELEASES-0.3.md @@ -0,0 +1,8 @@ +# Version 0.3.1 (2016-05-31) + +This version was released solely to fix a possible crashing bug in 0.3.0. + +Bug fixes: + + * Fixed an uninitialized memory bug that could have crashed winpty. + [#80](https://github.com/rprichard/winpty/issues/80) diff --git a/VERSION.txt b/VERSION.txt index 0d91a54..9e11b32 100644 --- a/VERSION.txt +++ b/VERSION.txt @@ -1 +1 @@ -0.3.0 +0.3.1 diff --git a/src/shared/WindowsSecurity.cc b/src/shared/WindowsSecurity.cc index 0014326..21682cb 100644 --- a/src/shared/WindowsSecurity.cc +++ b/src/shared/WindowsSecurity.cc @@ -218,7 +218,7 @@ createPipeSecurityDescriptorOwnerFullControl() { Sid localSystem; Sid builtinAdmins; Sid owner; - std::array daclEntries; + std::array daclEntries = {}; Acl dacl; SecurityDescriptor value; }; @@ -258,7 +258,7 @@ createPipeSecurityDescriptorOwnerFullControlEveryoneWrite() { Sid builtinAdmins; Sid owner; Sid everyone; - std::array daclEntries; + std::array daclEntries = {}; Acl dacl; SecurityDescriptor value; };