diff --git a/include/wx/gtk/spinctrl.h b/include/wx/gtk/spinctrl.h index 898f1dcd1e..6b9def816f 100644 --- a/include/wx/gtk/spinctrl.h +++ b/include/wx/gtk/spinctrl.h @@ -55,8 +55,8 @@ public: // implementation void OnChar( wxKeyEvent &event ); - void GtkDisableEvents(); - void GtkEnableEvents(); + void GtkDisableEvents() const; + void GtkEnableEvents() const; int m_pos; diff --git a/src/gtk/spinctrl.cpp b/src/gtk/spinctrl.cpp index c859e71b29..d14e452c6c 100644 --- a/src/gtk/spinctrl.cpp +++ b/src/gtk/spinctrl.cpp @@ -112,8 +112,8 @@ bool wxSpinCtrl::Create(wxWindow *parent, wxWindowID id, gtk_spin_button_set_wrap( GTK_SPIN_BUTTON(m_widget), (int)(m_windowStyle & wxSP_WRAP) ); - g_signal_connect(m_widget, "value_changed", G_CALLBACK(gtk_value_changed), this); - g_signal_connect(m_widget, "changed", G_CALLBACK(gtk_changed), this); + g_signal_connect_after(m_widget, "value_changed", G_CALLBACK(gtk_value_changed), this); + g_signal_connect_after(m_widget, "changed", G_CALLBACK(gtk_changed), this); m_parent->DoAddChild( this ); @@ -149,9 +149,9 @@ int wxSpinCtrl::GetValue() const { wxCHECK_MSG( (m_widget != NULL), 0, wxT("invalid spin button") ); - wx_const_cast(wxSpinCtrl*, this)->BlockScrollEvent(); + GtkDisableEvents(); gtk_spin_button_update( GTK_SPIN_BUTTON(m_widget) ); - wx_const_cast(wxSpinCtrl*, this)->UnblockScrollEvent(); + GtkEnableEvents(); return m_pos; } @@ -169,9 +169,9 @@ void wxSpinCtrl::SetValue( const wxString& value ) else { // invalid number - set text as is (wxMSW compatible) - BlockScrollEvent(); + GtkDisableEvents(); gtk_entry_set_text( GTK_ENTRY(m_widget), wxGTK_CONV( value ) ); - UnblockScrollEvent(); + GtkEnableEvents(); } } @@ -179,9 +179,9 @@ void wxSpinCtrl::SetValue( int value ) { wxCHECK_RET( (m_widget != NULL), wxT("invalid spin button") ); - BlockScrollEvent(); + GtkDisableEvents(); gtk_spin_button_set_value((GtkSpinButton*)m_widget, value); - UnblockScrollEvent(); + GtkEnableEvents(); } void wxSpinCtrl::SetSelection(long from, long to) @@ -201,9 +201,28 @@ void wxSpinCtrl::SetRange(int minVal, int maxVal) { wxCHECK_RET( (m_widget != NULL), wxT("invalid spin button") ); - BlockScrollEvent(); + GtkDisableEvents(); gtk_spin_button_set_range((GtkSpinButton*)m_widget, minVal, maxVal); - UnblockScrollEvent(); + GtkEnableEvents(); +} + + +void wxSpinCtrl::GtkDisableEvents() const +{ + g_signal_handlers_block_by_func( m_widget, + (gpointer)gtk_value_changed, (void*) this); + + g_signal_handlers_block_by_func(m_widget, + (gpointer)gtk_changed, (void*) this); +} + +void wxSpinCtrl::GtkEnableEvents() const +{ + g_signal_handlers_unblock_by_func(m_widget, + (gpointer)gtk_value_changed, (void*) this); + + g_signal_handlers_unblock_by_func(m_widget, + (gpointer)gtk_changed, (void*) this); } void wxSpinCtrl::OnChar( wxKeyEvent &event )