AuroraMiddleware/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Minor optimizations in wxProgressDialog

Browse Source 
Don't bother performing the updates if nothing was requested.

And ensure that nothing is requested even more often than it already was
by not requesting an update if the new value is the same as the old one.
This commit is contained in:
Vadim Zeitlin 2017-10-29 23:09:56 +01:00
parent 317470a39a
commit 1c62ebdcd7
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/msw/progdlg.cpp
View File

@ -459,10 +459,13 @@ bool wxProgressDialog::Update(int value, const wxString& newmsg, bool *skip)
{
wxCriticalSectionLocker locker(m_sharedData->m_cs);
m_sharedData->m_value = value;
m_sharedData->m_notifications |= wxSPDD_VALUE_CHANGED;
if ( value != m_sharedData->m_value )
{
m_sharedData->m_value = value;
m_sharedData->m_notifications |= wxSPDD_VALUE_CHANGED;
}
if ( !newmsg.empty() )
if ( !newmsg.empty() && newmsg != m_message )
{
m_message = newmsg;
m_sharedData->m_message = newmsg;
@ -532,7 +535,7 @@ bool wxProgressDialog::Pulse(const wxString& newmsg, bool *skip)
m_sharedData->m_notifications |= wxSPDD_PBMARQUEE_CHANGED;
}
if ( !newmsg.empty() )
if ( !newmsg.empty() && newmsg != m_message )
{
m_message = newmsg;
m_sharedData->m_message = newmsg;
@ -1197,7 +1200,9 @@ wxProgressDialogTaskRunner::TaskDialogCallbackProc
break;
case TDN_TIMER:
PerformNotificationUpdates(hwnd, sharedData);
// Don't perform updates if nothing needs to be done.
if ( sharedData->m_notifications )
PerformNotificationUpdates(hwnd, sharedData);
/*
Decide whether we should end the dialog. This is done if either