Compile improvemnts for strict compilers and the like
Down to two warning messages for egcs compile git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@1331 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
parent
06f46ad1fe
commit
702ca7c070
@ -34,7 +34,7 @@ class WXDLLEXPORT wxPrintInfo;
|
||||
class WXDLLEXPORT wxCommand;
|
||||
class WXDLLEXPORT wxCommandProcessor;
|
||||
class WXDLLEXPORT wxFileHistory;
|
||||
#ifdef wxUSE_CONFIG
|
||||
#if wxUSE_CONFIG
|
||||
class WXDLLEXPORT wxConfigBase;
|
||||
#endif
|
||||
|
||||
@ -344,7 +344,7 @@ class WXDLLEXPORT wxDocManager: public wxEvtHandler
|
||||
virtual wxString GetHistoryFile(int i) const;
|
||||
virtual void FileHistoryUseMenu(wxMenu *menu);
|
||||
virtual void FileHistoryRemoveMenu(wxMenu *menu);
|
||||
#ifdef wxUSE_CONFIG
|
||||
#if wxUSE_CONFIG
|
||||
virtual void FileHistoryLoad(wxConfigBase& config);
|
||||
virtual void FileHistorySave(wxConfigBase& config);
|
||||
#endif
|
||||
@ -516,7 +516,7 @@ class WXDLLEXPORT wxFileHistory: public wxObject
|
||||
// Remove menu from the list (MDI child may be closing)
|
||||
virtual void RemoveMenu(wxMenu *menu);
|
||||
|
||||
#ifdef wxUSE_CONFIG
|
||||
#if wxUSE_CONFIG
|
||||
virtual void Load(wxConfigBase& config);
|
||||
virtual void Save(wxConfigBase& config);
|
||||
#endif
|
||||
|
@ -41,7 +41,7 @@ public:
|
||||
const wxPoint& pos = wxDefaultPosition,
|
||||
const wxSize& size = wxDefaultSize,
|
||||
int nStrings = 0,
|
||||
const wxString choices[] = NULL,
|
||||
const wxString choices[] = (wxString[]) NULL,
|
||||
long style = 0,
|
||||
const wxValidator& validator = wxDefaultValidator,
|
||||
const wxString& name = wxListBoxNameStr);
|
||||
|
@ -41,7 +41,7 @@ public:
|
||||
const wxPoint& pos = wxDefaultPosition,
|
||||
const wxSize& size = wxDefaultSize,
|
||||
int nStrings = 0,
|
||||
const wxString choices[] = NULL,
|
||||
const wxString choices[] = (wxString[]) NULL,
|
||||
long style = 0,
|
||||
const wxValidator& validator = wxDefaultValidator,
|
||||
const wxString& name = wxListBoxNameStr);
|
||||
|
@ -33,11 +33,11 @@ DEBUG = @WXDEBUG@ @WXDEBUG_DEFINE@
|
||||
CC = @CC@
|
||||
CPP = @CPP@
|
||||
CPPFLAGS=@CPPFLAGS@
|
||||
CFLAGS = @CFLAGS@ $(CPPFLAGS) $(OPTIMISE) $(PROFILE) $(DEBUG) -D_REENTRANT
|
||||
CFLAGS = @CFLAGS@ $(CPPFLAGS) $(OPTIMISE) $(PROFILE) $(DEBUG)
|
||||
|
||||
# c++-compiler stuff
|
||||
CXX = @CXX@
|
||||
CXXFLAGS = @CXXFLAGS@ $(CPPFLAGS) $(OPTIMISE) $(PROFILE) $(DEBUG) -D_REENTRANT
|
||||
CXXFLAGS = @CXXFLAGS@ $(CPPFLAGS) $(OPTIMISE) $(PROFILE) $(DEBUG)
|
||||
CXXCPP = @CXXCPP@
|
||||
|
||||
# shared compile stuff
|
||||
|
@ -273,9 +273,9 @@ wxString wxExpandEnvVars(const wxString& str)
|
||||
{
|
||||
Bracket_None,
|
||||
Bracket_Normal = ')',
|
||||
Bracket_Curly = '}',
|
||||
Bracket_Curly = '}'
|
||||
#ifdef __WXMSW__
|
||||
Bracket_Windows = '%' // yeah, Windows people are a bit strange ;-)
|
||||
,Bracket_Windows = '%' // yeah, Windows people are a bit strange ;-)
|
||||
#endif
|
||||
};
|
||||
|
||||
@ -412,4 +412,3 @@ void wxSplitPath(wxArrayString& aParts, const char *sz)
|
||||
|
||||
// wxUSE_CONFIG
|
||||
|
||||
|
@ -1044,7 +1044,7 @@ void wxDocManager::FileHistoryRemoveMenu(wxMenu *menu)
|
||||
m_fileHistory->RemoveMenu(menu);
|
||||
}
|
||||
|
||||
#ifdef wxUSE_CONFIG
|
||||
#if wxUSE_CONFIG
|
||||
void wxDocManager::FileHistoryLoad(wxConfigBase& config)
|
||||
{
|
||||
if (m_fileHistory)
|
||||
@ -1822,7 +1822,7 @@ void wxFileHistory::RemoveMenu(wxMenu *menu)
|
||||
m_fileMenus.DeleteObject(menu);
|
||||
}
|
||||
|
||||
#ifdef wxUSE_CONFIG
|
||||
#if wxUSE_CONFIG
|
||||
void wxFileHistory::Load(wxConfigBase& config)
|
||||
{
|
||||
m_fileHistoryN = 0;
|
||||
|
@ -174,7 +174,8 @@ wxString wxPathList::FindValidPath (const wxString& file)
|
||||
char buf[_MAXPATHLEN];
|
||||
strcpy(buf, wxBuffer);
|
||||
|
||||
char *filename = IsAbsolutePath (buf) ? wxFileNameFromPath (buf) : (char *)buf;
|
||||
char *filename = (char*) NULL; /* shut up buggy egcs warning */
|
||||
filename = IsAbsolutePath (buf) ? wxFileNameFromPath (buf) : (char *)buf;
|
||||
|
||||
for (wxNode * node = First (); node; node = node->Next ())
|
||||
{
|
||||
|
@ -446,44 +446,39 @@ IMPLEMENT_DYNAMIC_CLASS(wxPNGHandler,wxImageHandler)
|
||||
|
||||
bool wxPNGHandler::LoadFile( wxImage *image, const wxString& name )
|
||||
{
|
||||
FILE *f;
|
||||
png_structp png_ptr;
|
||||
png_infop info_ptr;
|
||||
unsigned char *ptr, **lines, *ptr2;
|
||||
int transp,bit_depth,color_type,interlace_type;
|
||||
png_uint_32 width, height;
|
||||
unsigned int i;
|
||||
|
||||
image->Destroy();
|
||||
|
||||
transp = 0;
|
||||
png_ptr = png_create_read_struct( PNG_LIBPNG_VER_STRING, NULL, NULL, NULL );
|
||||
png_structp png_ptr = png_create_read_struct( PNG_LIBPNG_VER_STRING,
|
||||
(voidp) NULL, (png_error_ptr) NULL, (png_error_ptr) NULL );
|
||||
if (!png_ptr) return FALSE;
|
||||
|
||||
info_ptr = png_create_info_struct( png_ptr );
|
||||
png_infop info_ptr = png_create_info_struct( png_ptr );
|
||||
if (!info_ptr)
|
||||
{
|
||||
png_destroy_read_struct( &png_ptr, NULL, NULL );
|
||||
png_destroy_read_struct( &png_ptr, (png_infopp) NULL, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
if (setjmp(png_ptr->jmpbuf))
|
||||
{
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, NULL );
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
if (info_ptr->color_type == PNG_COLOR_TYPE_RGB_ALPHA)
|
||||
{
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, NULL );
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
f = fopen( name, "rb" );
|
||||
FILE *f = fopen( name, "rb" );
|
||||
png_init_io( png_ptr, f );
|
||||
|
||||
png_uint_32 width,height;
|
||||
int bit_depth,color_type,interlace_type;
|
||||
|
||||
png_read_info( png_ptr, info_ptr );
|
||||
png_get_IHDR( png_ptr, info_ptr, &width, &height, &bit_depth, &color_type, &interlace_type, NULL, NULL );
|
||||
png_get_IHDR( png_ptr, info_ptr, &width, &height, &bit_depth, &color_type, &interlace_type, (int*) NULL, (int*) NULL );
|
||||
|
||||
if (color_type == PNG_COLOR_TYPE_PALETTE) png_set_expand( png_ptr );
|
||||
|
||||
@ -496,39 +491,41 @@ bool wxPNGHandler::LoadFile( wxImage *image, const wxString& name )
|
||||
|
||||
if (!image->Ok())
|
||||
{
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, NULL );
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
lines = (unsigned char **)malloc( height * sizeof(unsigned char *) );
|
||||
unsigned char **lines = (unsigned char **)malloc( height * sizeof(unsigned char *) );
|
||||
if (lines == NULL)
|
||||
{
|
||||
image->Destroy();
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, NULL );
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
for (i = 0; i < height; i++)
|
||||
for (unsigned int i = 0; i < height; i++)
|
||||
{
|
||||
if ((lines[i] = (unsigned char *)malloc(width * (sizeof(unsigned char) * 4))) == NULL)
|
||||
{
|
||||
image->Destroy();
|
||||
for (unsigned int n = 0; n < i; n++) free( lines[n] );
|
||||
free( lines );
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, NULL );
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
int transp = 0;
|
||||
png_read_image( png_ptr, lines );
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, NULL );
|
||||
ptr = image->GetData();
|
||||
png_destroy_read_struct( &png_ptr, &info_ptr, (png_infopp) NULL );
|
||||
unsigned char *ptr = image->GetData();
|
||||
if ((color_type == PNG_COLOR_TYPE_GRAY) ||
|
||||
(color_type == PNG_COLOR_TYPE_GRAY_ALPHA))
|
||||
{
|
||||
for (unsigned int y = 0; y < height; y++)
|
||||
{
|
||||
ptr2 = lines[y];
|
||||
unsigned char *ptr2 = lines[y];
|
||||
for (unsigned int x = 0; x < width; x++)
|
||||
{
|
||||
unsigned char r = *ptr2++;
|
||||
@ -553,7 +550,7 @@ bool wxPNGHandler::LoadFile( wxImage *image, const wxString& name )
|
||||
{
|
||||
for (unsigned int y = 0; y < height; y++)
|
||||
{
|
||||
ptr2 = lines[y];
|
||||
unsigned char *ptr2 = lines[y];
|
||||
for (unsigned int x = 0; x < width; x++)
|
||||
{
|
||||
unsigned char r = *ptr2++;
|
||||
@ -577,12 +574,18 @@ bool wxPNGHandler::LoadFile( wxImage *image, const wxString& name )
|
||||
}
|
||||
}
|
||||
}
|
||||
for (i = 0; i < height; i++) free( lines[i] );
|
||||
|
||||
for (unsigned int i = 0; i < height; i++) free( lines[i] );
|
||||
free( lines );
|
||||
|
||||
if (transp)
|
||||
{
|
||||
image->SetMaskColour( 255, 0, 255 );
|
||||
}
|
||||
else
|
||||
{
|
||||
image->SetMask( FALSE );
|
||||
}
|
||||
|
||||
return TRUE;
|
||||
}
|
||||
@ -591,9 +594,10 @@ bool wxPNGHandler::LoadFile( wxImage *image, const wxString& name )
|
||||
bool wxPNGHandler::SaveFile( wxImage *image, const wxString& name )
|
||||
{
|
||||
FILE *f = fopen( name, "wb" );
|
||||
if (f)
|
||||
{
|
||||
png_structp png_ptr = png_create_write_struct( PNG_LIBPNG_VER_STRING, NULL, NULL, NULL);
|
||||
if (!f) return FALSE;
|
||||
|
||||
png_structp png_ptr = png_create_write_struct( PNG_LIBPNG_VER_STRING,
|
||||
(voidp) NULL, (png_error_ptr) NULL, (png_error_ptr) NULL);
|
||||
if (!png_ptr)
|
||||
{
|
||||
fclose( f );
|
||||
@ -604,14 +608,14 @@ bool wxPNGHandler::SaveFile( wxImage *image, const wxString& name )
|
||||
if (info_ptr == NULL)
|
||||
{
|
||||
fclose(f);
|
||||
png_destroy_write_struct( &png_ptr, (png_infopp)NULL );
|
||||
png_destroy_write_struct( &png_ptr, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
if (setjmp(png_ptr->jmpbuf))
|
||||
{
|
||||
fclose( f );
|
||||
png_destroy_write_struct( &png_ptr, (png_infopp)NULL );
|
||||
png_destroy_write_struct( &png_ptr, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
@ -634,7 +638,7 @@ bool wxPNGHandler::SaveFile( wxImage *image, const wxString& name )
|
||||
if (!data)
|
||||
{
|
||||
fclose( f );
|
||||
png_destroy_write_struct( &png_ptr, (png_infopp)NULL );
|
||||
png_destroy_write_struct( &png_ptr, (png_infopp) NULL );
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
@ -649,19 +653,24 @@ bool wxPNGHandler::SaveFile( wxImage *image, const wxString& name )
|
||||
if ((data[(x << 2) + 0] == image->GetMaskRed()) &&
|
||||
(data[(x << 2) + 1] == image->GetMaskGreen()) &&
|
||||
(data[(x << 2) + 2] == image->GetMaskBlue()))
|
||||
{
|
||||
data[(x << 2) + 3] = 0;
|
||||
}
|
||||
else
|
||||
{
|
||||
data[(x << 2) + 3] = 255;
|
||||
}
|
||||
}
|
||||
png_bytep row_ptr = data;
|
||||
png_write_rows( png_ptr, &row_ptr, 1 );
|
||||
}
|
||||
|
||||
free(data);
|
||||
png_write_end( png_ptr, info_ptr );
|
||||
png_destroy_write_struct( &png_ptr, (png_infopp)NULL );
|
||||
png_destroy_write_struct( &png_ptr, (png_infopp) NULL );
|
||||
|
||||
fclose(f);
|
||||
}
|
||||
|
||||
return TRUE;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user