AuroraMiddleware/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Avoid bogus debug errors from wxWindow::SetId() in wxMSW

Browse Source 
::SetWindowLong() can return 0 even if no error occurred but the previous
value of the ID just was 0, so we need to examine the last error to know
whether there really was an error -- and also to reset it to 0 before calling
the function as it wouldn't reset it if it succeeds, it only sets it if it
fails.
This commit is contained in:
Vadim Zeitlin 2015-11-11 22:31:45 +01:00
parent 4ce23e5217
commit 88408d536f
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/msw/window.cpp
View File

@ -512,8 +512,14 @@ void wxWindowMSW::SetId(wxWindowID winid)
// changing its ID because Windows still uses the old one.
if ( GetHwnd() )
{
::SetLastError(0);
if ( !::SetWindowLong(GetHwnd(), GWL_ID, winid) )
wxLogLastError(wxT("SetWindowLong(GWL_ID)"));
{
const DWORD err = ::GetLastError();
if ( err )
wxLogApiError(wxT("SetWindowLong(GWL_ID)"), err);
}
}
}