diff --git a/docs/changes.txt b/docs/changes.txt index afc990aefc..b6f69b02f0 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -232,7 +232,6 @@ wxMSW: - fixed enhanced metafiles loading from files (Andreas Goebel) - wxRadioButtons no longer have to be consecutive in a group -- fixed wxBU_EXACTFIT handling in wxBitmapButton 2.5.3 diff --git a/docs/latex/wx/bbutton.tex b/docs/latex/wx/bbutton.tex index c66953f69a..3aed0a9138 100644 --- a/docs/latex/wx/bbutton.tex +++ b/docs/latex/wx/bbutton.tex @@ -36,6 +36,10 @@ provided bitmaps. WIN32 only.} \twocolitem{\windowstyle{wxBU\_BOTTOM}}{Aligns the bitmap label to the bottom of the button. WIN32 only.} \end{twocollist} +Note that \windowstyle{wxBU\_EXACTFIT} supported by +\helpref{wxButton}{wxbutton} is \emph{not} used by this class as bitmap buttons +don't have any minimal standard size by default. + See also \helpref{window styles overview}{windowstyles}. \wxheading{Event handling} diff --git a/src/msw/bmpbuttn.cpp b/src/msw/bmpbuttn.cpp index af0014cf67..e1be21611f 100644 --- a/src/msw/bmpbuttn.cpp +++ b/src/msw/bmpbuttn.cpp @@ -492,26 +492,14 @@ void wxBitmapButton::SetDefault() wxSize wxBitmapButton::DoGetBestSize() const { - wxSize best; - if (m_bmpNormal.Ok()) + if ( m_bmpNormal.Ok() ) { - best.x = m_bmpNormal.GetWidth() + 2*m_marginX; - best.y = m_bmpNormal.GetHeight() + 2*m_marginY; + return wxSize(m_bmpNormal.GetWidth() + 2*m_marginX, + m_bmpNormal.GetHeight() + 2*m_marginY); } - // all buttons have at least the standard size unless the user explicitly - // wants them to be of smaller size and used wxBU_EXACTFIT style when - // creating the button - if ( !HasFlag(wxBU_EXACTFIT) ) - { - wxSize sz = GetDefaultSize(); - if ( best.x < sz.x ) - best.x = sz.x; - if ( best.y < sz.y ) - best.y = sz.y; - } - - return best; + // no idea what our best size should be, defer to the base class + return wxBitmapButtonBase::DoGetBestSize(); } #endif // wxUSE_BMPBUTTON