From 92b0a2a13ccaaa23a97964ff35cdaf39dd44a104 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Wed, 20 Feb 2002 00:21:26 +0000 Subject: [PATCH] don't inherit the controls colours from the parent - at least for the background colour this is not the right thing to do git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@14314 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/common/ctrlcmn.cpp | 6 ++++++ src/msw/statbox.cpp | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/common/ctrlcmn.cpp b/src/common/ctrlcmn.cpp index a61beaa16c..2ebabc1f0d 100644 --- a/src/common/ctrlcmn.cpp +++ b/src/common/ctrlcmn.cpp @@ -92,8 +92,14 @@ bool wxControlBase::CreateControl(wxWindowBase *parent, // inherit colour and font settings from the parent window void wxControlBase::InheritAttributes() { + // it definitely doesn't make sense to inherit the background colour as the + // controls typically have their own standard one and probably not the + // foreground neither? +#if 0 SetBackgroundColour(GetParent()->GetBackgroundColour()); SetForegroundColour(GetParent()->GetForegroundColour()); +#endif // 0 + SetFont(GetParent()->GetFont()); } diff --git a/src/msw/statbox.cpp b/src/msw/statbox.cpp index a713c99cb5..fb017bd219 100644 --- a/src/msw/statbox.cpp +++ b/src/msw/statbox.cpp @@ -79,6 +79,9 @@ bool wxStaticBox::Create(wxWindow *parent, WS_EX_TRANSPARENT) ) return FALSE; + // to be transparent we should have the same colour as the parent as well + SetBackgroundColour(GetParent()->GetBackgroundColour()); + return TRUE; }