From bab5e0d028e874cd0b472e583d4ab625f4378495 Mon Sep 17 00:00:00 2001 From: Jouk Jansen Date: Thu, 20 Sep 2012 12:33:05 +0000 Subject: [PATCH] backport wxspinctrl::get/setbase form gtk ->gtk1 git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72519 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/gtk1/spinctrl.h | 13 +++++++- src/gtk1/spinctrl.cpp | 68 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+), 1 deletion(-) diff --git a/include/wx/gtk1/spinctrl.h b/include/wx/gtk1/spinctrl.h index e748a60ac9..e1fb0b8cd6 100644 --- a/include/wx/gtk1/spinctrl.h +++ b/include/wx/gtk1/spinctrl.h @@ -68,7 +68,10 @@ public: GtkAdjustment *m_adjust; float m_oldPos; -protected: + virtual int GetBase() const { return m_base; } + virtual bool SetBase(int base); + + protected: virtual wxSize DoGetBestSize() const; // Widgets that use the style->base colour for the BG colour should @@ -76,6 +79,14 @@ protected: virtual bool UseGTKStyleBase() const { return true; } private: + // Common part of all ctors. + void Init() + { + m_base = 10; + } + + int m_base; + DECLARE_DYNAMIC_CLASS(wxSpinCtrl) DECLARE_EVENT_TABLE() }; diff --git a/src/gtk1/spinctrl.cpp b/src/gtk1/spinctrl.cpp index 9c60a0a0d5..6d430eb4f8 100644 --- a/src/gtk1/spinctrl.cpp +++ b/src/gtk1/spinctrl.cpp @@ -44,6 +44,38 @@ extern bool g_blockEventsOnDrag; //----------------------------------------------------------------------------- extern "C" { + +static gboolean +wx_gtk_spin_input(GtkSpinButton* spin, gdouble* val, wxSpinCtrl* win) +{ + // We might use g_ascii_strtoll() here but it's 2.12+ only, so use our own + // wxString function even if this requires an extra conversion. + const wxString + text(wxString::FromUTF8(gtk_entry_get_text(GTK_ENTRY(spin)))); + + long lval; + if ( !text.ToLong(&lval, win->GetBase()) ) + return FALSE; + + *val = lval; + + return TRUE; +} + +static gint +wx_gtk_spin_output(GtkSpinButton* spin, wxSpinCtrl* win) +{ + const gint val = gtk_spin_button_get_value_as_int(spin); + + gtk_entry_set_text + ( + GTK_ENTRY(spin), + wxPrivate::wxSpinCtrlFormatAsHex(val, win->GetMax()).utf8_str() + ); + + return TRUE; +} + static void gtk_spinctrl_callback( GtkWidget *WXUNUSED(widget), wxSpinCtrl *win ) { if (g_isIdle) wxapp_install_idle_handler(); @@ -305,6 +337,42 @@ wxSize wxSpinCtrl::DoGetBestSize() const return best; } +bool wxSpinCtrl::SetBase(int base) +{ + // Currently we only support base 10 and 16. We could add support for base + // 8 quite easily but wxMSW doesn't support it natively so don't bother + // with doing something wxGTK-specific here. + if ( base != 10 && base != 16 ) + return false; + + if ( base == m_base ) + return true; + + m_base = base; + + // We need to be able to enter letters for any base greater than 10. + gtk_spin_button_set_numeric( GTK_SPIN_BUTTON(m_widget), m_base <= 10 ); + + if ( m_base != 10 ) + { + gtk_signal_connect( GTK_OBJECT(m_widget), "input", + GTK_SIGNAL_FUNC(wx_gtk_spin_input), this); + gtk_signal_connect( GTK_OBJECT(m_widget), "output", + GTK_SIGNAL_FUNC(wx_gtk_spin_output), this); + } + else + { + gtk_signal_disconnect_by_func(GTK_OBJECT(m_widget), + GTK_SIGNAL_FUNC(wx_gtk_spin_input), + this); + gtk_signal_disconnect_by_func(GTK_OBJECT(m_widget), + GTK_SIGNAL_FUNC(wx_gtk_spin_output), + this); + } + + return true; +} + // static wxVisualAttributes wxSpinCtrl::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))