AuroraMiddleware/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't change wxTextEntry value if it didn't really change.

Browse Source 
This is not only unnecessary but also can result in a kind of infinite loop
when wxTextEntry::SetValue() is called from wxEVT_IDLE handler as really
modifying the text results in another wxEVT_IDLE being generated and another
call to SetValue() and so on while not doing it in the first place completely
works around the problem and is also more efficient.

Closes #13936.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71308 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin 2012-04-28 22:25:03 +00:00
parent d9abe7f2f9
commit c87df234ac
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/common/textentrycmn.cpp
View File

@ -224,10 +224,19 @@ void wxTextEntryBase::AppendText(const wxString& text)
void wxTextEntryBase::DoSetValue(const wxString& value, int flags)
{
EventsSuppressor noeventsIf(this, !(flags & SetValue_SendEvent));
if ( value != GetValue() )
{
EventsSuppressor noeventsIf(this, !(flags & SetValue_SendEvent));
SelectAll();
WriteText(value);
SelectAll();
WriteText(value);
}
else // Same value, no need to do anything.
{
// Except that we still need to generate the event for consistency with
// the normal case when the text does change.
SendTextUpdatedEvent(GetEditableWindow());
}
SetInsertionPoint(0);
}