From eef9b03d244f8d7168a8b2d0199090959c9125c2 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 20 Jan 2014 14:45:19 +0000 Subject: [PATCH] Don't pass ID to wxWindow::LoadNativeDialog() by reference. This is completely unnecessary and confusing. See #15893. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@75658 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/msw/window.h | 2 +- src/msw/nativdlg.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/wx/msw/window.h b/include/wx/msw/window.h index bd793e143b..b660324e67 100644 --- a/include/wx/msw/window.h +++ b/include/wx/msw/window.h @@ -128,7 +128,7 @@ public: #ifndef __WXUNIVERSAL__ // Native resource loading (implemented in src/msw/nativdlg.cpp) // FIXME: should they really be all virtual? - virtual bool LoadNativeDialog(wxWindow* parent, wxWindowID& id); + virtual bool LoadNativeDialog(wxWindow* parent, wxWindowID id); virtual bool LoadNativeDialog(wxWindow* parent, const wxString& name); wxWindow* GetWindowChild1(wxWindowID id); wxWindow* GetWindowChild(wxWindowID id); diff --git a/src/msw/nativdlg.cpp b/src/msw/nativdlg.cpp index d71c3b13e4..71160b643a 100644 --- a/src/msw/nativdlg.cpp +++ b/src/msw/nativdlg.cpp @@ -43,7 +43,7 @@ extern LONG APIENTRY _EXPORT wxDlgProc(HWND hWnd, UINT message, // implementation // =========================================================================== -bool wxWindow::LoadNativeDialog(wxWindow* parent, wxWindowID& id) +bool wxWindow::LoadNativeDialog(wxWindow* parent, wxWindowID id) { m_windowId = id;