From 4b5a4f02d74d8492c5dc15133fab423290b96266 Mon Sep 17 00:00:00 2001 From: Yann Collet Date: Tue, 4 Dec 2018 16:59:26 -0800 Subject: [PATCH] write the switch()case: differently so that it please both compilers which warn for dead code after the switch and compilers which do not detect that all branches terminate. --- lib/decompress/zstd_decompress.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/decompress/zstd_decompress.c b/lib/decompress/zstd_decompress.c index d2cd8a30..c4cd66c8 100644 --- a/lib/decompress/zstd_decompress.c +++ b/lib/decompress/zstd_decompress.c @@ -1269,11 +1269,8 @@ ZSTD_bounds ZSTD_dParam_getBounds(ZSTD_dParameter dParam) bounds.upperBound = (int)ZSTD_f_zstd1_magicless; ZSTD_STATIC_ASSERT(ZSTD_f_zstd1 < ZSTD_f_zstd1_magicless); return bounds; - default: - bounds.error = ERROR(parameter_unsupported); - return bounds; + default:; } - assert(0); bounds.error = ERROR(parameter_unsupported); return bounds; } @@ -1307,10 +1304,8 @@ size_t ZSTD_DCtx_setParameter(ZSTD_DCtx* dctx, ZSTD_dParameter dParam, int value CHECK_DBOUNDS(ZSTD_d_format, value); dctx->format = (ZSTD_format_e)value; return 0; - default: - return ERROR(parameter_unsupported); + default:; } - assert(0); /* should be unreachable */ return ERROR(parameter_unsupported); }