diff --git a/programs/bench.c b/programs/bench.c index bed7d16b..a2721552 100644 --- a/programs/bench.c +++ b/programs/bench.c @@ -188,7 +188,6 @@ static int BMK_benchMem(const void* srcBuffer, size_t srcSize, /* Bench */ { U64 fastestC = (U64)(-1LL), fastestD = (U64)(-1LL); U64 const crcOrig = XXH64(srcBuffer, srcSize, 0); - U64 crcCheck = 0; UTIL_time_t coolTime; U32 testNb; size_t cSize = 0; @@ -282,7 +281,7 @@ static int BMK_benchMem(const void* srcBuffer, size_t srcSize, (double)srcSize / fastestD ); /* CRC Checking */ - { crcCheck = XXH64(resultBuffer, srcSize, 0); + { U64 const crcCheck = XXH64(resultBuffer, srcSize, 0); if (crcOrig!=crcCheck) { size_t u; DISPLAY("!!! WARNING !!! %14s : Invalid Checksum : %x != %x \n", displayName, (unsigned)crcOrig, (unsigned)crcCheck); @@ -308,12 +307,10 @@ static int BMK_benchMem(const void* srcBuffer, size_t srcSize, #endif } /* for (testNb = 1; testNb <= (g_nbIterations + !g_nbIterations); testNb++) */ - if (crcOrig == crcCheck) { - result->ratio = ratio; - result->cSize = cSize; - result->cSpeed = (double)srcSize / fastestC; - result->dSpeed = (double)srcSize / fastestD; - } + result->ratio = ratio; + result->cSize = cSize; + result->cSpeed = (double)srcSize / fastestC; + result->dSpeed = (double)srcSize / fastestD; DISPLAYLEVEL(2, "%2i#\n", cLevel); } /* Bench */ @@ -402,9 +399,9 @@ static void BMK_loadFiles(void* buffer, size_t bufferSize, const char** fileNamesTable, unsigned nbFiles) { size_t pos = 0, totalSize = 0; - FILE* f; unsigned n; for (n=0; n 1) displayName = mfName; - else displayName = fileNamesTable[0]; - - BMK_benchCLevel(srcBuffer, benchedSize, - displayName, cLevel, cLevelLast, - fileSizes, nbFiles, - dictBuffer, dictBufferSize); + { const char* displayName = (nbFiles > 1) ? mfName : fileNamesTable[0]; + BMK_benchCLevel(srcBuffer, benchedSize, + displayName, cLevel, cLevelLast, + fileSizes, nbFiles, + dictBuffer, dictBufferSize); + } /* clean up */ free(srcBuffer); @@ -482,7 +477,7 @@ static void BMK_syntheticTest(int cLevel, int cLevelLast, double compressibility { char name[20] = {0}; size_t benchedSize = 10000000; - void* srcBuffer = malloc(benchedSize); + void* const srcBuffer = malloc(benchedSize); /* Memory allocation */ if (!srcBuffer) EXM_THROW(21, "not enough memory"); diff --git a/programs/util.h b/programs/util.h index e6eb5f41..44ab4348 100644 --- a/programs/util.h +++ b/programs/util.h @@ -37,7 +37,6 @@ extern "C" { # pragma warning(disable : 4127) /* disable: C4127: conditional expression is constant */ #if _MSC_VER <= 1800 /* (1800 = Visual Studio 2013) */ #define snprintf sprintf_s /* snprintf unsupported by Visual <= 2013 */ - //#define snprintf _snprintf #endif #endif @@ -47,7 +46,7 @@ extern "C" { # define _FILE_OFFSET_BITS 64 /* turn off_t into a 64-bit type for ftello, fseeko */ # if defined(__sun__) /* Sun Solaris 32-bits requires specific definitions */ # define _LARGEFILE_SOURCE /* fseeko, ftello */ -# else +# else # define _LARGEFILE64_SOURCE /* off64_t, fseeko64, ftello64 */ # endif #endif @@ -91,7 +90,7 @@ extern "C" { # define SET_HIGH_PRIORITY SetPriorityClass(GetCurrentProcess(), REALTIME_PRIORITY_CLASS) # define UTIL_sleep(s) Sleep(1000*s) # define UTIL_sleepMilli(milli) Sleep(milli) -#elif (defined(__unix__) || defined(__unix) || defined(__midipix__) || (defined(__APPLE__) && defined(__MACH__))) +#elif (defined(__unix__) || defined(__unix) || defined(__midipix__) || (defined(__APPLE__) && defined(__MACH__))) # include # include /* setpriority */ # include /* clock_t, nanosleep, clock, CLOCKS_PER_SEC */ @@ -140,8 +139,8 @@ UTIL_STATIC void UTIL_waitForNextTick(UTIL_time_t ticksPerSecond) { UTIL_time_t clockStart, clockEnd; UTIL_getTime(&clockStart); - do { - UTIL_getTime(&clockEnd); + do { + UTIL_getTime(&clockEnd); } while (UTIL_getSpanTimeNano(ticksPerSecond, clockStart, clockEnd) == 0); } @@ -280,7 +279,7 @@ UTIL_STATIC int UTIL_prepareFileList(const char *dirName, char** bufStart, size_ fprintf(stderr, "Cannot open directory '%s': %s\n", dirName, strerror(errno)); return 0; } - + while ((entry = readdir(dir)) != NULL) { if (strcmp (entry->d_name, "..") == 0 || strcmp (entry->d_name, ".") == 0) continue; @@ -324,8 +323,8 @@ UTIL_STATIC int UTIL_prepareFileList(const char *dirName, char** bufStart, size_ #endif // #ifdef _WIN32 -/* - * UTIL_createFileList - takes a list of files and directories (params: inputNames, inputNamesNb), scans directories, +/* + * UTIL_createFileList - takes a list of files and directories (params: inputNames, inputNamesNb), scans directories, * and returns a new list of files (params: return value, allocatedBuffer, allocatedNamesNb). * After finishing usage of the list the structures should be freed with UTIL_freeFileList(params: return value, allocatedBuffer) * In case of error UTIL_createFileList returns NULL and UTIL_freeFileList should not be called.