Bug 2910639: Nil reference on dylib project dependency

CHANGES.txt

@@ -10,6 +10,7 @@
 - Bug 2909463: Fix Xcode handling of Obj-C++ .mm files
 - Bug 2903430: Using relative instead of absolute paths with $() macro
 - Bug 2910691: Duplicate build options
+- Bug 2910639: Nil reference on dylib project dependency
 
 
 -------

src/actions/xcode/xcode_common.lua

@@ -24,6 +24,7 @@
 			[".cc"] = "Sources",
 			[".cpp"] = "Sources",
 			[".cxx"] = "Sources",
+			[".dylib"] = "Frameworks",
 			[".framework"] = "Frameworks",
 			[".m"] = "Sources",
 			[".mm"] = "Sources",

tests/actions/xcode/test_xcode_dependencies.lua

@@ -40,7 +40,7 @@
 -- PBXBuildFile tests
 ---------------------------------------------------------------------------
 
-	function suite.PBXBuildFile_ListsDependencyTargets()
+	function suite.PBXBuildFile_ListsDependencyTargets_OnStaticLib()
 		prepare()
 		xcode.PBXBuildFile(tr)
 		test.capture [[
@@ -50,6 +50,17 @@
 		]]
 	end
 
+	function suite.PBXBuildFile_ListsDependencyTargets_OnSharedLib()
+		kind "SharedLib"
+		prepare()
+		xcode.PBXBuildFile(tr)
+		test.capture [[
+/* Begin PBXBuildFile section */
+		[libMyProject2-d.dylib:build] /* libMyProject2-d.dylib in Frameworks */ = {isa = PBXBuildFile; fileRef = [libMyProject2-d.dylib] /* libMyProject2-d.dylib */; };
+/* End PBXBuildFile section */
+		]]
+	end
+
 
 ---------------------------------------------------------------------------
 -- PBXContainerItemProxy tests
@@ -112,7 +123,7 @@
 -- PBXFrameworksBuildPhase tests
 ---------------------------------------------------------------------------
 
-	function suite.PBXFrameworksBuildPhase_ListsDependencies()
+	function suite.PBXFrameworksBuildPhase_ListsDependencies_OnStaticLib()
 		prepare()
 		xcode.PBXFrameworksBuildPhase(tr)
 		test.capture [[
@@ -129,6 +140,23 @@
 		]]
 	end
 
+	function suite.PBXFrameworksBuildPhase_ListsDependencies_OnSharedLib()
+		kind "SharedLib"
+		prepare()
+		xcode.PBXFrameworksBuildPhase(tr)
+		test.capture [[
+/* Begin PBXFrameworksBuildPhase section */
+		[MyProject:fxs] /* Frameworks */ = {
+			isa = PBXFrameworksBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+				[libMyProject2-d.dylib:build] /* libMyProject2-d.dylib in Frameworks */,
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+		};
+/* End PBXFrameworksBuildPhase section */
+		]]
+	end
 
 ---------------------------------------------------------------------------
 -- PBXGroup tests