[+] I dont see how, but double registered requests would've crashed the client due to a shitily written loop

This commit is contained in:
Reece Wilson 2022-07-09 01:49:36 +01:00
parent 4508b07802
commit c8316caae4

View File

@ -163,11 +163,10 @@ void AuRPCClientChannel::ProcessResponse(const AuSPtr<AuRPCResponse> &response)
for (auto itr = this->outstandingRequests.begin(); for (auto itr = this->outstandingRequests.begin();
itr != this->outstandingRequests.end(); itr != this->outstandingRequests.end();
) itr++)
{ {
if (response->cookie != AuUInt(itr->get())) if (response->cookie != AuUInt(itr->get()))
{ {
itr++;
continue; continue;
} }
@ -178,6 +177,7 @@ void AuRPCClientChannel::ProcessResponse(const AuSPtr<AuRPCResponse> &response)
{ {
req->callback->OnResponse(*response); req->callback->OnResponse(*response);
} }
break;
} }
} }