AuroraSupport/AuroraRuntime
2
1
Fork 0
Code Issues 27 Pull Requests Releases Wiki Activity

[*] NT Optimization: more aggressive semaphores to prevent atomic failures (perhaps this could be made to account for weak exchanges under different archs)

Browse Source
This commit is contained in:
Reece Wilson 2023-09-02 19:05:07 +01:00
parent 73a52552f7
commit 0838373410
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Source/Threading/Primitives/AuSemaphore.NT.cpp
View File

@ -36,8 +36,17 @@ namespace Aurora::Threading::Primitives
bool SemaphoreImpl::TryLockNoSpin()
{
auto old = this->dwState_;
return (old != 0 && AuAtomicCompareExchange(&this->dwState_, old - 1, old) == old);
AuUInt32 uOld {};
while ((uOld = this->dwState_))
{
if (AuAtomicCompareExchange(&this->dwState_, uOld - 1, uOld) == uOld)
{
return true;
}
}
return false;
}
bool SemaphoreImpl::TryLockHeavy()
@ -87,10 +96,7 @@ namespace Aurora::Threading::Primitives
if (gUseNativeWaitSemapahore)
{
AuUInt32 uYieldCounter {};
auto old = this->dwState_;
while (!((old != 0) &&
(AuAtomicCompareExchange(&this->dwState_, old - 1, old) == old)))
while (!this->TryLockNoSpin())
{
static const AuUInt32 kExpect { 0 };
@ -103,8 +109,6 @@ namespace Aurora::Threading::Primitives
{
return false;
}
old = this->dwState_;
}
return true;
@ -148,9 +152,8 @@ namespace Aurora::Threading::Primitives
if (gUseNativeWaitSemapahore)
{
AuUInt32 uYieldCounter {};
auto old = this->dwState_;
while (!((old != 0) &&
(AuAtomicCompareExchange(&this->dwState_, old - 1, old) == old)))
while (!this->TryLockNoSpin())
{
static const AuUInt32 kExpect { 0 };
@ -163,8 +166,6 @@ namespace Aurora::Threading::Primitives
{
return false;
}
old = this->dwState_;
}
return true;