From 2c3c7b04e5e467829ecf670860e4d70658d338a8 Mon Sep 17 00:00:00 2001 From: Jamie Reece Wilson Date: Sun, 11 Aug 2024 22:22:43 +0100 Subject: [PATCH] [*] Amend Loop.hpp comments --- Include/Aurora/IO/Loop/Loop.hpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Include/Aurora/IO/Loop/Loop.hpp b/Include/Aurora/IO/Loop/Loop.hpp index ed244997..473ed75d 100644 --- a/Include/Aurora/IO/Loop/Loop.hpp +++ b/Include/Aurora/IO/Loop/Loop.hpp @@ -77,7 +77,7 @@ namespace Aurora::IO::Loop AUKN_SYM AuSPtr NewLSEvent(bool bTriggered = false, bool bAtomicRelease = true, bool bPermitMultipleTriggers = false); AUKN_SYM AuSPtr NewLSEventSlow(bool bTriggered = false, bool bAtomicRelease = true, bool bPermitMultipleTriggers = false); // interop-ready (usable with DbgLoopSourceToReadFd) AUKN_SYM AuSPtr NewLSSemaphoreSlow(AuUInt32 uInitialCount = 0); // interop-ready (usable with DbgLoopSourceToReadFd) - AUKN_SYM AuSPtr NewLSSemaphore(AuUInt32 uInitialCount = 0); // warn: no IPC counterpart + AUKN_SYM AuSPtr NewLSSemaphore(AuUInt32 uInitialCount = 0); AUKN_SYM AuSPtr NewLSSemaphoreEx(AuUInt32 uInitialCount = 0, AuUInt32 uMaxCount = 0); // warn: no IPC counterpart AUKN_SYM AuSPtr NewLSOSHandle(AuUInt); AUKN_SYM AuSPtr NewLSAsync(Aurora::Async::WorkerPId_t workerPid); // warn: no IPC counterpart @@ -92,10 +92,10 @@ namespace Aurora::IO::Loop // warn: Only works on singular loop sources // warn: You should only use trust the interop-ready sources to serve the HANDLE/fd you expect. // The primary loop-source primitives are capable of bypassing the kernels io scheduler via in-process atomics. - // These can be leveraged AuLoop::WaitMultipleLoopSources with kWaitMultipleFlagAvoidKern and future planned ILoopSource methods. + // These can be leveraged with AuLoop::WaitMultipleLoopSources with kWaitMultipleFlagAvoidKern (and future planned ILoopSource methods.) // For scheduling io events, the atomic optimizations are pointless. They can, however, serve to deduplicate multiple event triggers // and optimize the wait-on operation of win32-on-unix/win32 emulators. - // In addition, D3D, Winsock, NT IO, and other subsystems of a modern coreos system expects (or at least, are documented to expect) + // In addition, D3D, Winsock, NT IO, and other subsystems of a modern coreos system expects (or at least, are documented to expect) // kernel event handle objects for synchronization - not semaphores with some atomic word in a process god knows where. AUKN_SYM AuInt64 DbgLoopSourceToReadFd(AuSPtr pLoopSource); @@ -131,4 +131,4 @@ namespace Aurora::IO::Loop #if defined(AURORA_IS_LINUX_DERIVED) AUKN_SYM AuSPtr NewLSSignalCatcher(const AuList &signals); #endif -} \ No newline at end of file +}