AuroraSupport/AuroraRuntime
2
1
Fork 0
Code Issues 27 Pull Requests Releases Wiki Activity

[*] Extend paranoia

Browse Source
This commit is contained in:
Reece Wilson 2023-12-30 14:50:36 +00:00
parent 3c19c7a56e
commit 3db7f527f4
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Source/Threading/Primitives/AuConditionVariable.NT.cpp
View File

@ -290,11 +290,30 @@ namespace Aurora::Threading::Primitives
if (uSignalNext == 0)
{
// Last thread sets the wait-bit (not atomic)
InterlockedOr((volatile LONG *)&this->wlist, 1);
if (AuAtomicLoad(&this->signalCount) != 0) [[unlikely]]
AuUInt32 uSignalCount {};
if ((uSignalCount = AuAtomicLoad(&this->signalCount)) != 0) [[unlikely]]
{
// Our CAS was wrong, and we potentially cock-blocked a waking thread, unset the sleep bit
// (note, i dont see this happening in real world applications, but lets continue)
// (also note, this could've been avoided with stict 8-byte atomic ops across all archs. no thank you.)
AuAtomicUnset(&this->wlist, 0);
// WaitOnAddress-based paranoia (only keyed events wont be lost throughout this potential nonatomic race condition):
if (gUseNativeWaitCondvar)
{
// Whatever, NT kernelbase's monitor address signaling is almost free
if (uSignalCount > 1)
{
InternalLTSWakeAll((const void *)&this->wlist);
}
else
{
InternalLTSWakeOne((const void *)&this->wlist);
}
}
}
}