AuroraSupport/AuroraRuntime
2
1
Fork 0
Code Issues 27 Pull Requests Releases Wiki Activity

[*] Update the FutexSemaphore to wake no more than the requested wake count

Browse Source 
[*] Cleanup NTs semaphore
This commit is contained in:
Reece Wilson 2023-12-06 11:14:23 +00:00
parent b35b290afd
commit 8b4ad9795c
2 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Include/Aurora/Threading/Waitables/FutexSemaphoreWaitable.hpp
View File

@ -71,7 +71,7 @@ namespace Aurora::Threading::Waitables
if (auto uSleeping = AuAtomicLoad(&this->uAtomicSleeping))
{
WakeNOnAddress((const void *)&this->uAtomicState, uSleeping);
WakeNOnAddress((const void *)&this->uAtomicState, AuMin(uSleeping, uThreads));
}
}

13
Source/Threading/Primitives/AuSemaphore.NT.cpp
View File

@ -219,10 +219,10 @@ namespace Aurora::Threading::Primitives
return;
}
AuAtomicAdd<AuUInt32>(&this->dwState_, uCount);
if (gUseNativeWaitSemapahore)
{
AuAtomicAdd<AuUInt32>(&this->dwState_, uCount);
if (auto dwSleeping = AuAtomicLoad(this->GetSleepCounter()))
{
if (uCount == 1)
@ -237,14 +237,9 @@ namespace Aurora::Threading::Primitives
}
else
{
// realistically, we cant use the sleep counter optimization trick under windows 7
// we would have to expand our already oversized by 8, 24-byte x86_64 semaphore for a trivial perf boost
// we cant efficiently access the conditions state or atomic guarantees...
AuAtomicAdd<AuUInt32>(&this->dwState_, uCount); // this could be moved anywhere above the unlock, including above the lock.
// do not [re]move this lock fence
{
this->mutex.Lock(); // do not [re]move this lock fence
this->mutex.Lock();
this->mutex.Unlock();
}