AuroraSupport/AuroraRuntime
2
1
Fork 0
Code Issues 27 Pull Requests Releases Wiki Activity

[*] AuCmdLine::GetValue(...) (both variants) refactored to use views to help with future stability issues around AuStrings (and their allocator?)

Browse Source
This commit is contained in:
Reece Wilson 2024-09-27 22:46:50 +01:00
parent 8063600b4f
commit f059141505
2 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Include/Aurora/CmdLine/CmdLine.hpp
View File

@ -36,14 +36,14 @@ namespace Aurora::CmdLine
* @param defaultValue
* @return
*/
AUKN_SYM const AuString &GetValue(const AuROString &key, const AuString &defaultValue);
AUKN_SYM AuROString GetValue(const AuROString &key, const AuROString &defaultValue);
/**
* @brief Returns part after key=
* @param key
* @return
*/
AUKN_SYM AuOptional<const AuString &> GetValue(const AuROString &key);
AUKN_SYM AuOptional<AuROString> GetValue(const AuROString &key);
/**
* @brief Returns a constant array of values; key=values and /key values

25
Source/CmdLine/AuCmdLine.cpp
View File

@ -35,27 +35,32 @@ namespace Aurora::CmdLine
AuExists(gCmdValueMap, key);
}
AUKN_SYM const AuString &GetValue(const AuROString &key, const AuString &defaultValue)
AUKN_SYM AuROString GetValue(const AuROString &key, const AuROString &defaultValue)
{
auto itr = gCmdValueMap.find(key);
if (itr == gCmdValueMap.end())
AuString *pValue {};
if (AuTryFind(gCmdValueMap, key, pValue))
{
return defaultValue;
return *pValue;
}
else
{
return itr->second;
return defaultValue;
}
}
AUKN_SYM AuOptional<const AuString &> GetValue(const AuROString &key)
AUKN_SYM AuOptional<AuROString> GetValue(const AuROString &key)
{
auto itr = gCmdValueMap.find(key);
if (itr == gCmdValueMap.end())
AuString *pValue {};
if (AuTryFind(gCmdValueMap, key, pValue))
{
return AuOptional<const AuString &> {};
return *pValue;
}
else
{
return AuOptional<AuROString> {};
}
return itr->second;
}
AUKN_SYM const AuList<AuString> &GetValues(const AuROString &key)