AuroraSupport/AuroraRuntime
2
1
Fork 0
Code Issues 26 Pull Requests Releases Wiki Activity

[*] IOSubmit.Linux.cpp bugfix: save wasted time cancelling triggered polls resulting in a -1 EINVAL

Browse Source
This commit is contained in:
Reece Wilson 2022-08-10 17:22:25 +01:00
parent 868de46abd
commit f98174b7a2
1 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Source/IO/UNIX/IOSubmit.Linux.cpp
View File

@ -685,16 +685,18 @@ namespace Aurora::IO::UNIX
} while (timeout ? !bEpollTriggered : false);
io_event finalEpollEvent;
if (io_cancel(io->context, ptr, &finalEpollEvent) == 0)
io_event finalEpollEvent {};
if ((bEpollTriggered) ||
(io_cancel(io->context, ptr, &finalEpollEvent) == 0))
{
// TODO (Reece): if finalEpollEvent.res == 1, bEpollTriggered = true?
}
else
{
// Do I care?
//SysPushErrorIO();
SysPushErrorIO();
// I don't
// I do again
}
if (bEpollTriggered)
@ -843,7 +845,21 @@ namespace Aurora::IO::UNIX
for (int i = 0; i < iocbIdx; i++)
{
io_event finalEpollEvent;
io_event finalEpollEvent {};
if (i == 0)
{
if ((bReadTriggered) ||
((read == -1) && (bWriteTriggered)))
{
continue;
}
}
else if ((i == 1) && (bWriteTriggered))
{
continue;
}
if (io_cancel(io->context, ptrArray[i], &finalEpollEvent) == 0)
{
// TODO (Reece): if finalEpollEvent.res == 1, bEpollTriggered = true?
@ -851,8 +867,9 @@ namespace Aurora::IO::UNIX
else
{
// Do I care?
//SysPushErrorIO();
SysPushErrorIO();
// I don't
// I do again
}
}