Hans-Kristian Arntzen
192a882df3
Also unpack regular unary/binary operations on MSL.
...
Apparently MSL gets confused when you have packed_float3 op float3 ...
2018-06-11 16:23:09 +02:00
Hans-Kristian Arntzen
dc565136fb
Merge pull request #604 from KhronosGroup/fix-603
...
Unpack expressions when used in functions on MSL.
2018-06-11 12:09:58 +02:00
Hans-Kristian Arntzen
b86bd0a265
Unpack expressions when used in functions on MSL.
...
OSX 10.14 broke (?) how overload resolution works,
so overloading e.g. dot(float3, packed_float3) no longer works.
Fix this by unpacking expressions before various func ops.
This fix might need to be applied elsewhere, but do so later if needed.
2018-06-11 10:56:45 +02:00
Hans-Kristian Arntzen
c5b6ba239c
Merge pull request #599 from KhronosGroup/fix-295
...
Emit matrix layouts in structs directly.
2018-06-05 10:03:34 +02:00
Hans-Kristian Arntzen
f1e8555801
Emit matrix layouts in structs directly.
...
Unlike GLSL, child structs do not inherit matrix layouts.
2018-06-05 09:42:07 +02:00
Hans-Kristian Arntzen
b1196f2ace
Merge pull request #598 from KhronosGroup/fix-594
...
Sanitize underscores in general, not just for members.
2018-06-04 10:33:49 +02:00
Hans-Kristian Arntzen
6bcc890e63
Sanitize underscores in general, not just for members.
2018-06-04 10:13:57 +02:00
Hans-Kristian Arntzen
6fea07f2fd
Merge pull request #597 from KhronosGroup/fix-595-596-592
...
Various maintenance fixes.
2018-06-03 12:22:25 +02:00
Hans-Kristian Arntzen
3a9b045dc3
Various maintenance fixes.
...
- Do not emit set = in GLSL, even when non-zero.
- Fix warning on tautological comparison.
- Expose get_buffer_block_flags as mentioned in reflection guide.
2018-06-03 12:00:22 +02:00
Hans-Kristian Arntzen
0a83bacf3e
Merge pull request #593 from KhronosGroup/old-clang-compile
...
Fix compile on older clang.
2018-05-30 19:58:48 +01:00
Hans-Kristian Arntzen
2a1ab4108b
Fix compile on older clang.
2018-05-30 20:14:26 +02:00
Hans-Kristian Arntzen
6ef1c49ec0
Merge pull request #591 from KhronosGroup/fix-578
...
Fix image load/store on cube arrays in MSL.
2018-05-25 13:27:29 +01:00
Hans-Kristian Arntzen
04b149feb0
Fix image load/store on cube arrays in MSL.
2018-05-25 12:43:25 +02:00
Hans-Kristian Arntzen
8bac5c09f3
Merge pull request #590 from KhronosGroup/fix-581
...
Deal with packed expressions in more scenarios.
2018-05-25 10:24:33 +01:00
Hans-Kristian Arntzen
f65120c147
Deal with packed expressions in more scenarios.
...
Make a new "to_extract_component_expression" helper.
2018-05-25 10:57:02 +02:00
Hans-Kristian Arntzen
db1ed375b0
Merge pull request #589 from KhronosGroup/fix-580
...
Use const device address space for readonly SSBOs in MSL.
2018-05-25 09:45:52 +01:00
Hans-Kristian Arntzen
280fb93204
Add test for reading SSBO from fragment shader on MSL.
2018-05-25 10:20:17 +02:00
Hans-Kristian Arntzen
a1b3964cbd
Run format_all.sh.
2018-05-25 10:14:13 +02:00
Hans-Kristian Arntzen
6b3da831be
Declare read-only SSBOs as const device in MSL.
2018-05-25 10:14:05 +02:00
Hans-Kristian Arntzen
08336e7bbb
Merge pull request #588 from KhronosGroup/pr-583
...
Commit tests for PR #583
2018-05-24 09:53:19 +01:00
Hans-Kristian Arntzen
46bf17c5d3
Add SREM tests for HLSL/MSL.
2018-05-24 10:34:36 +02:00
Hans-Kristian Arntzen
7cba89b4a5
Add reference files for SREM.
2018-05-24 10:26:11 +02:00
Jin Zhou
6b144cc609
handle OpSRem
2018-05-24 10:22:01 +02:00
Jin Zhou
e792cd6160
no expression type for OpSRem
...
fix issue#582
2018-05-24 10:22:01 +02:00
Hans-Kristian Arntzen
f1eacba244
Merge pull request #587 from zeux/master
...
Fix textureGrad compilation for legacy targets
2018-05-24 09:14:17 +01:00
Arseny Kapoulkine
91fd41816f
Fix textureGrad compilation for legacy targets
...
textureGrad isn't part of core GL2 or GLES2. In desktop GL, it's
provided by GL_ARB_shader_texture_lod and is called texture2DGradARB; in
ES, it's provided by GL_EXT_shader_texture_lod and is called
texture2DGradEXT.
This change rewrites textureGrad similarly to textureProj as per above.
2018-05-23 14:06:37 -07:00
Hans-Kristian Arntzen
8cc1fdbb30
Merge pull request #586 from KhronosGroup/fix-584
...
Add support for inheriting bindings for combined image samplers.
2018-05-23 22:01:48 +01:00
Hans-Kristian Arntzen
ba15daee33
Add support for inheriting bindings for combined image samplers.
2018-05-23 20:34:26 +01:00
Hans-Kristian Arntzen
f929c361c5
Merge pull request #577 from KhronosGroup/fix-575
...
Fix atomic_compare_exchange_weak_explicit.
2018-05-16 11:09:12 +02:00
Hans-Kristian Arntzen
bcaae84c76
Deal with scoping for Private variables.
2018-05-16 10:49:30 +02:00
Hans-Kristian Arntzen
26b887ec99
Fix atomic_compare_exchange_weak_explicit.
...
Need to emit a CAS loop.
Fix shared memory declaration.
Declare atomic ops with correct memory scope.
2018-05-15 16:04:21 +02:00
Hans-Kristian Arntzen
62c6d2d498
Merge pull request #576 from KhronosGroup/fix-574
...
Fix OpSpecConstantComposite if it contains a SpecConstantOp.
2018-05-15 14:46:35 +02:00
Hans-Kristian Arntzen
fb7181bff1
Run format_all.sh.
2018-05-15 14:24:59 +02:00
Hans-Kristian Arntzen
c643addacd
Only reflect spec constant if it actually has a constant ID.
2018-05-15 14:24:44 +02:00
Hans-Kristian Arntzen
991b655c72
Declare OpSpecConstantOp up-front on relevant targets.
...
Required, since spec constants can include results from constant ops.
2018-05-15 14:20:16 +02:00
Hans-Kristian Arntzen
0617b98613
Run format_all.sh.
2018-05-15 11:16:35 +02:00
Hans-Kristian Arntzen
3951b9456f
Fix SpecConstantComposite if input is SpecConstantOp.
2018-05-15 11:16:06 +02:00
Hans-Kristian Arntzen
c74dc4578a
Merge pull request #572 from KhronosGroup/vulkan-glsl-sampler-mediump
...
Use mediump on images in --vulkan-semantics as well.
2018-05-11 11:21:51 +02:00
Hans-Kristian Arntzen
01080365fa
Use mediump on images in --vulkan-semantics as well.
2018-05-11 10:59:29 +02:00
Hans-Kristian Arntzen
9d370aca58
Merge pull request #571 from KhronosGroup/fix-570
...
Handle inout properly with split access chains.
2018-05-11 10:39:54 +02:00
Hans-Kristian Arntzen
7eba247864
Handle inout properly with split access chains.
...
Found some other issues. Had some bugs with variable writes not properly
invalidating if writes came from split access chains.
2018-05-11 10:15:42 +02:00
Hans-Kristian Arntzen
97e38bcd38
Merge pull request #569 from KhronosGroup/fix-566
...
Fix split access chains for builtin arrays.
2018-05-08 15:54:17 +02:00
Hans-Kristian Arntzen
b71f5dfc0c
Fix split access chains for builtin arrays.
2018-05-08 15:34:20 +02:00
Hans-Kristian Arntzen
e4694a8403
Merge pull request #568 from KhronosGroup/fix-567
...
Fix GCC 8.1 build.
2018-05-08 00:07:54 +02:00
Hans-Kristian Arntzen
903b798da7
Fix GCC 8.1 build.
2018-05-07 23:41:53 +02:00
Hans-Kristian Arntzen
d3b966322d
Merge pull request #565 from pmuetschard/master
...
Don't limit GLSL identifiers with HLSL keywords.
2018-05-07 21:07:01 +02:00
Pascal Muetschard
aced6058b4
Don't limit GLSL identifiers with HLSL keywords.
...
- The HLSL compiler now has its own list of keywords in addition to
the ones from GLSL.
- Added "buffer", "precise", and "shared" to the GLSL keywords.
2018-05-07 10:58:52 -07:00
Hans-Kristian Arntzen
2792f8f3f2
Merge pull request #564 from KhronosGroup/fix-563
...
Do not use RMW rewrite for matrices.
2018-05-04 10:56:39 +02:00
Hans-Kristian Arntzen
85a8f066f4
Do not use RMW rewrite for matrices.
...
Does not work on MSL.
2018-05-04 10:35:56 +02:00
Hans-Kristian Arntzen
04f0a08cfc
Merge pull request #562 from KhronosGroup/fix-561
...
Do not clear spv_function_implementations on MSL.
2018-05-04 10:08:13 +02:00