Commit Graph

3678 Commits

Author SHA1 Message Date
Steven Perron
673d8bfcb6
Checkout abseil in the smoketest (#5248)
Now that shaderc knows about abseil, we want to check it out. Hopefully
this fixes the smoketest.
2023-05-29 14:23:43 -04:00
Steven Perron
06bbd7f53a
Update deps in sva (#5246)
Depenabot is not able to update these deps to avoid security issues. I'm
updating all of them manually. This was done by running `yarn upgrade
--latest`. I do not claim to understand the changes to `yarn.lock`.
2023-05-29 14:18:37 -04:00
Spencer Fricke
23cb9b96cc
spirv-val: Remove VUID from 1.3.251 spec (#5244) 2023-05-29 09:20:07 -04:00
Steven Perron
1021ec302f
Add Abseil dep to the README (#5242) 2023-05-26 10:50:09 -04:00
Steven Perron
3e82fa067d
Revert "Disable RE2 autoroll (#5234)" (#5239)
This reverts commit e357a36ccf.
2023-05-26 10:49:33 -04:00
github-actions[bot]
e0936b646c
Roll external/spirv-headers/ bdbfd019b..69155b22b (1 commit) (#5238)
bdbfd019be...69155b22b3

$ git log bdbfd019b..69155b22b --date=short --no-merges --format='%ad %ae %s'
2023-05-18 jjfumero Name and url for the TornadoVM SPIR-V Library Tool updated

Created with:
  roll-dep external/spirv-headers

Co-authored-by: GitHub Actions[bot] <>
2023-05-25 09:34:36 -04:00
Steven Perron
af27ece750
Check if const is zero before getting components. (#5217)
* Check if const is zero before getting components.

Two folding rules try to cast a constant to a MatrixConstant before
checking if it is a Null constant. This leads to the null pointer being
dereferneced. The solution is to move the check for zero earlier.

Fixes https://github.com/microsoft/DirectXShaderCompiler/issues/5063
2023-05-25 09:07:22 -04:00
Steven Perron
2358001827
Add Abseil as a dep and update RE2 (#5236)
* Add Abseil as a dep and update RE2

The latest version of RE2 requires Abseil. This PR adds Abseil as an
external dependence, and update RE2 to use it.

* Remove debug code and add comment.
2023-05-25 09:00:30 -04:00
Jim Blandy
f29e11dcb6
diff: Don't give up entry point matching too early. (#5224)
Addresses one case mentioned in #5218.
2023-05-24 15:28:45 -04:00
Pankaj Mistry
82b1a87b21
Add SPV_NV_bindless_texture to spirv optimizations (#5231) 2023-05-24 11:01:11 -04:00
github-actions[bot]
60c546f3ff
Roll external/googletest/ bc860af08..bb2941fcc (1 commit) (#5220)
* Roll external/googletest/ bb2941fcc..458046912 (8 commits)

bb2941fcc6...4580469122

$ git log bb2941fcc..458046912 --date=short --no-merges --format='%ad %ae %s'
2023-05-21 shlomi Add CXX_STANDARD_REQUIRED to CMake quickstart
2023-05-17 dinor Fix typo in version number example in README
2023-05-16 dinor Explicitly document googletest release tag format
2023-05-11 131433627+yagneshprajapati Update README.md
2023-05-11 131433627+yagneshprajapati Update README.md
2023-05-11 131433627+yagneshprajapati Update README.md
2023-05-08 pateldeev Add missing absl dependency from build.
2023-05-07 131433627+yagneshprajapati Update README.md

Created with:
  roll-dep external/googletest

* Roll external/spirv-headers/ 268a06176..bdbfd019b (1 commit)

268a061764...bdbfd019be

$ git log 268a06176..bdbfd019b --date=short --no-merges --format='%ad %ae %s'
2023-05-05 kevin.petit Make the generated operators for masks constexpr

Created with:
  roll-dep external/spirv-headers

---------

Co-authored-by: GitHub Actions[bot] <>
2023-05-24 11:00:43 -04:00
Steven Perron
dcfea36ab7
Have the macos bazel build us git-sync-deps (#5235) 2023-05-24 10:56:37 -04:00
Steve Urquhart
44c9da6fee
Remove const zero image operands (#5232) 2023-05-24 10:30:10 -04:00
Steven Perron
e357a36ccf
Disable RE2 autoroll (#5234)
RE2 now depends on Abseil. We need to figure out how to add that
dependency. Disable the autoroll for now.

https://github.com/KhronosGroup/SPIRV-Tools/issues/5233
2023-05-24 16:19:36 +02:00
Nathan Gauër
e7c6084fd1
Prepare release 2023.3 (#5222)
* Roll external/googletest/ bc860af08..bb2941fcc (1 commit)

bc860af087...bb2941fcc6

$ git log bc860af08..bb2941fcc --date=short --no-merges --format='%ad %ae %s'
2023-05-11 absl-team Give CreateArgvFromArgs internal linkage

Created with:
  roll-dep external/googletest

* Prepare release v2023.3

Signed-off-by: Nathan Gauër <brioche@google.com>

---------

Signed-off-by: Nathan Gauër <brioche@google.com>
2023-05-16 17:06:35 +02:00
Kévin Petit
17a26b45ff
Improve an error message in the assembler (#5219)
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
2023-05-15 09:56:48 -04:00
Spencer Fricke
7c39951f6e
spirv-val: Label Interface Location/Component VUIDs (#5221) 2023-05-15 09:53:37 -04:00
Steven Perron
51892874ba
Run ADCE when the printf extension is used. (#5215)
This is for
https://github.com/microsoft/DirectXShaderCompiler/issues/5136.
2023-05-10 10:03:40 +02:00
Chris Oattes
e803fe6717
Don't convert struct members to half (#5201) 2023-05-08 12:14:42 -04:00
github-actions[bot]
d6310f4168
Roll external/googletest/ a3580180d..bc860af08 (1 commit) (#5216)
a3580180d1...bc860af087

$ git log a3580180d..bc860af08 --date=short --no-merges --format='%ad %ae %s'
2023-05-05 absl-team This trips up when compiling with -Wvla otherwise.

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-05-08 10:22:36 -04:00
Steven Perron
8993f9f52f
Apply scalar replacement on vars with Pointer decorations (#5208)
We want to be able to apply scalar replacement on variables that have
the AliasPointer and RestrictPointer decorations.

This exposed a bug that needs to be fixed as well.

Scalar replacement sometimes uses the type manager to get the type id for the
variables it is creating. The variable type is a pointer to a pointee
type. Currently, scalar replacement uses the type manager when only if
the pointee type has to be unique in the module. This is done to try to avoid the case where two type hash to the same
value in the type manager, and it returns the wrong one.

However, this check is not the correct check. Pointer types still have to be
unique in the spir-v module. However, two unique pointer types can hash
to the same value if their pointee types are isomorphic. For example,

%s1 = OpTypeStruct %int
%s2 = OpTypeStruct %int
; %p1 and %p2 will hash to the same value even though they are still
; considered "unique".
%p1 = OpTypePointer Function %s1
%p2 = OpTypePointer Function %s2
To fix this, we now use FindPointerToType, and we modified TypeManager::IsUnique to refer to the whether or not a type will hash to a unique value and say that pointers are not unique.

Fixes #5196
2023-05-08 09:39:14 -04:00
Steven Perron
01055c60cf
Update the contributing guidelines (#5212)
The instructions on merging a PR are out of date. They have be updated
to match the current process.
2023-05-04 11:13:17 -04:00
github-actions[bot]
65f03bea4e
Roll external/spirv-headers/ 7f1d2f415..268a06176 (2 commits) (#5214)
7f1d2f4158...268a061764

$ git log 7f1d2f415..268a06176 --date=short --no-merges --format='%ad %ae %s'
2023-05-03 devillers Reserve a single block of opcodes and enumerants for Saarland University (#343)
2023-04-06 duncan.brawley Shift Codeplay opcode range to preserve alignment of opcodes and non-opcodes

Created with:
  roll-dep external/spirv-headers

Co-authored-by: GitHub Actions[bot] <>
2023-05-04 13:46:10 +02:00
Sruthik P
2189ad7a5a
spirv-tools: Add support for QNX (#5211)
This change updates CMakeLists.txt to support building for QNX
platforms.
2023-05-03 11:25:17 -04:00
github-actions[bot]
17be6bb7c3
Roll external/googletest/ f345b2ca6..a3580180d (2 commits) (#5210)
f345b2ca6a...a3580180d1

$ git log f345b2ca6..a3580180d --date=short --no-merges --format='%ad %ae %s'
2022-11-24 luoyonggang Fixes the test gmock_output_test.py with MSVC
2023-02-09 luoyonggang Revert "Fix gmock_output_test when using MSVC"

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-05-03 10:29:01 -04:00
github-actions[bot]
a525dccbe8
roll deps (#5209)
* Roll external/googletest/ 797b0ad2a..f345b2ca6 (1 commit)

797b0ad2a3...f345b2ca6a

$ git log 797b0ad2a..f345b2ca6 --date=short --no-merges --format='%ad %ae %s'
2023-04-25 julian.amann Fix spelling

Created with:
  roll-dep external/googletest

* Roll external/re2/ 11073deb7..c9cba7606 (1 commit)

11073deb73...c9cba76063

$ git log 11073deb7..c9cba7606 --date=short --no-merges --format='%ad %ae %s'
2023-05-01 junyer Add GCC 13 to the build matrix.

Created with:
  roll-dep external/re2

---------

Co-authored-by: GitHub Actions[bot] <>
2023-05-02 09:19:52 -04:00
Jeremy Gebben
0ce36ad785
instrument: Add set and binding to bindless error records (#5204)
Add set and binding fields to the error records so that it is
easier for users to figure out which descriptor caused an error.
2023-05-01 14:23:30 -04:00
github-actions[bot]
08d8fae589
Roll external/googletest/ 0bdaac5a1..797b0ad2a (1 commit) (#5207)
0bdaac5a14...797b0ad2a3

$ git log 0bdaac5a1..797b0ad2a --date=short --no-merges --format='%ad %ae %s'
2023-04-28 dinor Use GTEST_INTERNAL_CPLUSPLUS_LANG instead of __cplusplus

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-05-01 10:12:36 -04:00
github-actions[bot]
8e1001e938
Roll external/googletest/ dea0484e4..0bdaac5a1 (1 commit) (#5206)
dea0484e4d...0bdaac5a14

$ git log dea0484e4..0bdaac5a1 --date=short --no-merges --format='%ad %ae %s'
2023-04-27 tomhughes Add qualifier to avoid argument dependent lookup

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-04-28 10:30:53 -04:00
ewerness-nv
baa46e1036
Update spirv_headers to include SPV_KHR_ray_tracing_position_fetch (#5205) 2023-04-28 09:40:46 -04:00
github-actions[bot]
6110f30a36
Roll external/googletest/ 783d00fd1..ccdeec888 (1 commit) (#5203)
* Roll external/googletest/ 783d00fd1..dea0484e4 (2 commits)

783d00fd19...dea0484e4d

$ git log 783d00fd1..dea0484e4 --date=short --no-merges --format='%ad %ae %s'
2023-04-26 absl-team Use Abseil Flag public API for flag parsing.
2023-04-25 patryk gmock: fix issue #4222

Created with:
  roll-dep external/googletest

* Roll external/spirv-headers/ cfbe4feef..e08a279cf (2 commits)

cfbe4feef2...e08a279cf9

$ git log cfbe4feef..e08a279cf --date=short --no-merges --format='%ad %ae %s'
2023-04-19 joycebrum chore: Set minimal permissions to presubmit
2023-04-19 dmitry.sidorov Fix TileImage capabilities order

Created with:
  roll-dep external/spirv-headers

---------

Co-authored-by: GitHub Actions[bot] <>
2023-04-27 10:18:33 -04:00
Jeremy Gebben
d4c0abdcad
instrument: Change descriptor state storage format (#5178)
Split per-DescriptorSet state into separate memory blocks
which are accessed via an array of buffer device addresses.
This is being done to make it easier to update state for a
single DescriptorSet without rebuilding the old giant flat
buffer.

The new data format is documented as comments in
include/spirv-tools/instrument.hpp
2023-04-26 14:28:01 -06:00
github-actions[bot]
9e627132a8
Roll external/googletest/ 12a5852e4..783d00fd1 (9 commits) (#5198)
12a5852e45...783d00fd19

$ git log 12a5852e4..783d00fd1 --date=short --no-merges --format='%ad %ae %s'
2023-04-21 tomhughes Use '=default' to define trivial constructor/destructors
2023-04-21 tomhughes Use the empty method to check for emptiness
2023-04-20 tomhughes Add missing std includes
2023-04-20 tomhughes Use std::make_unique
2023-04-20 tomhughes Fix spelling
2023-04-20 tomhughes Add missing std includes
2023-04-20 tomhughes Make parameter names in function declaration match the names in the definitions
2023-04-17 absl-team Update gMock Cookbook to reflect deprecation of testing::ByMove
2023-04-14 jerylvaz Suppress a clang-tidy warning in the MATCHER_P macro

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-04-25 12:59:34 -04:00
Steven Perron
25ad5e19f1
Do not define GOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE if it is already defined. (#5200) 2023-04-18 15:47:10 -04:00
Ben Clayton
bec566a32b
opt: Fix null deref in OpMatrixTimesVector and OpVectorTimesMatrix (#5199)
When some (not all) of the matrix columns are OpConstantNull
2023-04-18 14:58:12 -04:00
alan-baker
d5f69dba55
Remove dead code (#5195)
* Execution model limitation was never executed and the check actually
  belongs with other opcodes
2023-04-14 10:59:01 -04:00
github-actions[bot]
55bc37f826
Roll external/googletest/ 8fa9461cc..12a5852e4 (1 commit) (#5193)
8fa9461cc2...12a5852e45

$ git log 8fa9461cc..12a5852e4 --date=short --no-merges --format='%ad %ae %s'
2022-09-15 paul.groke work around GCC 6~11 ADL bug

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-04-14 10:27:42 -04:00
janharaldfredriksen-arm
6f276e05cc
Add support for SPV_EXT_shader_tile_image (#5188)
* Update DEPS file to pull in header changes for SPV_EXT_shader_tile_image
2023-04-13 16:58:00 -04:00
James Price
1877a7f909
Fix vector OpConstantComposite type validation (#5191)
The constituent types much fully match, not just the opcode.
2023-04-13 12:50:16 -04:00
Corentin Wallez
f449fb4ad9
Add default case for spv::Dim for TileImageEXT (#5194)
Without this the switch statement must be updated at the same time as
the SPIR-V headers, which makes rolls impossible.
2023-04-13 16:10:02 +01:00
Steven Perron
9a4e7a1eb5
Update protobuf to v21.12 (#5189)
* Update protobuf to v21.12

We need to update because the current version was not buliding with gcc 12.2. I
could not move upda to v22.x because there was an odd use of some defines that
were causing failures.

* Disable clang warnings for protobuf headers
2023-04-12 19:37:07 +02:00
github-actions[bot]
31c546e316
Roll external/googletest/ 057b4e904..8fa9461cc (2 commits) (#5192)
057b4e904f...8fa9461cc2

$ git log 057b4e904..8fa9461cc --date=short --no-merges --format='%ad %ae %s'
2023-04-11 absl-team Fix FunctionMocker compilation slowdown in 9d21db9e0a60a1ea61ec19331c9bc0dd33e907b1
2023-04-11 absl-team Support --gtest_stream_result_to on macOS

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-04-12 11:05:49 -04:00
Steven Perron
048faf2e53
Remove use of deprecated std::aligned_storage (#5183)
* Remove use of deprecated std::aligned_storage

Fixes #4806.
2023-04-06 17:22:28 +02:00
github-actions[bot]
13ea01b3ea
Roll external/googletest/ 7ee260c54..057b4e904 (1 commit) (#5190)
7ee260c549...057b4e904f

$ git log 7ee260c54..057b4e904 --date=short --no-merges --format='%ad %ae %s'
2023-04-05 absl-team gtest.cc: run tests within a test suite in a deterministic order.

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-04-06 10:58:00 -04:00
LDeakin
dd03c1fca4
Fix LICMPass (#5087)
Do not move loads out of the loop unless the memory is readonly.

Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/5075
2023-04-05 11:48:14 -04:00
github-actions[bot]
97a55196d2
Roll external/googletest/ b5fd99bbd..7ee260c54 (1 commit) (#5187)
b5fd99bbd5...7ee260c549

$ git log b5fd99bbd..7ee260c54 --date=short --no-merges --format='%ad %ae %s'
2023-04-03 absl-team Rolled back due to breaking existing tests.

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-04-04 11:48:30 -04:00
github-actions[bot]
ac335c7634
roll deps (#5185)
* Roll external/googletest/ ca0d46e95..b5fd99bbd (2 commits)

ca0d46e95d...b5fd99bbd5

$ git log ca0d46e95..b5fd99bbd --date=short --no-merges --format='%ad %ae %s'
2023-03-30 jacobsa gtest.cc: run tests within a test suite in a deterministic order.
2023-03-29 absl-team Update naming to "GoogleTest" in the GoogleTest Primer.

Created with:
  roll-dep external/googletest

* Roll external/spirv-headers/ 90547c54e..29ba24931 (1 commit)

90547c54e2...29ba249312

$ git log 90547c54e..29ba24931 --date=short --no-merges --format='%ad %ae %s'
2023-03-23 duncan.brawley Reserve SPIR-V blocks for Codeplay

Created with:
  roll-dep external/spirv-headers

---------

Co-authored-by: GitHub Actions[bot] <>
2023-04-03 12:20:17 -04:00
Nathan Gauër
a2db3fb17b
kokoro: always chown files (#5186)
If the build fails, the artifacts must still be chowned
so the CI can pick them up. If they are not, the CI tooling
will fail and go into 'aborted' state, which blocks the logs.

Signed-off-by: Nathan Gauër <brioche@google.com>
2023-04-03 15:27:45 +02:00
Steven Perron
6b72fe20c5
Add missing header guard (#5181)
Fixes #5018
2023-03-29 15:52:47 -04:00
Steven Perron
7ab0a2781a
Remove non-ascii char from comments. (#5182)
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/4851
2023-03-29 15:48:15 -04:00