Spencer Fricke
20ad38c18d
spirv-val: Multiple interface var with same SC ( #5528 )
2024-02-13 15:55:43 -05:00
Steven Perron
e08c012b19
[OPT] Identify arrays with unknown length in copy prop arrays ( #5570 )
...
* [OPT] Identify arrays with unknown length in copy prop arrays
The code in copy propagate arrays assumes that the length of an
OpTypeArray is known at compile time, but that is not true when the size
is an OpSpecConstant. We try to fix that assumption.
Fixes https://crbug.com/oss-fuzz/66634
2024-02-13 14:41:38 -05:00
github-actions[bot]
56a51dd947
Roll external/spirv-headers/ e77d03080..d3c2a6fa9 (1 commit) ( #5574 )
...
e77d03080b...d3c2a6fa95#413 )
Created with:
roll-dep external/spirv-headers
Co-authored-by: GitHub Actions[bot] <>
Co-authored-by: Cassandra Beckley <cbeckley@google.com>
2024-02-13 14:19:09 -05:00
Ben Ashbaugh
0c986f596d
update image enum tests to remove Kernel capability ( #5562 )
...
We are removing Kernel from the image channel order and image
channel data type enums because Kernel is already required
transitively, so we need to update the tests to match.
2024-02-13 11:07:39 -05:00
Steven Perron
b7413609cf
[OPT] Use new instruction folder for for all opcodes in spec consti folding ( #5569 )
...
* [OPT] Use new instruction folder for for all opcodes in spec consti folding
When folding and OpSpecConstantOp, we use the new instruction folder for
a small number of opcodes. This enable the new instruction folder for
all opcodes and uses the old one as a fall back. This allows us to
remove some code from the older folder that is now covered by the new
one.
Fixes #5499
2024-02-12 19:52:55 +00:00
Spencer Fricke
784b064f90
spirv-val: Validate PhysicalStorageBuffer Stage Interface ( #5539 )
...
Disallow PhysicalStorageBuffer pointers in Input and Output storage classes.
2024-02-12 09:51:38 -05:00
Steven Perron
a8959dc653
Fold 64-bit int operations ( #5561 )
...
Adds folding rules that will fold basic artimetic for signed and
unsigned integers of all sizes, including 64-bit.
Also folds OpSConvert and OpUConvert.
2024-02-09 14:02:48 -05:00
github-actions[bot]
80926d97ab
roll deps ( #5566 )
...
* Roll external/googletest/ 64be1c79f..b75ecf1be (2 commits)
64be1c79fa...b75ecf1bed1c9115b562...e77d03080b#414 )
Created with:
roll-dep external/spirv-headers
---------
Co-authored-by: GitHub Actions[bot] <>
2024-02-08 19:47:36 +00:00
dependabot[bot]
9a7b1af906
build(deps): bump the github-actions group with 1 update ( #5564 )
...
Bumps the github-actions group with 1 update: [lukka/get-cmake](https://github.com/lukka/get-cmake ).
Updates `lukka/get-cmake` from 3.28.2 to 3.28.3
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](23a189c2ed...139aae9631
2024-02-07 14:15:04 -05:00
github-actions[bot]
1a2cbabd8b
Roll external/googletest/ 48729681a..64be1c79f (1 commit) ( #5563 )
...
48729681ad...64be1c79fa
2024-02-07 18:27:25 +00:00
dependabot[bot]
7657cb1c69
build(deps): bump the github-actions group with 3 updates ( #5560 )
...
Bumps the github-actions group with 3 updates: [lukka/get-cmake](https://github.com/lukka/get-cmake ), [actions/upload-artifact](https://github.com/actions/upload-artifact ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `lukka/get-cmake` from 3.28.1 to 3.28.2
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](2654d8ee38...23a189c2edhttps://github.com/actions/upload-artifact/releases )
- [Commits](26f96dfa69...5d5d22a312https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b7bf0a3ed3...e8893c57a1
2024-02-06 11:09:41 -08:00
Steven Perron
032c15aaf5
[NFC] Refactor code to fold instruction in fold tests. ( #5558 )
...
We repeat basically the same code multiple times in the different types of
folding tests. This commit adds a function that builds the module, finds the
instruction to fold, and folds it. Doing the routine checks at the same
time. We also have a couple generic functions for checking that an
instruction is a constant with the expected value.
2024-02-06 13:05:05 -05:00
github-actions[bot]
9938f5bc2e
Roll external/googletest/ 456574145..48729681a (1 commit) ( #5559 )
...
456574145c...48729681ad
2024-02-06 18:00:14 +00:00
Nathan Gauër
ab59dc6087
opt: prevent meld to merge block with MaximalReconvergence ( #5557 )
...
The extension SPV_KHR_maximal_reconvergence adds more constraints
around the merge blocks, and how the control flow can be altered.
The one we address here is explained in the following part of the spec:
Note: This means that the instructions in a break block will execute as if
they were still diverged according to the loop iteration. This restricts
potential transformations an implementation may perform on the IR to match
shader author expectations. Similarly, instructions in the loop construct
cannot be moved into the continue construct unless it can be proven that
invocations are always converged.
Until the optimizer is clever enough to determine if the invocation
have already converged, we shall not meld a block which branches to a
merge block into it, as it might move some instructions outside of the
convergence region.
This behavior being only required with the extension, this commit
behavior change is gated by the extension.
This means using wave operations without the maximal reconvergence
extension might lead to undefined behaviors.
Co-authored-by: Natalie Chouinard <chouinard.nm@gmail.com>
2024-02-06 06:12:00 -05:00
github-actions[bot]
6c11c2bd46
Roll external/re2/ 283636ffb..ab7c5918b (2 commits) ( #5555 )
...
283636ffb2...ab7c5918b4
2024-02-03 06:21:01 +00:00
github-actions[bot]
a8afbe941a
roll deps ( #5550 )
...
* Roll external/googletest/ 6a5938233..456574145 (5 commits)
6a5938233b...456574145c826ad10e58...283636ffb2
2024-02-02 21:19:05 +00:00
Ben Doherty
8d3ee2e8f0
spirv-opt: Fix OpCompositeExtract relaxation with struct operands ( #5536 )
2024-02-01 15:19:02 -07:00
Spencer Fricke
61c51d4baf
spirv-val: Add Mesh Primitive Built-In validaiton ( #5529 )
2024-02-01 14:20:42 -05:00
Natalie Chouinard
5d3c8b73f7
opt: Add OpEntryPoint to DescriptorScalarReplacement pass ( #5553 )
...
Add OpEntryPoint to the list of instructions processed by the
DescriptorScalarReplacement pass. This is necessary for SPIR-V 1.4 and
above where global variables must be included in the interface.
Fixes microsoft/DirectXShaderCompiler#5962
2024-02-01 09:50:36 -05:00
Natalie Chouinard
de65e81740
[NFC] Remove unused code ( #5554 )
2024-02-01 09:47:42 -05:00
Nathan Gauër
ad11927e6c
opt: add SPV_EXT_mesh_shader to opt allowlist ( #5551 )
...
Add this extension to the allowlist, allowing DCE and other
optimizations on modules exposing this.
Note: NV equivalent is already allowed.
2024-01-30 12:13:46 -05:00
dependabot[bot]
27ffe976e0
build(deps): bump the github-actions group with 2 updates ( #5549 )
...
Bumps the github-actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/upload-artifact` from 4.2.0 to 4.3.0
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](694cdabd8b...26f96dfa69https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](0b21cf2492...b7bf0a3ed3
2024-01-30 10:29:19 -05:00
github-actions[bot]
e5fcb7facf
Roll external/re2/ 264e71e88..826ad10e5 (1 commit) ( #5538 )
...
* Roll external/googletest/ 96cd50c08..6a5938233 (4 commits)
96cd50c082...6a5938233bhttps://bazel.build/external/overview#bzlmod
2024-01-23 absl-team Fix double-promotion warnings in AppropriateResolution()
2024-01-22 dinor googletest: Fix incorrect comment about `value_param` of `internal::MakeAndRegisterTestInfo`
2024-01-10 michael.128.leslie only apply -lregex for qnx710 and newer
Created with:
roll-dep external/googletest
* Roll external/re2/ 264e71e88..826ad10e5 (1 commit)
264e71e88e...826ad10e585aa1dd8a11...1c9115b562#410 )
Created with:
roll-dep external/spirv-headers
---------
Co-authored-by: GitHub Actions[bot] <>
2024-01-29 16:01:06 +00:00
Scott Todd
80bc99c3d4
Skip entire test/ folder if SPIRV_SKIP_TESTS is set. ( #5548 )
...
Without this (or similar filtering), the `spirv-tools_expect_unittests` and `spirv-tools_spirv_test_framework_unittests` Python tests at `test/tools/` get defined even when `SPIRV_SKIP_TESTS` is set.
2024-01-26 16:47:13 -05:00
Natalie Chouinard
0a6f0d1893
opt: Add TrimCapabilities pass to spirv-opt tool ( #5545 )
...
Add an option to the spirv-opt tool to run the TrimCapabilitiesPass.
2024-01-26 16:15:29 -05:00
ruiminzhao
b951948eaa
SPV_KHR_quad_control ( #5547 )
...
* SPV_KHR_quad_control
1. Add two new execute modes: RequireFullQuadsKHR and QuadDerivativesKHR
2. Add two opCodes: OpGroupNonUniformQuadAllKHR and
OpGroupNonUniformQuadAnyKHR
3. Add one Capability: QuadControlKHR
* update DEPS
* Fixes
* Build fixes
* Formatting fixes
* Test fixes
* formatting
---------
Co-authored-by: Alan Baker <alanbaker@google.com>
2024-01-26 15:49:56 -05:00
alan-baker
69197ba90b
Add modify-maximal-reconvergence to spirv-opt help ( #5546 )
2024-01-25 15:53:11 -05:00
Natalie Chouinard
0045b01ff9
opt: Add VulkanMemoryModelDeviceScope to trim ( #5544 )
...
Add the VulkanMemoryModelDeviceScope capability to the capability
trimming pass. According the the spec, "If the Vulkan memory model is
declared and any instruction uses Device scope, the
VulkanMemoryModelDeviceScope capability must be declared." Since this
case, based on the type of an operand, is not covered by the JSON
grammar, it is added explicitly.
2024-01-25 14:05:04 -05:00
alan-baker
ef2f432364
Add support for SPV_KHR_float_controls2 ( #5543 )
...
* Test asm/dis for SPV_KHR_float_controls2
* SPV_KHR_float_controls2 validation
---------
Co-authored-by: David Neto <dneto@google.com>
2024-01-25 10:22:09 -05:00
alan-baker
de3d5acc04
Add tooling support for SPV_KHR_maximal_reconvergence ( #5542 )
...
* Validation for SPV_KHR_maximal_reconvergence
* Add pass to add/remove maximal reconvergence execution mode
---------
Co-authored-by: David Neto <dneto@google.com>
2024-01-25 09:39:49 -05:00
David Neto
14000ad47a
Use python3 explicitly. ( #5540 )
...
Some Linux images don't ship with a plain 'python'
2024-01-23 15:42:34 -05:00
Nathan Gauër
3590129278
workflow: add vulkan-sdk tags as release tags ( #5518 )
...
This workflow creates a new release on the github page. When LunarG
is done with the release, tags are added to the repo.
When this happens, we should publish a release.
Signed-off-by: Nathan Gauër <brioche@google.com>
2024-01-22 16:06:09 -05:00
dependabot[bot]
3e6bdd0f99
build(deps): bump the github-actions group with 3 updates ( #5537 )
...
Bumps the github-actions group with 3 updates: [actions/cache](https://github.com/actions/cache ), [actions/upload-artifact](https://github.com/actions/upload-artifact ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/cache` from 3.3.3 to 4.0.0
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](e12d46a63a...13aacd865chttps://github.com/actions/upload-artifact/releases )
- [Commits](1eb3cb2b3e...694cdabd8bhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e5f05b81d5...0b21cf2492
2024-01-19 10:27:11 -05:00
github-actions[bot]
ed6835aff7
Roll external/re2/ c042630ed..32c181e0a (1 commit) ( #5532 )
...
* Roll external/googletest/ 7c07a8636..96cd50c08 (3 commits)
7c07a86369...96cd50c082c042630ed8...264e71e88ebdd1b2ab1f...7b0309708d#405 )
2024-01-17 robin Add a Source Language for Zig (#403 )
Created with:
roll-dep external/spirv-headers
---------
Co-authored-by: GitHub Actions[bot] <>
2024-01-19 10:05:04 -05:00
Spencer Fricke
c96fe8b943
spirv-val: Re-enable OpControlBarrier VU ( #5527 )
2024-01-17 11:18:23 -05:00
dependabot[bot]
5dbdc7b60b
build(deps): bump the github-actions group with 4 updates ( #5531 )
...
Bumps the github-actions group with 4 updates: [actions/cache](https://github.com/actions/cache ), [lukka/get-cmake](https://github.com/lukka/get-cmake ), [actions/upload-artifact](https://github.com/actions/upload-artifact ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/cache` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](704facf57e...e12d46a63ahttps://github.com/lukka/get-cmake/releases )
- [Commits](4865386b66...2654d8ee38https://github.com/actions/upload-artifact/releases )
- [Commits](a8a3f3ad30...1eb3cb2b3ehttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](407ffafae6...e5f05b81d5
2024-01-15 10:57:32 -05:00
Steven Perron
155728b2e9
Add preserver-interface option to spirv-opt ( #5524 )
...
The optimizer is able to preserve the interface variables of the
shaders, but that feature has not been exposed to the command line
tool.
This commit adds an option `--preserve-interface` to spirv-opt that will
cause all calls to ADCE to leave the input and output variables, even if
the variable is unused. It will apply regardless of where the option
appears on the command line.
Fixes #5522
2024-01-12 14:45:17 -05:00
github-actions[bot]
01ee1bf317
Roll external/googletest/ b10fad38c..76bb2afb8 (1 commit) ( #5485 )
...
* Roll external/googletest/ b10fad38c..7c07a8636 (12 commits)
b10fad38c4...7c07a863697e0c1a9e24...c042630ed81c6bb27435...bdd1b2ab1f#401 )
2024-01-10 49699333+dependabot[bot] Bump the github-actions group with 1 update (#400 )
2024-01-10 89833130+rjodinchr Publish the header for the vulkan-shader-profiler embedded reflection… (#398 )
2024-01-03 dmitry.sidorov Upstream tokens for SPV_INTEL_masked_gather_scatter (#391 )
2024-01-03 joycebrum feat: Create dependabot.yml (#397 )
Created with:
roll-dep external/spirv-headers
---------
Co-authored-by: GitHub Actions[bot] <>
2024-01-11 16:59:38 +00:00
Steven Perron
36be541ee3
Remove unnecessary debug code ( #5523 )
2024-01-11 07:55:04 -08:00
Nathan Gauër
c7affa1707
opt: add Int16 and Float16 to capability trim pass ( #5519 )
...
Add support for Int16 and Float16 trim.
Signed-off-by: Nathan Gauër <brioche@google.com>
2024-01-04 20:01:03 +01:00
Steven Perron
0a9f3d1f2a
Revert "Fix(cmake): CMake doesn't find system installed SPIRV-Headers ( #5422 )" ( #5517 )
...
This reverts commit 7d2429594d
2024-01-03 09:55:24 -05:00
technateNG
7d2429594d
Fix(cmake): CMake doesn't find system installed SPIRV-Headers ( #5422 )
...
To build repository version from sources current cmake require
to explicitly clone SPIRV-Headers repository to directory named
'external' with fixed name 'spirv-headers'.
This is a behavior which doesn't support searching global headers and
also CMAKE_PREFIX_PATH which makes development in some environments
less convenient than it should be.
The commit fixes this issue with keeping previous clone option intact.
2024-01-02 10:07:47 -05:00
Nathan Gauër
f0cc85efdb
Prepare release v2023.6 ( #5510 )
...
Signed-off-by: Nathan Gauër <brioche@google.com>
2023-12-20 13:22:56 +01:00
alan-baker
e03c8f5c8e
Fix broken build ( #5505 )
...
Fixes #5503
* SPIRV-Headers name change broke the build
* Update SPIRV-Headers deps and fix
2023-12-11 11:45:10 -05:00
Ben Clayton
d75b3cfbb7
Zero initialize local variables ( #5501 )
...
Certain versions of GCC warn about these variables being potentially uninitialized when used.
I believe this is a false-positive, but zero-init'ing them is a safe way to fix this.
2023-12-11 10:32:45 -05:00
Jeremy Gebben
6b4f0c9d0b
instrument: Fix handling of gl_InvocationID ( #5493 )
...
This is an int and needs to be cast to a unit for inclusion in the
stage specific data passed to the instrumentation check function.
2023-12-05 09:59:51 -07:00
Jeremy Gebben
b5d60826e9
printf: Remove stage specific info ( #5495 )
...
Remove stage specific debug info that is only needed by GPU-AV.
This allows debug printfs to be used in multi-stage shader modules.
Fixes #4892
2023-12-04 15:43:36 -07:00
dependabot[bot]
e7a52b70fe
build(deps): bump the github-actions group with 1 update ( #5498 )
...
Bumps the github-actions group with 1 update: [lukka/get-cmake](https://github.com/lukka/get-cmake ).
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](8be6cca406...4865386b66
2023-12-04 10:18:57 -05:00
ncesario-lunarg
2da75e152e
Do not crash when tryingto fold unsupported spec constant ( #5496 )
...
Remove assertion in FoldWithInstructionFolder; there are cases where
folding spec constants is unsupported.
Closes #5492 .
2023-12-04 08:48:16 -05:00
David Neto
0d87845532
Remove uses of std::system(nullptr) ( #5494 )
...
Android's bionic library blows up on this, contrary to the standard.
If std::system can't find a shell, you already have bigger problems.
Don't check specially for that condition. (That's the justification
Android uses, and I'm not going to fight it.)
2023-11-30 17:05:25 -05:00
