Commit Graph

3619 Commits

Author SHA1 Message Date
alan-baker
9fbe1738ba
Update SPIRV-Headers deps (#5170)
* Update test expectations to account for simplified enables
* Don't clone spirv-headers twice for the smoketest
2023-03-23 13:00:42 -04:00
Nathan Gauër
5f4e694e10
Implement source extraction logic for spirv-objdump (#5150)
* dump: add ability to extract HLSL from module

Only adds the code to extract the source from the module. The extracted files are written to the given directory.
Android NDK21 has C++17 support, but no std::filesystem support. (NDK22). As for now, the tool is not built on Android.
Might be something to revisit is the need to have this tool on Android arises.
2023-03-22 23:57:18 +01:00
davidroygsu
5aab2a8fef
Include stdint.h (#5164) 2023-03-22 10:44:55 -04:00
github-actions[bot]
1a52c14ee3
Roll external/googletest/ fa8720982..974e18ee6 (2 commits) (#5168)
fa87209829...974e18ee6f

$ git log fa8720982..974e18ee6 --date=short --no-merges --format='%ad %ae %s'
2023-03-21 absl-team Fix minor bug -- if ExecDeathTestChildMain() ever returns, we should exit with a non-zero status.
2023-03-21 absl-team Internal Code Change

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-03-22 09:23:27 -04:00
github-actions[bot]
90f6a2875f
Roll external/googletest/ 471087fbf..fa8720982 (2 commits) (#5167)
471087fbfc...fa87209829

$ git log 471087fbf..fa8720982 --date=short --no-merges --format='%ad %ae %s'
2023-03-20 phoebeliang Revise documentation to include AbslStringify
2023-02-17 darryl Set CMP0069 policy to avoid warnings

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-03-21 10:34:03 -04:00
Nathan Gauër
4dc3edeb94
build: set std=c++17 for BUILD.gn (#5162) 2023-03-20 12:05:41 -06:00
github-actions[bot]
f56f2b6fd2
roll deps (#5166)
* Roll external/googletest/ 391ce627d..471087fbf (6 commits)

391ce627de...471087fbfc

$ git log 391ce627d..471087fbf --date=short --no-merges --format='%ad %ae %s'
2023-03-20 absl-team Introduce std::make_unique and bool literals where possible
2023-03-20 absl-team Remove unused using-declarations in sample unit tests
2023-03-19 absl-team Fix typo in test case name.
2023-03-16 deannagarcia Move transitive dependencies of googletest to googletest_deps.bzl to allow other bazel projects to depend on that rule instead of googletests' transitive dependencies directly.
2023-03-02 sergionso Environment variables are accessible in UWP/WinRT apps
2023-03-06 nikiforov.al __cpp_char8_t does not cover std::u8string implementation, but __cpp_lib_char8_t does

Created with:
  roll-dep external/googletest

* Roll external/re2/ b059ae85c..11073deb7 (1 commit)

b059ae85c8...11073deb73

$ git log b059ae85c..11073deb7 --date=short --no-merges --format='%ad %ae %s'
2023-03-20 junyer Add Clang 16 to the build matrix.

Created with:
  roll-dep external/re2

---------

Co-authored-by: GitHub Actions[bot] <>
2023-03-20 09:57:12 -04:00
Nathan Gauër
9c9144b65c
ci: fix dependency updater bot (#5165)
Thought `content` permission was enough to create (not merge) PRs,
but turns out the `pull-request` permission is also required.
This should unblock the bot.

Signed-off-by: Nathan Gauër <brioche@google.com>
2023-03-20 14:06:58 +01:00
Nathan Gauër
ae435df4a6
git: add release workflow (#5158) 2023-03-20 10:13:19 +01:00
Kévin Petit
44bc9bd2af
build: cmake: support passing a custom source folder for GoogleTest (#5157) 2023-03-18 01:05:12 +00:00
Spencer Fricke
8e6563b913
spirv-val: Label new Vulkan VUID 07951 (#5154) 2023-03-18 01:01:50 +00:00
Alan Zhao
9743701ed5
Explicitly #include <utility> in spirv_target_env.cpp (#5159)
spirv_target_env.cpp uses std::pair, which is defined in utility.
Right now, this compiles because utility is provided via transitive
includes in other C++ standard library headers provided by the
implementation. However, these transitive includes are not guaranteed to
exist, and won't exist in certain cases (e.g. compiling against LLVM's
libc++ with modules enabled.)
2023-03-15 13:15:29 +01:00
Nathan Gauër
25f6c0cea5
Revert "Add workflow for github releases. (#5145)" (#5156)
This reverts commit 25b7608cbe.
2023-03-13 18:04:19 +00:00
github-actions[bot]
a45a4cd218
Roll external/googletest/ 038e392eb..391ce627d (1 commit) (#5153)
038e392ebd...391ce627de

$ git log 038e392eb..391ce627d --date=short --no-merges --format='%ad %ae %s'
2023-03-11 absl-team Internal Code Change

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-03-13 18:04:00 +00:00
dependabot[bot]
a1f5556517
build(deps): bump y18n from 4.0.0 to 4.0.3 in /tools/sva (#5155)
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.3.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/y18n-v4.0.3/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/compare/v4.0.0...y18n-v4.0.3)

---
updated-dependencies:
- dependency-name: y18n
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-13 16:08:19 +00:00
Nathan Gauër
25b7608cbe
Add workflow for github releases. (#5145)
* prepare workflow

* remove release branch
2023-03-13 16:55:55 +01:00
Nathan Gauër
fcd53c8ed2
Add spirv-dump tool (#5146)
* dump: add tool skeleton.

This tool aims to be used a bit like objdump (hence the name).
Allowing the user to dump some info from a spirv-binary.

* add test structure for spirv-dump

* add spirv-dump to bazel build file

* fix licenses

* fix compilation with ubsan

* remove fdiagnostics

* rename dump to objdump

* move tests to test/tools

* rename dump to objdump for bazel
2023-03-13 16:39:42 +01:00
Nathan Gauër
7cefd5f5f8
Change default permissions for workflows (#5149)
* change default workflow permission to read-all

Fixes #5147

* permission: content read-only

* remove bad changes
2023-03-13 16:18:01 +01:00
Nathan Gauër
44d72a9b36
Prepare release v2023.2 (#5151) 2023-03-13 11:33:58 +01:00
github-actions[bot]
fba26fd606
roll deps (#5152)
* Roll external/googletest/ 50e07d1c9..038e392eb (1 commit)

50e07d1c92...038e392ebd

$ git log 50e07d1c9..038e392eb --date=short --no-merges --format='%ad %ae %s'
2023-03-10 lawrencews [gtest] Drop custom-rolled heterogeneous comparator functors in favor of C++ standard ones

Created with:
  roll-dep external/googletest

* Roll external/re2/ f0402c039..b059ae85c (1 commit)

f0402c0397...b059ae85c8

$ git log f0402c039..b059ae85c --date=short --no-merges --format='%ad %ae %s'
2023-03-10 junyer Move inst_ out of the blob of memory for a State.

Created with:
  roll-dep external/re2

---------

Co-authored-by: GitHub Actions[bot] <>
2023-03-11 12:15:52 +00:00
github-actions[bot]
01828dac77
Roll external/googletest/ 48a1b1105..50e07d1c9 (1 commit) (#5148)
48a1b11058...50e07d1c92

$ git log 48a1b1105..50e07d1c9 --date=short --no-merges --format='%ad %ae %s'
2023-03-09 absl-team Apply clang-tidy fixes

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-03-10 11:43:34 +01:00
Nathan Gauër
b029037aaa
Revert changes around CHANGES file. (#5143)
* Revert "build: allow update_build to generate fake version (#5098)"

This reverts commit 7823b8ff4a.

* Revert "build: stop parsing CHANGES file. (#5067)"

This reverts commit fcfc3c580c.
2023-03-09 18:24:20 +01:00
github-actions[bot]
c069a5c7ee
roll deps (#5144)
* Roll external/googletest/ a798c2f10..48a1b1105 (2 commits)

a798c2f102...48a1b11058

$ git log a798c2f10..48a1b1105 --date=short --no-merges --format='%ad %ae %s'
2023-03-08 absl-team Add a comment to clarify Fuchsia process launcher requirement.
2023-03-07 absl-team Apply clang-tidy fixes

Created with:
  roll-dep external/googletest

* Roll external/spirv-headers/ 295cf5fb3..1feaf4414 (9 commits)

295cf5fb3b...1feaf4414e

$ git log 295cf5fb3..1feaf4414 --date=short --no-merges --format='%ad %ae %s'
2023-03-08 arvind.sudarsanam Fix error in merge conflict resolution
2023-03-06 ben.ashbaugh headers support for SPV_INTEL_bfloat16_conversion
2023-03-03 arvind.sudarsanam Add parameters
2023-03-03 arvind.sudarsanam Remove redundant extensions entry
2023-03-02 arvind.sudarsanam Add support for SPV_INTEL_fpga_latency_control extension
2023-03-01 wooykim SPV_QCOM_image_processing
2023-03-01 wooykim SPV_QCOM_image_processing
2023-02-14 wooykim SPV_QCOM_image_processing
2023-02-14 wooykim SPV_QCOM_image_processing

Created with:
  roll-dep external/spirv-headers

---------

Co-authored-by: GitHub Actions[bot] <>
2023-03-09 11:06:41 +01:00
Nathan Gauër
42267721e1
build: tool to generate a CHANGELOG from tags (#5136)
This small utility parses the CHANGES file to generate
a CHANGELOG that can be used for GitHub releases.

This will be used by the GitHub workflow to make releases
automatic.

Given a CHANGES file path, a tag, the script extract the
editorialized changelog, and writes it to a given output file.
2023-03-08 16:12:41 +01:00
github-actions[bot]
db0c3d83dc
Roll external/googletest/ e1ee0fa3e..a798c2f10 (4 commits) (#5142)
e1ee0fa3e1...a798c2f102

$ git log e1ee0fa3e..a798c2f10 --date=short --no-merges --format='%ad %ae %s'
2023-03-07 tomhughes Add -Wundef to the CI scripts when building with Bazel
2023-03-07 tomhughes Fix compilation of googletest-printers-test.cc when using -Wundef
2023-03-07 absl-team Suppress std::string DLL interface warning introduced in commit f063cd25c90cbd4089a0ff96f5991df4f2721338
2023-03-07 absl-team Internal Code Change

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-03-08 12:11:38 +00:00
James Price
690a9a4060
Add explicit deduction guide for FlagRegistration (#5141)
This fixes a -Wctad-maybe-unsupported error.
2023-03-07 16:44:56 -05:00
github-actions[bot]
3033cf428e
Roll external/googletest/ cead3d57c..e1ee0fa3e (9 commits) (#5140)
cead3d57c9...e1ee0fa3e1

$ git log cead3d57c..e1ee0fa3e --date=short --no-merges --format='%ad %ae %s'
2023-03-06 dinor Fix indentation syntax error in feature request issue template
2023-03-03 tomhughes Fix compilation with -Wundef.
2023-03-03 tomhughes Always specify definitions for internal macros
2023-03-03 tomhughes Remove GTEST_FOR_GOOGLE_ macro
2023-03-03 tomhughes Replace "#if GTEST_HAS_ABSL" with "#ifdef GTEST_HAS_ABSL"
2023-03-03 tomhughes Use "#ifdef" with public macros
2023-03-03 tomhughes Only define GTEST_IS_THREADSAFE to 1, not 0
2023-03-03 tomhughes Always specify definitions for internal macros
2023-03-03 tomhughes Use "#ifdef GTEST_OS_..." instead of "#if GTEST_OS_..."

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-03-07 14:35:53 +00:00
github-actions[bot]
016bb3ae7f
roll deps (#5139)
* Roll external/googletest/ 2d4f20876..cead3d57c (1 commit)

2d4f208765...cead3d57c9

$ git log 2d4f20876..cead3d57c --date=short --no-merges --format='%ad %ae %s'
2023-03-03 absl-team Internal Code Change

Created with:
  roll-dep external/googletest

* Roll external/re2/ 3a8436ac4..f0402c039 (1 commit)

3a8436ac43...f0402c0397

$ git log 3a8436ac4..f0402c039 --date=short --no-merges --format='%ad %ae %s'
2023-03-03 junyer Update a comment in `DFA::WorkqToCachedState()`.

Created with:
  roll-dep external/re2

---------

Co-authored-by: GitHub Actions[bot] <>
2023-03-04 17:40:04 +00:00
Nathan Gauër
7cb5898e1d
diff: refactorize flag parsing (#5133)
* diff: refactorize flag parsing

Remove custom flag parsing to use the common one.

* remove superfluous ;
2023-03-03 16:55:00 +01:00
Ralf Habacker
e0df12997f
Fix using invalid install path for cmake support files with MINGW platform (#5128) (#5129) 2023-03-03 15:53:23 +00:00
Ralf Habacker
3eff21366e
Fix MinGW build error (#4935) (#5127)
This commit fixes the following build error when the source code is build
with MinGW gcc 12 and compiler switch '-Werror=maybe-uninitialized' is
added:

    'file.{anonymous}::OutputFile::old_mode_' may be used uninitialized
     in this function [-Werror=maybe-uninitialized]
2023-03-03 15:53:08 +00:00
Laura Hermanns
bd83b772c3
Fix operand index out of bounds when folding OpCompositeExtract. (#5107)
GetExtractOperandsForElementOfCompositeConstruct() states "Returns the
empty vector if |result_index| is out-of-bounds", but violates that
contract for non-vector result types.
2023-03-03 15:52:49 +00:00
David Neto
5fe3bbe77d
Update Effcee so it doesn't hardcode C++11 (#5137) 2023-03-03 14:30:13 +00:00
github-actions[bot]
6c714f191e
Roll external/googletest/ c7d0bc830..2d4f20876 (3 commits) (#5130)
* Roll external/googletest/ c7d0bc830..2d4f20876 (3 commits)

c7d0bc8309...2d4f208765

$ git log c7d0bc830..2d4f20876 --date=short --no-merges --format='%ad %ae %s'
2023-02-28 absl-team   Rephrase the description of TEST_F() arguments for clarity.
2023-02-27 absl-team Eliminate argv list action parameter.
2023-02-19 39726720+VuPhamVan Fix typo

Created with:
  roll-dep external/googletest

* Roll external/spirv-headers/ aa331ab0f..295cf5fb3 (6 commits)

aa331ab0ff...295cf5fb3b

$ git log aa331ab0f..295cf5fb3 --date=short --no-merges --format='%ad %ae %s'
2023-03-01 abhishek2.tiwari update parameter name to match spec in grammar file
2023-02-23 abhishek2.tiwari move FPGAKernelAttributesv2INTEL to capability section in all files
2023-02-08 abhishek2.tiwari correct file entry position for FPGAKernelAttributesv2INTEL
2023-02-07 abhishek2.tiwari add FPGAKernelAttributesv2INTEL to all files
2023-01-27 abhishek2.tiwari address review comment
2023-01-26 abhishek2.tiwari add RegisterMapInterfaceINTEL

Created with:
  roll-dep external/spirv-headers

---------

Co-authored-by: GitHub Actions[bot] <>
2023-03-02 19:53:51 +00:00
Nathan Gauër
d6c707676d
linter: refactorize linter flag parsing (#5134)
Change custom flag parsing to the built-in one.
2023-03-02 15:17:34 +01:00
Nathan Gauër
8cee461986
tools: add uint32_t flags parsing (#5131)
* tools: add uint32_t flags parsing

This will be required to refactorize other tools.
2023-03-02 15:16:32 +01:00
Nathan Gauër
970ba4e8b0
linker: refactorize flag parsing (#5132)
replace the old parser with the common utility.
2023-03-01 18:50:42 +01:00
github-actions[bot]
9d71fb6764
Roll external/googletest/ 3d787f5a0..c7d0bc830 (4 commits) (#5126)
3d787f5a0d...c7d0bc8309

$ git log 3d787f5a0..c7d0bc830 --date=short --no-merges --format='%ad %ae %s'
2023-02-27 phoebeliang Reorder printers list.
2023-02-27 absl-team   Reformat to current g3doc style guide. No content changes.
2023-02-21 sergionso Fix error in_death_test_child_process: undeclared identifier
2023-02-02 benayang Update testing.md

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-02-28 11:59:21 +00:00
Nathan Gauër
9d4c95a574
build: fix build.gn missing comma (#5125)
Broke build using this file.
2023-02-27 20:45:43 +01:00
Nathan Gauër
2e0f4b52c9
tools: refactorize tools flags parsing. (#5111)
* tools: refactorize tools flags parsing.

Each SPIR-V tool was handing their own flag parsing. This PR
adds a new flag parsing utility that should be flexible enough
for our usage, but generic enough so it can be shared across tools while
remaining simple to use.

* cfg: replace cfg option parsing with the new one.

* change spirv-dis parsing + title + summary

* clang format

* flags: fix static init fiasco & remove help

Static initialization order is important, and was
working just by sheer luck.

Also removing the help generation tooling. It's less flexible than the
hand-written string, and making it as-good and as-flexible brings too
much complexity.

* review feedback
2023-02-27 18:45:14 +01:00
github-actions[bot]
3b2ea1a422
Roll external/googletest/ 39a26e12d..3d787f5a0 (2 commits) (#5123)
39a26e12d6...3d787f5a0d

$ git log 39a26e12d..3d787f5a0 --date=short --no-merges --format='%ad %ae %s'
2023-02-24 absl-team Add `const` qualifier to `gtest_sentinel` which doesn't change.
2023-02-23 absl-team Added a missing semicolon for GTEST_FLAG_SET code snippet.

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-02-25 18:54:35 +00:00
alan-baker
b955c468b1
Add missing header include (#5124)
* Found during an internal build
2023-02-24 13:21:53 -05:00
alan-baker
5d2bc6f064
Fix removal of dependent non-semantic instructions (#5122)
Fixes #5121

* If the non-semantic info instructions depended on other moved
  instructions the def/use manager would get corrupted.
2023-02-24 01:10:35 +00:00
github-actions[bot]
4183faa2ec
Roll external/googletest/ 750d67d80..39a26e12d (2 commits) (#5120)
750d67d809...39a26e12d6

$ git log 750d67d80..39a26e12d --date=short --no-merges --format='%ad %ae %s'
2023-02-22 dinor Avoid redundant declaration of static constexpr members in c++17
2023-02-22 dinor Update googletest's test docker containers

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-02-23 12:14:28 +00:00
Bruce Dawson
2cf48e9534
Allow invoking git.bat as git on Windows (#5118)
In a Chromium build environment on Windows git is supplied by
depot_tools as git.bat. This was causing build errors on Windows that
are most easily reproduced with this command:

  gn gen out\default && gn clean out\default && ninja -C out\default spirv-as

The errors included:

[12:55:40][ERROR   ] Failed to run "['git', 'tag', '--sort=-v:refname']" in "C:\src\chromium\src\third_party\vulkan-deps\spirv-tools\src": [WinError 2] The system cannot find the file specified
[12:55:40][WARNING ] Could not deduce latest release version from history.

This is because 'git' does not resolve to git.bat unless shell=True is
passed to subprocess.Popen. This change passes shell=True but only on
Windows which resolves these errors.
2023-02-23 03:24:34 +00:00
github-actions[bot]
9017cfcf62
Roll external/googletest/ 7a7231c44..750d67d80 (1 commit) (#5119)
7a7231c442...750d67d809

$ git log 7a7231c44..750d67d80 --date=short --no-merges --format='%ad %ae %s'
2023-02-21 tomhughes Remove int64_t cast in RecordProperty

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-02-22 11:23:34 +00:00
github-actions[bot]
8bcaad28f7
Roll external/re2/ 9049cd28d..3a8436ac4 (1 commit) (#5117)
9049cd28d7...3a8436ac43

$ git log 9049cd28d..3a8436ac4 --date=short --no-merges --format='%ad %ae %s'
2023-02-20 junyer Fuzz `RE2::Set` and `FilteredRE2`.

Created with:
  roll-dep external/re2

Co-authored-by: GitHub Actions[bot] <>
2023-02-21 13:44:37 +00:00
Nathan Gauër
987a5f1367
build: change the way we set cxx version for bazel. (#5114)
Before, we did set cxx version to c++17 using COPTS in our bazel files.
This was wrong, and part of the dependencies were then built with the
default standard version. This was not an issue until we moved to c++17.

Then, we decided to use the bazel --cxxopt=-std=c++17, but this was only
valid for nix platforms.
The last option left is to ask the user to specify the standard
when building using bazel.
2023-02-20 11:11:16 +01:00
github-actions[bot]
69ed5adf10
Roll external/googletest/ f063cd25c..7a7231c44 (1 commit) (#5116)
f063cd25c9...7a7231c442

$ git log f063cd25c..7a7231c44 --date=short --no-merges --format='%ad %ae %s'
2023-02-16 absl-team Fix link in ReportUninterestingCall message

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-02-17 14:45:07 +00:00
github-actions[bot]
c9947cc8d5
Roll external/googletest/ 2057566e4..f063cd25c (1 commit) (#5115)
2057566e4e...f063cd25c9

$ git log 2057566e4..f063cd25c --date=short --no-merges --format='%ad %ae %s'
2023-02-15 absl-team Remove strdup usage

Created with:
  roll-dep external/googletest

Co-authored-by: GitHub Actions[bot] <>
2023-02-16 13:11:36 +00:00