David Neto
a9d884e58d
spirv-as: Assume target from spvasm text ( #5893 )
...
* spirv-as: Assume target from spvasm text
Assume the desired SPIR-V target version when the command line option is
not provided. This is especially important when the source being
assembled does not match the default (latest version), because it may
create an invalid SPIR-V binary result.
Also, clarify the wording for where a copy of spirv-headers is expected
(to match expected capitalization).
* fix formatting
* Add unit tests, static asserts on supported SPIR-V versions
Rework the algorithm so it accepts earlier termination of the version
string. That made testing easier and more intuitive.
* Fix compilation problems
---------
Co-authored-by: mmoult <30711895+mmoult@users.noreply.github.com>
2024-11-26 17:57:32 -05:00
Spencer Fricke
f3c4a5053f
spirv-val: Add missing NonSemantic.Shader.DebugInfo.100 ( #5846 )
...
* spirv-val: Cleanup DebugExtension tests
* spirv-val: Cleanup DebugExtension tests extensions
* spirv-val: Add missing NonSemantic.Shader.DebugInfo.100
* spirv-opt: Fix broken DebugLine in tests
2024-11-25 13:47:25 -05:00
github-actions[bot]
ea1d8cd981
Roll external/abseil_cpp/ 8f739d18b..917bfee46 (2 commits) ( #5887 )
...
8f739d18b9...917bfee465
2024-11-16 12:41:36 +00:00
dependabot[bot]
16fa89f060
build(deps): bump the github-actions group across 1 directory with 2 updates ( #5885 )
...
Bumps the github-actions group with 2 updates in the / directory: [lukka/get-cmake](https://github.com/lukka/get-cmake ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `lukka/get-cmake` from 3.30.5 to 3.31.0
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](b516803a3c...71b7adfe26https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](662472033e...ea9e4e3799
2024-11-15 17:02:55 -05:00
github-actions[bot]
27433b11e9
roll deps ( #5883 )
...
* Roll external/abseil_cpp/ 27a0c7308..8f739d18b (3 commits)
27a0c7308f...8f739d18b9996c728cf7...45b314049d
2024-11-15 03:23:45 +00:00
Sven van Haastregt
35e5f1160e
spirv-val: Accept valid OpSizeOf instructions ( #5879 )
...
Ensure valid `OpSizeOf` instructions are not rejected by spirv-val.
Until now, validation of a valid `OpSizeOf` instruction would fail
with the message that the operand "cannot be a type".
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
2024-11-13 10:54:31 -05:00
Nathan Gauër
692529b941
[NFC] Apply small clang-tidy fixes ( #5709 )
...
* [NFC] Apply small clang-tidy fixes
- const for passed-by-value has no effect on prototypes.
- transitive includes.
- dead stores
- uses after move
Signed-off-by: Nathan Gauër <brioche@google.com>
* pr-feedback
Signed-off-by: Nathan Gauër <brioche@google.com>
---------
Signed-off-by: Nathan Gauër <brioche@google.com>
2024-11-12 14:45:05 -05:00
Qiaojin.Bao
707da36c70
Correct a spelling error 'diagnostic' ( #5878 )
2024-11-12 13:13:48 -05:00
Steven Perron
df94b2db4a
Avoid maintaining a list of all operating systems by hand. ( #5881 )
...
See #5467
Co-authored-by: Patrick Welche <prlw1@cam.ac.uk>
2024-11-12 12:38:56 -05:00
Spencer Fricke
1601ec2639
ci: Make MacOS builds only run if other things pass ( #5872 )
2024-11-12 10:49:08 -05:00
github-actions[bot]
671e7ca5ee
Roll external/abseil_cpp/ a3027054a..27a0c7308 (7 commits) ( #5875 )
...
a3027054ab...27a0c7308f
2024-11-12 15:37:18 +00:00
Sven van Haastregt
384d527ebb
spirv-val: Report VUID 08973 only in Vulkan environments ( #5873 )
...
The storage class restriction for `OpCooperativeMatrixLoadKHR` and
`OpCooperativeMatrixStoreKHR` comes from the Vulkan specification; as
such VUID 08973 should not be reported outside of Vulkan target
environments.
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
2024-11-11 11:18:45 -05:00
github-actions[bot]
9117e042b9
roll deps ( #5871 )
...
* Roll external/googletest/ 1204d6344..d14403194 (1 commit)
1204d63444...d1440319404b4f41e93d...a3027054abcb6b2c32db...996c728cf7
2024-11-07 03:12:15 +00:00
Shahbaz Youssefi
02433568af
tools: Accept hex representation as binary input ( #5870 )
...
Sometimes when debugging or logging, SPIR-V may be dumped as a stream of
hex values. There are tools to convert such a stream to binary
(such as [1]) but they create an inconvenient extra step when for
example the disassembly of that hex stream is needed.
[1]: https://www.khronos.org/spir/visualizer/hexdump.html
In this change, the binary reader used by the tools is enhanced to
detect when the binary is actually a hex stream, and parse that instead.
The following formats are accepted, detected based on how the SPIR-V
magic number is output:
=== Words
If the first token of the hex stream is one of 0x07230203, 0x7230203,
x07230203, or x7230203, the hex stream is expected to consist of 32-bit
hex words prefixed with 0x or x. For example:
0x7230203, 0x10400, 0x180001, 0x79, 0x0
is parsed as:
0x07230203 0x00010400 0x00180001 0x00000079 0x00000000
Note that `,` is optional in the stream, but the hex values are expected
to be delimited by either `,` or whitespace.
=== Bytes With Prefix
If the first token of the hex stream is one of 0x07, 0x7, x07, x7, 0x03,
0x3, x03, or x3, the hex stream is expected to consist of 8-bit hex
bytes prefixed with 0x or x. If the first token has a value of 7, the
stream is big-endian. Otherwise it's little-endian. For example:
0x3, 0x2, 0x23, 0x7, 0x0, 0x4, 0x1, 0x0, 0x1, 0x0, 0x18, 0x0, 0x79, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0
is parsed as:
0x07230203 0x00010400 0x00180001 0x00000079 0x00000000
Similar to "Words", `,` is optional in the stream, but the hex values
are expected to be delimited by either `,` or whitespace.
=== Bytes Without Prefix
If the first two characters of the hex stream is 07, or 03, the hex
stream is expected to consist of 8-bit hex bytes of 2 characters each.
If the first token is 07, the stream is big-endian. Otherwise it's
little-endian. Unlike the other modes, delimiter is optional (which
automatically handles 32-bit word streams), but no 0-padding is done.
For example, all of the following:
03, 02, 23, 07, 00, 04, 01, 00, 01, 00, 18, 00, 79, 00, 00, 00, 00, 00, 00, 00
03 02 23 07 00 04 01 00 01 00 18 00 79 00 00 00 00 00 00 00
03022307 00040100 01001800 79000000 00000000
07,23,02,03,00,01,04,00,00,18,00,01,00,00,00,79,00,00,00,00
07230203, 00010400, 00180001, 00000079, 00000000
are parsed as:
0x07230203 0x00010400 0x00180001 0x00000079 0x00000000
2024-11-04 09:57:37 -05:00
dependabot[bot]
d426fc53bb
build(deps): bump the github-actions group across 1 directory with 3 updates ( #5866 )
...
Bumps the github-actions group with 3 updates in the / directory: [actions/checkout](https://github.com/actions/checkout ), [actions/cache](https://github.com/actions/cache ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/checkout` from 4.2.1 to 4.2.2
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](eef61447b9...11bd71901bhttps://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](3624ceb22c...6849a64899https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](c36620d31a...662472033e
2024-11-04 07:23:22 -05:00
github-actions[bot]
9aaa260140
roll deps ( #5850 )
...
* Roll external/googletest/ 71815bbf7..1204d6344 (4 commits)
71815bbf7d...1204d6344440cab24455...4b4f41e93d22c4d1b1e9...cb6b2c32db
2024-11-02 10:46:42 +00:00
dan sinclair
e5c1498afa
Update proto JSON options call. ( #5867 )
...
This CL updates the usage of JsonOptions which is deprecated to the newer
JsonPrintOptions.
2024-10-31 21:08:25 -04:00
Shahbaz Youssefi
5f1e86cb55
tools: Move io utils to cpp ( #5869 )
...
In preparation for more code in that file, which would get unwieldy in a
header.
2024-10-28 13:31:54 -04:00
Jeff Bolz
ce92630396
Add validation for SPV_NV_tensor_addressing and SPV_NV_cooperative_matrix2 ( #5865 )
2024-10-24 13:55:04 -04:00
Nathan Gauër
298055b25c
opt: add StorageImageWriteWithoutFormat to trimm pass ( #5860 )
...
* opt: add StorageImageWriteWithoutFormat to trimm pass
---------
Signed-off-by: Nathan Gauër <brioche@google.com>
2024-10-24 06:21:17 -04:00
Nathan Gauër
895bb9ffec
opt: add KHR_fragment_shading_rate to allowlist ( #5859 )
...
Allowing this extensions to the few gated optimization passes.
Signed-off-by: Nathan Gauër <brioche@google.com>
2024-10-21 11:25:49 -07:00
Jeremy Gebben
ba37b3b513
opt: Remove InstDebugPrintfPass ( #5856 )
...
This code was only used by Vulkan-Validation layers and it has
now been replaced by code in that repository.
2024-10-17 15:05:56 -04:00
Spencer Fricke
14388d7014
ci: Update MacOS to latest OS ( #5855 )
2024-10-16 19:44:28 -04:00
alan-baker
a832c13331
Fix switch case construct validation ( #5852 )
...
* Fix switch case construct validation
Fixes https://crbug.com/tint/372311599
* Stop using block depth in switch validation and instead use the more
robust structured exit logic from the switch construct
* This is valid because the function has already handled the
additional valid cases for case constructs
* formatting
2024-10-16 11:09:21 -04:00
Cassandra Beckley
2ea729062b
opt: Fix array copy propagation of access chain pointers ( #5853 )
...
#5827 is broken for situations where a loaded value is stored to a pointer resulting from an OpAccessChain. Traverse access chains to find the original OpVariable to add to the worklist.
2024-10-16 10:51:05 -04:00
dependabot[bot]
5b98dea6f1
build(deps): bump the github-actions group across 1 directory with 5 updates ( #5847 )
...
Bumps the github-actions group with 5 updates in the / directory:
| Package | From | To |
| --- | --- | --- |
| [actions/checkout](https://github.com/actions/checkout ) | `4.2.0` | `4.2.1` |
| [actions/cache](https://github.com/actions/cache ) | `4.1.0` | `4.1.1` |
| [lukka/get-cmake](https://github.com/lukka/get-cmake ) | `3.30.4` | `3.30.5` |
| [actions/upload-artifact](https://github.com/actions/upload-artifact ) | `4.4.0` | `4.4.3` |
| [github/codeql-action](https://github.com/github/codeql-action ) | `3.26.11` | `3.26.12` |
Updates `actions/checkout` from 4.2.0 to 4.2.1
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](d632683dd7...eef61447b9https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](2cdf405574...3624ceb22chttps://github.com/lukka/get-cmake/releases )
- [Commits](582a9f5c6f...b516803a3chttps://github.com/actions/upload-artifact/releases )
- [Commits](50769540e7...b4b15b8c7chttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](6db8d6351f...c36620d31a
2024-10-14 15:19:35 -04:00
github-actions[bot]
68265e1604
Roll external/abseil_cpp/ 03b8d6ea3..8634e35f1 (1 commit) ( #5844 )
...
* Roll external/abseil_cpp/ 03b8d6ea3..40cab2445 (4 commits)
03b8d6ea3d...40cab24455d92cf88c37...50bc4debdc
2024-10-14 18:53:31 +00:00
alan-baker
42b315c15b
Fix result type check in ValidateImageTexelPointer ( #5848 )
...
Fixes https://crbug.com/oss-fuzz/42537207
* Fix check and messages in ValidateImageTexelPointer
2024-10-10 14:10:07 -04:00
alan-baker
fcf994a619
Handle aliases field in the grammar ( #5799 )
...
* Modify static table generation scripts to include alias lists
* Modify spv_opcode_desc_t and spv_operand_desc_t to include aliases
* Modify opcode and operand lookup by name to also search aliases
* update vim syntax generator
2024-10-09 12:50:32 -04:00
dependabot[bot]
4310fd4eda
build(deps): bump the github-actions group across 1 directory with 3 updates ( #5841 )
...
Bumps the github-actions group with 3 updates in the / directory: [actions/cache](https://github.com/actions/cache ), [lukka/get-cmake](https://github.com/lukka/get-cmake ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/cache` from 4.0.2 to 4.1.0
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](0c45773b62...2cdf405574https://github.com/lukka/get-cmake/releases )
- [Commits](070a0507a7...582a9f5c6fhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e2b3eafc8d...6db8d6351f
2024-10-07 09:22:43 -04:00
github-actions[bot]
ada92f8492
roll deps ( #5833 )
...
* Roll external/googletest/ a1e255a58..71815bbf7 (1 commit)
a1e255a582...71815bbf7dc6b27359c3...03b8d6ea3dec59c77a3b...a62b032007
2024-10-06 11:38:32 +00:00
Cassandra Beckley
522dfead39
opt: Add support for OpExtInst to capability trim pass ( #5836 )
...
The grammar does track required capabilities for extended instruction
set operations, so we just need to look them up.
2024-10-04 00:42:48 -07:00
dependabot[bot]
c173df736c
build(deps): bump github/codeql-action in the github-actions group ( #5831 )
...
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 3.26.9 to 3.26.10
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](461ef6c76d...e2b3eafc8d
2024-10-02 11:36:27 -04:00
github-actions[bot]
4554c6b7ea
Roll external/abseil_cpp/ 482ca0b9d..c6b27359c (1 commit) ( #5829 )
...
* Roll external/googletest/ 6dae7eb4a..a1e255a58 (1 commit)
6dae7eb4a5...a1e255a582482ca0b9d6...c6b27359c3
2024-10-02 15:19:52 +00:00
Cassandra Beckley
48f9f4a99e
opt: Update copy prop arrays to handle InterpolateAt* instructions ( #5827 )
...
Adds support for `InterpolateAtCentroid`, `InterpolateAtSample`, and `InterpolateAtOffset` to the copy propagate arrays pass, as well as propagating pointers with the `Input` storage class. Also handles situations where variables should be propagated in an order different than the order that they are declared in the source.
2024-10-02 09:38:32 -04:00
github-actions[bot]
d9c1aee6a6
Roll external/abseil_cpp/ ba5fd0979..482ca0b9d (1 commit) ( #5828 )
...
ba5fd0979b...482ca0b9d6
2024-09-27 14:54:25 +00:00
Cassandra Beckley
b1ad37b175
opt: Mark InterpolateAt* argument as live for DCE ( #5824 )
...
The GLSL 450 InterpolateAt* instructions should be treated as a load by dead code elimination. This is part of https://github.com/microsoft/DirectXShaderCompiler/issues/3649 .
2024-09-26 16:49:36 -04:00
Steven Perron
5b38abc877
Do not distrubute OpSNegate into OpUDiv ( #5823 )
...
We cannot apply the negate to an operand of an OpUDiv instead of it
result. This is because the operands of the OpUDiv are interpreted as
unsigned. We stop the optimizer from doing that.
There were no tests for distributing a negate into OpIMul, OpSDiv, and
OpUDiv. Tests are added for all of these.
Fixes #5822
2024-09-26 15:00:56 -04:00
dependabot[bot]
5c8442f7fc
build(deps-dev): bump rollup from 3.23.0 to 3.29.5 in /tools/sva ( #5826 )
...
Bumps [rollup](https://github.com/rollup/rollup ) from 3.23.0 to 3.29.5.
- [Release notes](https://github.com/rollup/rollup/releases )
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rollup/rollup/compare/v3.23.0...v3.29.5 )
---
updated-dependencies:
- dependency-name: rollup
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-26 13:45:37 -04:00
dependabot[bot]
c0e6399dfb
build(deps): bump the github-actions group across 1 directory with 2 updates ( #5825 )
...
Bumps the github-actions group with 2 updates in the / directory: [actions/checkout](https://github.com/actions/checkout ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/checkout` from 4.1.7 to 4.2.0
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](692973e3d9...d632683dd7https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](294a9d9291...461ef6c76d
2024-09-26 13:40:52 -04:00
github-actions[bot]
3656c4bd1a
Roll external/abseil_cpp/ c0b9bd08e..ba5fd0979 (2 commits) ( #5818 )
...
* Roll external/abseil_cpp/ c0b9bd08e..ba5fd0979 (2 commits)
c0b9bd08e0...ba5fd0979b2a9b6f951c...ec59c77a3b
2024-09-26 17:20:46 +00:00
JN Mo
44936c4a9d
Add support for SPV_KHR_compute_shader_derivative ( #5817 )
...
* Add support for SPV_KHR_compute_shader_derivative
* Update tests for SPV_KHR_compute_shader_derivatives
---------
Co-authored-by: MagicPoncho <magicponcho@gmail.com>
2024-09-25 09:59:33 -04:00
alan-baker
362ce7c60d
Allow more levels of arrays with component decoration ( #5820 )
...
Fixes #5819
* Allow multiple levels of arrays in a variable with component
decoration
2024-09-24 11:14:28 -04:00
dependabot[bot]
24849751c4
build(deps): bump github/codeql-action in the github-actions group ( #5813 )
...
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 3.26.7 to 3.26.8
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](8214744c54...294a9d9291
2024-09-23 11:44:51 -04:00
github-actions[bot]
c405baf8c9
Roll external/abseil_cpp/ 0df567400..c0b9bd08e (3 commits) ( #5812 )
...
0df5674003...c0b9bd08e0
2024-09-23 15:24:08 +00:00
Sven van Haastregt
7ba72f14f2
spirv-val: Disallow stores according to VUID 06924 ( #5368 )
...
Ensure that the validator rejects stores to objects of types
`OpTypeImage`, `OpTypeSampler`, `OpTypeSampledImage`,
`OpTypeAccelerationStructureKHR`, and arrays of these types, according
to `VUID-StandaloneSpirv-OpTypeImage-06924`.
Guard the check behind the before_hlsl_legalization option, as
sometimes we may have temporaries or local variables that are expected
to get optimized away.
Fixes #4796
Change-Id: Ie035c01c5f94e7bdfc16b5c6c85705f302b7bda3
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
2024-09-23 08:34:30 -04:00
Viktoria Maximova
01c8438ee4
[SPV_KHR_untyped_pointers] Fix verification for OpenCL.std instructions ( #5810 )
...
Allow `p` to be untyped pointer for `fract`, `frexp`, `lgamma_r`,
`modf`, `remquo`, and `sincos`.
```
operand must be a pointer(p1, ...).If it is a typed pointer, it must
point to data types.
```
https://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_untyped_pointers.html#_modifications_to_the_opencl_std_extended_instruction_set
2024-09-20 11:31:46 -04:00
Cassandra Beckley
6dcc7e350a
Prepare release v2024.4 ( #5811 )
2024-09-19 15:28:18 -04:00
github-actions[bot]
04bdb6c7c9
roll deps ( #5809 )
...
* Roll external/googletest/ 0953a17a4..6dae7eb4a (1 commit)
0953a17a42...6dae7eb4a5f7c22f52a7...0df5674003
2024-09-18 10:53:02 +00:00
Ben Ashbaugh
20788a4c5f
add support for SPV_INTEL_global_variable_host_access ( #5786 )
2024-09-17 12:31:29 -04:00
