Applied the following suggestions:
modernize-deprecated-headers
google-readability-casting
google-readability-namespace-comments
readability-else-after-return
Some libcs like uClibc-ng can optionally disable deprecated functions.
utime is one of them. When done so, both the header and the function go
missing.
This fixes flac_utime to work in such a situation.
The 1.3.3 release didn't update the version number in the cmake
build. It's too late to fix the release, but bringing the version
number into sync allows the metaflac test which verifies the
encoder's embedded version number to pass, giving us proper test
feedback on other changes to the development tree.
Fix "privacy-breach-w3c-valid-html" lintian error.
Don't ping an external site when loading documentation
pages since this can be used to track user activity.
These links are also broken, since they depend on the
referer header, which browsers no longer send to insecure
pages for similar privacy reasons. That aspect could be
addressed by using https urls for the validator site.
Signed-off-by: Ralph Giles <giles@thaumas.net>
Improve the conformance of the xhtml generated by doxygen by
using the self-closing <hr/> tag in the custom footer.
Without this, xmllint complains about </body> and </html> end
tags inside the still-only <hr>. That syntax is allowed in
html but not xml.
Install Doxygen when running on the linux environment to test
generation of the API documentation.
Run the included static html documentation as well as the
generated API documentation through xmllint to verify
it conforms to the declared DTD. Since this this will be very
slow or fail relying on network resources, also install
the w3c-sgml library so the xhtml1 DTDs are available locally.
We're checking the source files, not build results in the
particular environment, so it's fine to run this check
on only a subset of builds.
Don't validate on CMake builds since they're not currently
generating API documentation even when Doxygen is available.
* Add CMake builds with ENABLE_64_BIT_WORDS enabled\disabled
* Run tests in parallel jobs
* Use Xenial Travis image to support CMake >= 3.12
* Install libtool-bin package missing in Xenial image
If the user specifies `--no-error-on-compression-fail`, there is no need
to treat compression failure as an error. Hence, the failure message
should be suppressed along with the non-zero exit code (which already
is suppressed).
