AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-25 14:30:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

powerpc: Fix compiler warning on some syscalls

Browse Source 
GCC 5.0 emits an warning when using sizeof on array function parameters
and powerpc internal syscall macros add a check for such cases.  More
specifically, on powerpc64 and powerpc32 sysdep.h:

  if (__builtin_classify_type (__arg3) != 5 && sizeof (__arg3) > 8) \
          __illegally_sized_syscall_arg3 (); \

And for sysdeps/unix/sysv/linux/utimensat.c build GCC emits:

error: ‘sizeof’ on array function parameter ‘tsp’ will return size of
‘const struct timespec *’

This patch uses the address of first struct member instead of the struct
itself in syscall macro.
This commit is contained in:
Adhemerval Zanella 2015-01-06 07:59:04 -05:00
parent 28c38448de
commit dd6e8af6ba
5 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@ -1,3 +1,12 @@
2015-01-08 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
* sysdeps/unix/sysv/linux/futimens.c (futimens): Use address of first
timespec struct member in syscall macro.
* sysdeps/unix/sysv/linux/utimensat.c (utimensat): Likewise.
* sysdeps/unix/sysv/linux/futimesat.c (futimesat): Use address of
first timeval struct member in syscall macro.
* sysdeps/unix/sysv/linux/utimes.c (__utimeS): Likewise.
2015-01-07 Joseph Myers <joseph@codesourcery.com>
[BZ #17748]

3
sysdeps/unix/sysv/linux/futimens.c
View File

@ -37,7 +37,8 @@ futimens (int fd, const struct timespec tsp[2])
__set_errno (EBADF);
return -1;
}
return INLINE_SYSCALL (utimensat, 4, fd, NULL, tsp, 0);
/* Avoid implicit array coercion in syscall macros. */
return INLINE_SYSCALL (utimensat, 4, fd, NULL, &tsp[0], 0);
#else
__set_errno (ENOSYS);
return -1;

8
sysdeps/unix/sysv/linux/futimesat.c
View File

@ -28,13 +28,11 @@
/* Change the access time of FILE relative to FD to TVP[0] and
the modification time of FILE to TVP[1]. */
int
futimesat (fd, file, tvp)
int fd;
const char *file;
const struct timeval tvp[2];
futimesat (int fd, const char *file, const struct timeval tvp[2])
{
if (file == NULL)
return __futimes (fd, tvp);
return INLINE_SYSCALL (futimesat, 3, fd, file, tvp);
/* Avoid implicit array coercion in syscall macros. */
return INLINE_SYSCALL (futimesat, 3, fd, file, &tvp[0]);
}

3
sysdeps/unix/sysv/linux/utimensat.c
View File

@ -35,7 +35,8 @@ utimensat (int fd, const char *file, const struct timespec tsp[2],
return -1;
}
#ifdef __NR_utimensat
return INLINE_SYSCALL (utimensat, 4, fd, file, tsp, flags);
/* Avoid implicit array coercion in syscall macros. */
return INLINE_SYSCALL (utimensat, 4, fd, file, &tsp[0], flags);
#else
__set_errno (ENOSYS);
return -1;

3
sysdeps/unix/sysv/linux/utimes.c
View File

@ -29,7 +29,8 @@
int
__utimes (const char *file, const struct timeval tvp[2])
{
return INLINE_SYSCALL (utimes, 2, file, tvp);
/* Avoid implicit array coercion in syscall macros. */
return INLINE_SYSCALL (utimes, 2, file, &tvp[0]);
}
weak_alias (__utimes, utimes)