mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-22 02:40:08 +00:00
37825319ee
This patch refactors code in sysdeps/i386/fpu that forces underflow exceptions to use common macros for that purpose as far as possible. (Although some of the macros end up used in only one place, I think it's cleanest to define all these macros together so that all the code forcing underflow uses such macros. Some more uses of such macros will also be introduced when fixing remaining bugs about missing underflow exceptions, and it would be possible to do further refactoring of the macros in i386-math-asm.h to share more code by using other macros internally. Places that test for underflow by examining the representation of the argument with integer operations, rather that using floating-point comparisons on the argument or result, are unchanged by this patch.) Most of this code uses a macro MO to abstract away the differences between PIC and non-PIC memory references to constants. log1p functions, however, hardcoded PIC conditionals for this. Because the common macros rely on the use of MO, I changed the log1p functions to use the normal style here, and, for consistency, also made that change to log1pl which is otherwise unaffected by this patch. Tested for x86. * sysdeps/i386/fpu/i386-math-asm.h (DEFINE_LDBL_MIN): New macro. (FLT_CHECK_FORCE_UFLOW): Likewise. (DBL_CHECK_FORCE_UFLOW): Likewise. (FLT_CHECK_FORCE_UFLOW_NARROW): Likewise. (DBL_CHECK_FORCE_UFLOW_NARROW): Likewise. (LDBL_CHECK_FORCE_UFLOW_NONNEG_NAN): Likewise. (FLT_CHECK_FORCE_UFLOW_NONNAN): Likewise. (DBL_CHECK_FORCE_UFLOW_NONNAN): Likewise. (FLT_CHECK_FORCE_UFLOW_NONNEG): Likewise. (DBL_CHECK_FORCE_UFLOW_NONNEG): Likewise. (LDBL_CHECK_FORCE_UFLOW_NONNEG): Likewise. * sysdeps/i386/fpu/e_asin.S: Include <i386-math-asm.h>. (dbl_min): Replace with use of DEFINE_DBL_MIN. (__ieee754_asin): Use DBL_CHECK_FORCE_UFLOW. * sysdeps/i386/fpu/e_asinf.S: Include <i386-math-asm.h>. (flt_min): Replace with use of DEFINE_FLT_MIN. (__ieee754_asinf): Use FLT_CHECK_FORCE_UFLOW. * sysdeps/i386/fpu/e_atan2.S: Include <i386-math-asm.h>. (dbl_min): Replace with use of DEFINE_DBL_MIN. (__ieee754_atan2): Use DBL_CHECK_FORCE_UFLOW_NARROW. * sysdeps/i386/fpu/e_atan2f.S: Include <i386-math-asm.h>. (flt_min): Replace with use of DEFINE_FLT_MIN. (__ieee754_atan2f): Use FLT_CHECK_FORCE_UFLOW_NARROW. * sysdeps/i386/fpu/e_atanh.S: Include <i386-math-asm.h>. (dbl_min): Replace with use of DEFINE_DBL_MIN. (__ieee754_atanh): Use DBL_CHECK_FORCE_UFLOW_NONNEG. * sysdeps/i386/fpu/e_atanhf.S: Include <i386-math-asm.h>. (flt_min): Replace with use of DEFINE_FLT_MIN. (__ieee754_atanhf): Use FLT_CHECK_FORCE_UFLOW_NONNEG. * sysdeps/i386/fpu/e_exp2l.S: Include <i386-math-asm.h>. (ldbl_min): Replace with use of DEFINE_LDBL_MIN. (__ieee754_exp2l): Use LDBL_CHECK_FORCE_UFLOW_NONNEG_NAN. * sysdeps/i386/fpu/e_expl.S: Include <i386-math-asm.h>. [!USE_AS_EXPM1L] (cmin): Replace with use of DEFINE_LDBL_MIN. (IEEE754_EXPL): Use LDBL_CHECK_FORCE_UFLOW_NONNEG. * sysdeps/i386/fpu/s_atan.S: Include <i386-math-asm.h>. (dbl_min): Replace with use of DEFINE_DBL_MIN. (__atan): Use DBL_CHECK_FORCE_UFLOW. * sysdeps/i386/fpu/s_atanf.S: Include <i386-math-asm.h>. (flt_min): Replace with use of DEFINE_FLT_MIN. (__atanf): Use FLT_CHECK_FORCE_UFLOW. * sysdeps/i386/fpu/s_expm1.S: Include <i386-math-asm.h>. (dbl_min): Replace with use of DEFINE_DBL_MIN. (__expm1): Use DBL_CHECK_FORCE_UFLOW. Move underflow check after main computation. * sysdeps/i386/fpu/s_expm1f.S: Include <i386-math-asm.h>. (flt_min): Replace with use of DEFINE_FLT_MIN. (__expm1f): Use FLT_CHECK_FORCE_UFLOW. Move underflow check after main computation. * sysdeps/i386/fpu/s_log1p.S: Include <i386-math-asm.h>. (dbl_min): Replace with use of DEFINE_DBL_MIN. (MO): New macro. (__log1p): Use MO. Use DBL_CHECK_FORCE_UFLOW_NONNAN. * sysdeps/i386/fpu/s_log1pf.S: Include <i386-math-asm.h>. (flt_min): Replace with use of DEFINE_FLT_MIN. (MO): New macro. (__log1pf): Use MO. Use FLT_CHECK_FORCE_UFLOW_NONNAN. * sysdeps/i386/fpu/s_log1pl.S (MO): New macro. (__log1pl): Use MO. |
||
|---|---|---|
| .. | ||
| fpu | ||
| i586 | ||
| i686 | ||
| i786 | ||
| nptl | ||
| sys | ||
| ____longjmp_chk.S | ||
| __longjmp.S | ||
| abort-instr.h | ||
| add_n.S | ||
| addmul_1.S | ||
| asm-syntax.h | ||
| atomic-machine.h | ||
| backtrace.c | ||
| bcopy.S | ||
| bsd-_setjmp.S | ||
| bsd-setjmp.S | ||
| bzero.S | ||
| cacheinfo.c | ||
| configure | ||
| configure.ac | ||
| crti.S | ||
| crtn.S | ||
| dl-irel.h | ||
| dl-lookupcfg.h | ||
| dl-machine.h | ||
| dl-procinfo.c | ||
| dl-procinfo.h | ||
| dl-tls.h | ||
| dl-tlsdesc.h | ||
| dl-tlsdesc.S | ||
| dl-trampoline.S | ||
| ffs.c | ||
| gccframe.h | ||
| gmp-mparam.h | ||
| htonl.S | ||
| htons.S | ||
| i386-mcount.S | ||
| Implies | ||
| init-arch.h | ||
| jmpbuf-offsets.h | ||
| jmpbuf-unwind.h | ||
| ldbl2mpn.c | ||
| ldsodefs.h | ||
| link-defines.sym | ||
| lshift.S | ||
| machine-gmon.h | ||
| Makefile | ||
| memchr.S | ||
| memcmp.S | ||
| memcopy.h | ||
| memcpy_chk.S | ||
| memcpy.S | ||
| memmove_chk.S | ||
| memmove.S | ||
| mempcpy_chk.S | ||
| mempcpy.S | ||
| memset_chk.S | ||
| memset.S | ||
| memusage.h | ||
| mp_clz_tab.c | ||
| mul_1.S | ||
| preconfigure | ||
| pthread_spin_trylock.S | ||
| rawmemchr.S | ||
| rshift.S | ||
| setfpucw.c | ||
| setjmp.S | ||
| stackguard-macros.h | ||
| stackinfo.h | ||
| start.S | ||
| stpcpy.S | ||
| stpncpy.S | ||
| strcat.S | ||
| strchr.S | ||
| strchrnul.S | ||
| strcspn.S | ||
| string-inlines.c | ||
| strlen.c | ||
| strlen.S | ||
| strpbrk.S | ||
| strrchr.S | ||
| strspn.S | ||
| strtok_r.S | ||
| strtok.S | ||
| sub_n.S | ||
| submul_1.S | ||
| sysdep.h | ||
| tls-macros.h | ||
| tlsdesc.c | ||
| tlsdesc.sym | ||
| tst-audit3.c | ||
| tst-audit3.h | ||
| tst-audit.h | ||
| tst-auditmod3a.c | ||
| tst-auditmod3b.c | ||
| tst-ld-sse-use.sh | ||
| tst-stack-align.h | ||
| Versions | ||