mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-14 01:00:07 +00:00
e02920bc02
In non-default rounding modes, tgamma can be slightly less accurate than permitted by glibc's accuracy goals. Part of the problem is error accumulation, addressed in this patch by setting round-to-nearest for internal computations. However, there was also a bug in the code dealing with computing pow (x + n, x + n) where x + n is not exactly representable, providing another source of error even in round-to-nearest mode; it was necessary to address both bugs to get errors for all testcases within glibc's accuracy goals. Given this second fix, accuracy in round-to-nearest mode is also improved (hence regeneration of ulps for tgamma should be from scratch - truncate libm-test-ulps or at least remove existing tgamma entries - so that the expected ulps can be reduced). Some additional complications also arose. Certain tgamma tests should strictly, according to IEEE semantics, overflow or not depending on the rounding mode; this is beyond the scope of glibc's accuracy goals for any function without exactly-determined results, but gen-auto-libm-tests doesn't handle being lax there as it does for underflow. (libm-test.inc also doesn't handle being lax about whether the result in cases very close to the overflow threshold is infinity or a finite value close to overflow, but that doesn't cause problems in this case though I've seen it cause problems with random test generation for some functions.) Thus, spurious-overflow markings, with a comment, are added to auto-libm-test-in (no bug in Bugzilla because the issue is with the testsuite, not a user-visible bug in glibc). And on x86, after the patch I saw ERANGE issues as previously reported by Carlos (see my commentary in <https://sourceware.org/ml/libc-alpha/2015-01/msg00485.html>), which needed addressing by ensuring excess range and precision were eliminated at various points if FLT_EVAL_METHOD != 0. I also noticed and fixed a cosmetic issue where 1.0f was used in long double functions and should have been 1.0L. This completes the move of all functions to testing in all rounding modes with ALL_RM_TEST, so gen-libm-have-vector-test.sh is updated to remove the workaround for some functions not using ALL_RM_TEST. Tested for x86_64, x86, mips64 and powerpc. [BZ #18613] * sysdeps/ieee754/dbl-64/e_gamma_r.c (gamma_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gamma_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. * sysdeps/ieee754/flt-32/e_gammaf_r.c (gammaf_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammaf_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. * sysdeps/ieee754/ldbl-128/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * sysdeps/ieee754/ldbl-128ibm/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * sysdeps/ieee754/ldbl-96/e_gammal_r.c (gammal_positive): Take log of X_ADJ not X when adjusting exponent. (__ieee754_gammal_r): Do intermediate computations in round-to-nearest then adjust overflowing and underflowing results as needed. Use 1.0L not 1.0f as numerator of division. * math/libm-test.inc (tgamma_test_data): Remove one test. Moved to auto-libm-test-in. (tgamma_test): Use ALL_RM_TEST. * math/auto-libm-test-in: Add one test of tgamma. Mark some other tests of tgamma with spurious-overflow. * math/auto-libm-test-out: Regenerated. * math/gen-libm-have-vector-test.sh: Do not check for START. * sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/x86_64/fpu/libm-test-ulps: Likewise. |
||
|---|---|---|
| .. | ||
| e_acoshl.c | ||
| e_acosl.c | ||
| e_asinl.c | ||
| e_atan2l.c | ||
| e_atanhl.c | ||
| e_coshl.c | ||
| e_exp10l.c | ||
| e_expl.c | ||
| e_fmodl.c | ||
| e_gammal_r.c | ||
| e_hypotl.c | ||
| e_ilogbl.c | ||
| e_j0l.c | ||
| e_j1l.c | ||
| e_jnl.c | ||
| e_lgammal_r.c | ||
| e_log2l.c | ||
| e_log10l.c | ||
| e_logl.c | ||
| e_powl.c | ||
| e_rem_pio2l.c | ||
| e_remainderl.c | ||
| e_sinhl.c | ||
| e_sqrtl.c | ||
| gamma_productl.c | ||
| ieee754.h | ||
| k_cosl.c | ||
| k_sincosl.c | ||
| k_sinl.c | ||
| k_tanl.c | ||
| ldbl2mpn.c | ||
| Makefile | ||
| math_ldbl.h | ||
| mpn2ldbl.c | ||
| printf_fphex.c | ||
| s_asinhl.c | ||
| s_atanl.c | ||
| s_cbrtl.c | ||
| s_ceill.c | ||
| s_copysignl.c | ||
| s_cosl.c | ||
| s_erfl.c | ||
| s_expm1l.c | ||
| s_fabsl.c | ||
| s_finitel.c | ||
| s_floorl.c | ||
| s_fmal.c | ||
| s_fpclassifyl.c | ||
| s_frexpl.c | ||
| s_isinf_nsl.c | ||
| s_isinfl.c | ||
| s_isnanl.c | ||
| s_issignalingl.c | ||
| s_llrintl.c | ||
| s_llroundl.c | ||
| s_log1pl.c | ||
| s_logbl.c | ||
| s_lrintl.c | ||
| s_lroundl.c | ||
| s_modfl.c | ||
| s_nearbyintl.c | ||
| s_nextafterl.c | ||
| s_nexttoward.c | ||
| s_nexttowardf.c | ||
| s_remquol.c | ||
| s_rintl.c | ||
| s_roundl.c | ||
| s_scalblnl.c | ||
| s_scalbnl.c | ||
| s_signbitl.c | ||
| s_sincosl.c | ||
| s_sinl.c | ||
| s_tanhl.c | ||
| s_tanl.c | ||
| s_truncl.c | ||
| strtold_l.c | ||
| t_sincosl.c | ||
| w_expl.c | ||
| w_log1pl.c | ||
| w_scalblnl.c | ||
| x2y2m1l.c | ||