Go to file
Joseph Myers 6caddd34bd Remove most vfprintf width/precision-dependent allocations (bug 14231, bug 26211).
The vfprintf implementation (used for all printf-family functions)
contains complicated logic to allocate internal buffers of a size
depending on the width and precision used for a format, using either
malloc or alloca depending on that size, and with consequent checks
for size overflow and allocation failure.

As noted in bug 26211, the version of that logic used when '$' plus
argument number formats are in use is missing the overflow checks,
which can result in segfaults (quite possibly exploitable, I didn't
try to work that out) when the width or precision is in the range
0x7fffffe0 through 0x7fffffff (maybe smaller values as well in the
wprintf case on 32-bit systems, when the multiplication by sizeof
(CHAR_T) can overflow).

All that complicated logic in fact appears to be useless.  As far as I
can tell, there has been no need (outside the floating-point printf
code, which does its own allocations) for allocations depending on
width or precision since commit
3e95f6602b ("Remove limitation on size
of precision for integers", Sun Sep 12 21:23:32 1999 +0000).  Thus,
this patch removes that logic completely, thereby fixing both problems
with excessive allocations for large width and precision for
non-floating-point formats, and the problem with missing overflow
checks with such allocations.  Note that this does have the
consequence that width and precision up to INT_MAX are now allowed
where previously INT_MAX / sizeof (CHAR_T) - EXTSIZ or more would have
been rejected, so could potentially expose any other overflows where
the value would previously have been rejected by those removed checks.

I believe this completely fixes bugs 14231 and 26211.

Excessive allocations are still possible in the floating-point case
(bug 21127), as are other integer or buffer overflows (see bug 26201).
This does not address the cases where a precision larger than INT_MAX
(embedded in the format string) would be meaningful without printf's
return value overflowing (when it's used with a string format, or %g
without the '#' flag, so the actual output will be much smaller), as
mentioned in bug 17829 comment 8; using size_t internally for
precision to handle that case would be complicated by struct
printf_info being a public ABI.  Nor does it address the matter of an
INT_MIN width being negated (bug 17829 comment 7; the same logic
appears a second time in the file as well, in the form of multiplying
by -1).  There may be other sources of memory allocations with malloc
in printf functions as well (bug 24988, bug 16060).  From inspection,
I think there are also integer overflows in two copies of "if ((width
-= len) < 0)" logic (where width is int, len is size_t and a very long
string could result in spurious padding being output on a 32-bit
system before printf overflows the count of output characters).

Tested for x86-64 and x86.
2020-07-07 14:54:12 +00:00
argp Rename __LONG_DOUBLE_USES_FLOAT128 to __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI 2020-04-30 08:52:08 -05:00
assert Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
benchtests benchtests: Add exp10f benchmark 2020-06-19 10:48:15 -03:00
bits Rename __LONG_DOUBLE_USES_FLOAT128 to __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI 2020-04-30 08:52:08 -05:00
catgets Update copyright dates not handled by scripts/update-copyrights. 2020-01-01 00:21:22 +00:00
ChangeLog.old Generate ChangeLog.old/ChangeLog.20 for 2.31 2020-02-01 17:22:50 +05:30
conform Convert Python scripts to Python 3 2020-03-03 15:52:09 -08:00
crypt Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
csu Remove NO_CTORS_DTORS_SECTIONS macro 2020-05-18 15:39:34 +02:00
ctype Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
debug mips: Fix bracktrace result for signal frames 2020-02-18 10:39:03 -03:00
dirent Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
dlfcn Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
elf elf: Do not signal LA_ACT_CONSISTENT for an empty namespace [BZ #26076] 2020-07-07 09:58:45 +02:00
gmon Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gnulib Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
grp Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gshadow Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
hesiod nss_hesiod: Use NSS_DECLARE_MODULE_FUNCTIONS 2020-02-13 09:14:44 +01:00
htl Add the __libc_single_threaded variable 2020-07-06 11:15:58 +02:00
hurd hurd: Add remaining cancelation points 2020-06-28 22:46:21 +00:00
iconv Fix stringop-overflow errors from gcc 10 in iconv. 2020-07-07 09:41:32 +02:00
iconvdata Reset converter state after second wchar_t output (Bug 25734) 2020-04-15 22:31:40 -04:00
include Add the __libc_single_threaded variable 2020-07-06 11:15:58 +02:00
inet Use unsigned constants for ICMP6 filters [BZ #22489] 2020-05-11 17:09:05 -04:00
intl Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
io Suppress GCC 10 true positive warnings [BZ #25967] 2020-05-11 11:38:02 -06:00
libio improve out-of-bounds checking with GCC 10 attribute access [BZ #25219] 2020-05-04 11:21:50 -06:00
locale locale: Add transliteration for Geresh, Gershayim (U+05F3, U+05F4) 2020-05-15 10:38:10 +02:00
localedata Set width of JUNGSEONG/JONGSEONG characters from UD7B0 to UD7FB to 0 [BZ #26120] 2020-06-26 09:54:43 +02:00
login y2038: Replace __clock_gettime with __clock_gettime64 2020-05-20 16:45:16 +02:00
mach hurd: add mach_print function 2020-04-14 13:19:18 +02:00
malloc malloc: ensure set_max_fast never stores zero [BZ #25733] 2020-04-06 16:27:53 -04:00
manual x86: Add thresholds for "rep movsb/stosb" to tunables 2020-07-06 11:48:42 -07:00
math Use C2x return value from getpayload of non-NaN (bug 26073). 2020-07-06 16:18:02 +00:00
mathvec Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
misc Add the __libc_single_threaded variable 2020-07-06 11:15:58 +02:00
nis y2038: Replace __clock_gettime with __clock_gettime64 2020-05-20 16:45:16 +02:00
nptl Add the __libc_single_threaded variable 2020-07-06 11:15:58 +02:00
nptl_db Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
nscd y2038: nscd: Modify nscd_helper to use __clock_gettime64 2020-05-05 18:45:14 +02:00
nss nss_compat: internal_end*ent may clobber errno, hiding ERANGE [BZ #25976] 2020-05-19 14:09:57 +02:00
po Update translations 2020-04-30 07:39:54 +05:30
posix Suppress GCC 10 true positive warnings [BZ #25967] 2020-05-11 11:38:02 -06:00
pwd Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
resolv Move implementation of <file_change_detection.h> into a C file 2020-02-18 13:44:48 +01:00
resource Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
rt Block all signals on timer_create thread (BZ#10815) 2020-02-19 13:46:31 -03:00
scripts Use Linux 5.7 in build-many-glibcs.py. 2020-06-10 22:53:55 +00:00
setjmp Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
shadow Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
signal signal: Deprecate additional legacy signal handling functions 2020-05-25 18:32:28 +02:00
socket Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
soft-fp Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
stdio-common Remove most vfprintf width/precision-dependent allocations (bug 14231, bug 26211). 2020-07-07 14:54:12 +00:00
stdlib Fix typo in comment in bug 26137 fix. 2020-07-01 14:53:30 +00:00
string string: Fix string/tst-memmove-overflow to compile with GCC 7 2020-05-14 18:51:49 +02:00
sunrpc sunrpc/tst-udp-*: Fix timeout value 2020-05-16 19:34:48 +02:00
support support: Fix detecting hole support on >2KB-block filesystems 2020-06-04 21:27:05 +02:00
sysdeps x86: Add thresholds for "rep movsb/stosb" to tunables 2020-07-06 11:48:42 -07:00
sysvipc Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
termios Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
time Update timezone code from tzcode 2020a 2020-05-15 09:19:27 -07:00
timezone Update timezone code from tzcode 2020a 2020-05-15 09:19:27 -07:00
wcsmbs mbstowcs: Document, test, and fix null pointer dst semantics (Bug 25219) 2020-06-01 12:26:32 -04:00
wctype Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
.gitattributes
.gitignore
abi-tags
aclocal.m4
config.h.in x86: Add --enable-cet=permissive 2020-05-18 08:38:53 -07:00
config.make.in Make --bindir effective 2019-05-14 11:04:33 -03:00
configure Remove NO_CTORS_DTORS_SECTIONS macro 2020-05-18 15:39:34 +02:00
configure.ac Remove NO_CTORS_DTORS_SECTIONS macro 2020-05-18 15:39:34 +02:00
COPYING
COPYING.LIB
extra-lib.mk
gen-locales.mk
INSTALL x86: Add --enable-cet=permissive 2020-05-18 08:38:53 -07:00
libc-abis libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307] 2018-07-05 18:06:43 +01:00
libof-iterator.mk
LICENSES Prefer https to http for gnu.org and fsf.org URLs 2019-09-07 02:43:31 -07:00
MAINTAINERS
Makeconfig Makeconfig: Use $(error ...) to output error message 2020-04-29 11:24:41 +02:00
Makefile test-container: Support $(complocaledir) and mkdirp. 2020-04-30 16:28:07 -04:00
Makefile.help Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
Makefile.in
Makerules Remove NO_CTORS_DTORS_SECTIONS macro 2020-05-18 15:39:34 +02:00
NEWS Add the __libc_single_threaded variable 2020-07-06 11:15:58 +02:00
o-iterator.mk
README Prefer https to http for gnu.org and fsf.org URLs 2019-09-07 02:43:31 -07:00
Rules Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
shlib-versions
test-skeleton.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
version.h Open master for 2.32 development 2020-02-01 17:22:50 +05:30

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see https://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at https://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see https://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.