mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-23 19:30:10 +00:00
78ca091cdd
The problem for x32 is the {INTERNAL,INLINE}_SYSCALL C macros explicit
cast the arguments to 'long int', thus passing as 32 bits arguments
that should be passed to 64 bits.
Previous x32 implementation uses the auto-generated syscalls from
assembly macros (syscalls.list), so the {INTERNAL,INLINE}_SYSCALL
macros are never used with 64 bit argument in x32 (which are
internally broken for this ILP).
To fix it I used a strategy similar to MIPS64n32 (although both
ABI differs for some syscalls on how top pass 64-bits arguments)
where argument types for kernel call are defined using GCC extension
'typeof' with a arithmetic operation. This allows 64-bits arguments
to be defined while 32-bits argument will still passed as 32-bits.
I also cleanup the {INLINE,INTERNAL}_SYSCALL definition by defining
'inline_syscallX' instead of constructing the argument passing using
macros (it adds some readability) and removed the ununsed
INTERNAL_SYSCALL_NCS_TYPES define (since the patch idea is exactly to
avoid requiric explicit types passing).
Tested on x86_64 and x32.
* sysdeps/unix/sysv/linux/x86_64/sysdep.h
(INTERNAL_SYSCALL_NCS_TYPES): Remove define.
(LOAD_ARGS_0): Likewise.
(LOAD_ARGS_1): Likewise.
(LOAD_ARGS_2): Likewise.
(LOAD_ARGS_3): Likewise.
(LOAD_ARGS_4): Likewise.
(LOAD_ARGS_5): Likewise.
(LOAD_ARGS_6): Likewise.
(LOAD_REGS_0): Likewise.
(LOAD_REGS_1): Likewise.
(LOAD_REGS_2): Likewise.
(LOAD_REGS_3): Likewise.
(LOAD_REGS_4): Likewise.
(LOAD_REGS_5): Likewise.
(LOAD_REGS_6): Likewise.
(ASM_ARGS_0): Likewise.
(ASM_ARGS_1): Likewise.
(ASM_ARGS_2): Likewise.
(ASM_ARGS_3): Likewise.
(ASM_ARGS_4): Likewise.
(ASM_ARGS_5): Likewise.
(ASM_ARGS_6): Likewise.
(LOAD_ARGS_TYPES_1): Likewise.
(LOAD_ARGS_TYPES_2): Likewise.
(LOAD_ARGS_TYPES_3): Likewise.
(LOAD_ARGS_TYPES_4): Likewise.
(LOAD_ARGS_TYPES_5): Likewise.
(LOAD_ARGS_TYPES_6): Likewise.
(LOAD_REGS_TYPES_1): Likewise.
(LOAD_REGS_TYPES_2): Likewise.
(LOAD_REGS_TYPES_3): Likewise.
(LOAD_REGS_TYPES_4): Likewise.
(LOAD_REGS_TYPES_5): Likewise.
(LOAD_REGS_TYPES_6): Likewise.
(TYPEFY): New define.
(ARGIFY): Likewise.
(internal_syscall0): Likewise.
(internal_syscall1): Likewise.
(internal_syscall2): Likewise.
(internal_syscall3): Likewise.
(internal_syscall4): Likewise.
(internal_syscall5): Likewise.
(internal_syscall6): Likewise.
* sysdeps/unix/sysv/linux/x86_64/x32/times.c
(INTERNAL_SYSCALL_NCS): Remove define.
(internal_syscall1): Add define.
|
||
|---|---|---|
| .. | ||
| 64 | ||
| x32 | ||
| ____longjmp_chk.S | ||
| __start_context.S | ||
| arch-fork.h | ||
| brk.c | ||
| cancellation.S | ||
| clone.S | ||
| compat-timer.h | ||
| configure | ||
| configure.ac | ||
| dl-cache.h | ||
| dl-procinfo.c | ||
| dl-procinfo.h | ||
| get_clockfreq.c | ||
| getcontext.S | ||
| Implies | ||
| init-first.c | ||
| ipc_priv.h | ||
| kernel_stat.h | ||
| kernel-features.h | ||
| ldconfig.h | ||
| ldd-rewrite.sed | ||
| libc-cancellation.S | ||
| libc-lowlevellock.S | ||
| libmvec.abilist | ||
| librt-cancellation.S | ||
| lll_timedlock_wait.c | ||
| lll_timedwait_tid.c | ||
| lowlevellock.h | ||
| lowlevellock.S | ||
| makecontext.c | ||
| Makefile | ||
| profil-counter.h | ||
| pthread_setaffinity.c | ||
| readelflib.c | ||
| register-dump.h | ||
| sched_setaffinity.c | ||
| setcontext.S | ||
| sigaction.c | ||
| sigaltstack-offsets.sym | ||
| sigcontextinfo.h | ||
| sigpending.c | ||
| sigprocmask.c | ||
| swapcontext.S | ||
| syscall.S | ||
| syscalls.list | ||
| sysdep-cancel.h | ||
| sysdep.h | ||
| sysdep.S | ||
| timer_create.c | ||
| timer_delete.c | ||
| timer_getoverr.c | ||
| timer_gettime.c | ||
| timer_settime.c | ||
| ucontext_i.sym | ||
| umount.c | ||
| Versions | ||
| vfork.S | ||