AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-22 21:10:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
805334b26c
glibc/sysdeps/posix
History
Adhemerval Zanella 805334b26c posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640) 
Austin Group issue #411 [1] proposes that posix_spawn file action
posix_spawn_file_actions_adddup2 resets the close-on-exec when
source and destination refer to same file descriptor.

It solves the issue on multi-thread applications which uses
close-on-exec as default, and want to hand-chose specifically
file descriptor to purposefully inherited into a child process.
Current approach to achieve this scenario is to use two adddup2 file
actions and a temporary file description which do not conflict with
any other, coupled with a close file action to avoid leaking the
temporary file descriptor.  This approach, besides being complex,
may fail with EMFILE/ENFILE file descriptor exaustion.

This can be more easily accomplished with an in-place removal of
FD_CLOEXEC.  Although the resulting adddup2 semantic is slight
different than dup2 (equal file descriptors should be handled as
no-op), the proposed possible solution are either more complex
(fcntl action which a limited set of operations) or results in
unrequired operations (dup3 which also returns EINVAL for same
file descriptor).

Checked on aarch64-linux-gnu.

	[BZ #23640]
	* posix/tst-spawn.c (do_prepare, handle_restart, do_test): Add
	posix_spawn_file_actions_adddup2 test to check O_CLOCEXEC reset.
	* sysdeps/unix/sysv/linux/spawni.c (__spawni_child): Add
	close-on-exec reset for adddup2 file action.
	* sysdeps/posix/spawni.c (__spawni_child): Likewise.

[1] http://austingroupbugs.net/view.php?id=411
2019-01-03 14:38:01 -02:00
..
alarm.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
clock_getres.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
clock.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
closedir.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ctermid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
cuserid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
dirfd.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
dirstream.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
dl-fileid.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
dup2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
dup.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
euidaccess.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fdopendir.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
flock.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fpathconf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gai_strerror-strs.h * sysdeps/posix/gai_strerror.c: Complete rewrite. Avoid relocations. 2005-12-20 17:53:00 +00:00
gai_strerror.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getaddrinfo.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getcwd.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getdtsz.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gethostname.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getpagesize.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gettimeofday.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
isatty.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
isfdtype.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
killpg.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
libc_fatal.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Makefile NPTL: Refactor named semaphore code to use shm-directory.h 2014-12-12 15:01:30 -08:00
mkfifo.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mkfifoat.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
nice.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
open64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
opendir.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pathconf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pause.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
posix_fallocate64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
posix_fallocate.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pread64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pread.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv64v2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv_common.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
preadv.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
profil.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwrite64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwrite.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev64v2.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev_common.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pwritev.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
raise.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
readdir_r.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
readdir.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
readv.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
remove.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
rename.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
rewinddir.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
seekdir.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
shm_open.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
shm_unlink.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
shm-directory.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
shm-directory.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sigblock.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sigignore.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sigintr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
signal.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sigpause.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sigset.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sigsetmask.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sigsuspend.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sigwait.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sleep.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
spawni.c posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640) 2019-01-03 14:38:01 -02:00
sprofil.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Subdirs Make sysdeps/posix bring in login subdir. 2015-07-23 17:04:22 -07:00
sysconf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
system.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
sysv_signal.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
telldir.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tempname.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
time.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
timespec_get.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
truncate.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ttyname_r.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ttyname.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ulimit.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
usleep.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
utime.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
utimes.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wait3.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wait.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
waitid.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
writev.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00