Go to file
Szabolcs Nagy d2123d6827 elf: Fix slow tls access after dlopen [BZ #19924]
In short: __tls_get_addr checks the global generation counter and if
the current dtv is older then _dl_update_slotinfo updates dtv up to the
generation of the accessed module. So if the global generation is newer
than generation of the module then __tls_get_addr keeps hitting the
slow dtv update path. The dtv update path includes a number of checks
to see if any update is needed and this already causes measurable tls
access slow down after dlopen.

It may be possible to detect up-to-date dtv faster.  But if there are
many modules loaded (> TLS_SLOTINFO_SURPLUS) then this requires at
least walking the slotinfo list.

This patch tries to update the dtv to the global generation instead, so
after a dlopen the tls access slow path is only hit once.  The modules
with larger generation than the accessed one were not necessarily
synchronized before, so additional synchronization is needed.

This patch uses acquire/release synchronization when accessing the
generation counter.

Note: in the x86_64 version of dl-tls.c the generation is only loaded
once, since relaxed mo is not faster than acquire mo load.

I have not benchmarked this. Tested by Adhemerval Zanella on aarch64,
powerpc, sparc, x86 who reported that it fixes the performance issue
of bug 19924.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
2023-09-01 08:21:37 +01:00
argp argp-parse: Get rid of alloca 2023-08-28 16:49:27 +00:00
assert tests: replace fgets by xfgets 2023-06-13 19:59:08 -04:00
benchtests benchtests: fix warn unused result 2023-06-22 00:21:19 -04:00
bits Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
catgets gencat: Get rid of alloca. 2023-08-28 16:42:53 +00:00
ChangeLog.old Create ChangeLog.old/ChangeLog.27 2023-07-30 21:45:27 +02:00
conform wchar: Define va_list for POSIX (BZ #30035) 2023-05-25 16:43:29 -03:00
crypt Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
csu Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
ctype Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
debug chk: Add and fix hidden builtin definitions for *_chk 2023-08-03 22:46:48 +02:00
dirent tests: replace read by xread 2023-06-19 09:14:56 -04:00
dlfcn Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
elf elf: Fix slow tls access after dlopen [BZ #19924] 2023-09-01 08:21:37 +01:00
gmon Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
gnulib Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
grp Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
gshadow Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
hesiod Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
htl htl: move pthread_attr_setdetachstate into libc 2023-08-24 01:57:22 +02:00
hurd hurd: Add prototype for and thus fix _hurdsig_abort_rpcs call 2023-08-15 22:48:44 +02:00
iconv iconv: restore verbosity with unrecognized encoding names (bug 30694) 2023-08-02 13:30:04 +02:00
iconvdata add GB18030-2022 charmap and test the entire GB18030 charmap [BZ #30243] 2023-08-29 19:02:30 +02:00
include nscd: Do not rebuild getaddrinfo (bug 30709) 2023-08-11 10:10:16 +02:00
inet nscd: Do not rebuild getaddrinfo (bug 30709) 2023-08-11 10:10:16 +02:00
intl Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
io io/tst-statvfs: fix statfs().f_type comparison test on some arches 2023-08-15 17:08:23 +02:00
libio hurd: Fix tst-openloc 2023-07-20 23:42:56 +02:00
locale locale/programs/locarchive.c: fix warn unused result 2023-05-24 21:38:46 -04:00
localedata add GB18030-2022 charmap and test the entire GB18030 charmap [BZ #30243] 2023-08-29 19:02:30 +02:00
login unistd: Avoid PLT entries with _FORTIFY_SOURCE 2023-07-05 16:59:48 +02:00
mach Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
malloc malloc: Remove bin scanning from memalign (bug 30723) 2023-08-15 08:07:36 +02:00
manual elf: Check that --list-diagnostics output has the expected syntax 2023-08-25 14:19:16 +02:00
math Stop applying a GCC-specific workaround on clang [BZ #30550] 2023-06-30 19:11:11 -03:00
mathvec Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
misc misc/bits/syslog.h: Clearly separate declaration from definition 2023-07-05 16:59:48 +02:00
nis nis: Fix stringop-truncation warning with -O3 in nis_local_host. 2023-03-02 14:22:54 +01:00
nptl nptl: Unconditionally use a 32-byte rseq area 2023-07-21 16:18:18 +02:00
nptl_db Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
nscd nscd: Skip unusable entries in first pass in prune_cache (bug 30800) 2023-08-29 08:28:38 +02:00
nss Restore lookup of IPv4 mapped addresses in files database (bug 25457) 2023-07-24 13:16:24 +02:00
po translations: update cs, nl, vi 2023-07-27 00:21:13 +02:00
posix tst-*glob*: Do not check d_name size 2023-08-03 22:41:45 +02:00
pwd Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
resolv resolv/nss_dns/dns-host: Get rid of alloca. 2023-08-14 20:50:40 +00:00
resource Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
rt Exclude routines from fortification 2023-07-05 16:59:48 +02:00
scripts Use GMP 6.3.0, MPFR 4.2.1 in build-many-glibcs.py 2023-08-29 14:11:35 +00:00
setjmp chk: Add and fix hidden builtin definitions for *_chk 2023-08-03 22:46:48 +02:00
shadow Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
signal Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
socket Exclude routines from fortification 2023-07-05 16:59:48 +02:00
soft-fp Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
stdio-common fxprintf: Get rid of alloca 2023-08-15 14:28:25 +00:00
stdlib tst-realpath-toolong: return "unsupported" when PATH_MAX is undefined 2023-08-03 22:43:27 +02:00
string string: Fix tester build with fortify enable with gcc < 12 2023-08-18 07:59:55 -05:00
sunrpc sunrpc: Fix netname build with older gcc 2023-07-26 09:45:22 -03:00
support support: Build with exceptions and asynchronous unwind tables [BZ #30587] 2023-07-01 13:29:53 +00:00
sysdeps elf: Fix slow tls access after dlopen [BZ #19924] 2023-09-01 08:21:37 +01:00
sysvipc Fix all the remaining misspellings -- BZ 25337 2023-06-02 01:39:48 +00:00
termios Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
time Add checks for wday, yday and new date formats 2023-06-30 11:25:39 +02:00
timezone Call "CST" a time zone abbreviation, not a name 2023-06-22 13:49:09 -07:00
wcsmbs vfscanf-internal: Remove potentially unbounded allocas 2023-07-06 10:46:46 -03:00
wctype Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
.clang-format Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
.gitattributes Assume __NR_openat is always defined 2016-03-23 23:35:08 +01:00
.gitignore Add *.pyc to .gitignore 2015-05-18 15:26:26 +05:30
abi-tags Remove the bulk of the NaCl port. 2017-05-20 08:09:10 -04:00
aclocal.m4 configure: Use autoconf 2.71 2023-07-17 10:08:10 -04:00
config.h.in LoongArch: Add minuimum binutils required version 2023-08-14 09:47:09 +08:00
config.make.in configure: Remove --enable-all-warnings option 2023-08-01 15:35:25 -03:00
configure configure: Remove --enable-all-warnings option 2023-08-01 15:35:25 -03:00
configure.ac configure: Remove --enable-all-warnings option 2023-08-01 15:35:25 -03:00
CONTRIBUTED-BY Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
COPYING Update to latest versions of GPL-2.0 and LGPL-2.1 2013-09-09 12:52:48 +10:00
COPYING.LIB Update to latest versions of GPL-2.0 and LGPL-2.1 2013-09-09 12:52:48 +10:00
extra-lib.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
gen-locales.mk Improve gen-locales.mk and gen-locale.sh to make test files with @ options work 2018-02-27 17:01:57 +01:00
INSTALL elf: Check that --list-diagnostics output has the expected syntax 2023-08-25 14:19:16 +02:00
libc-abis riscv: support GNU indirect function 2021-01-10 21:25:13 -05:00
libof-iterator.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
LICENSES arc4random: simplify design for better safety 2022-07-27 08:58:27 -03:00
MAINTAINERS Add MAINTAINERS 2017-05-11 13:38:30 -04:00
Makeconfig configure: Add -Wall again to the default CFLAGS 2023-08-15 08:07:50 +02:00
Makefile scripts: Fix fortify checks if compiler does not support _FORTIFY_SOURCE=3 2023-07-20 17:58:26 -03:00
Makefile.help Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
Makefile.in New make target to only build benchmark binaries 2016-04-20 10:23:28 +05:30
Makerules Fix tests-clean Makefile target (bug 30545) 2023-06-26 10:37:25 -03:00
NEWS LoongArch: Add minuimum binutils required version 2023-08-14 09:47:09 +08:00
o-iterator.mk Fri Mar 17 12:58:37 1995 Roland McGrath <roland@churchy.gnu.ai.mit.edu> 1995-03-17 18:42:51 +00:00
README hurd: Enable x86_64 build script 2023-05-02 21:40:36 +02:00
Rules scripts: Fix fortify checks if compiler does not support _FORTIFY_SOURCE=3 2023-07-20 17:58:26 -03:00
SECURITY.md Add a SECURITY.md 2023-05-18 12:07:34 -04:00
SHARED-FILES Mention today's regex merge in SHARED-FILES 2021-09-21 18:00:10 -07:00
shlib-versions nss: Do not mention NSS test modules in <gnu/lib-names.h> 2022-03-11 08:24:04 +01:00
test-skeleton.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
version.h Open master branch for glibc 2.39 development 2023-07-31 20:07:55 +02:00

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu and x86_64-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arc*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	loongarch64-*-linux-gnu Hardware floating point, LE only.
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	or1k-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv32-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see https://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at https://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see https://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.