Go to file
Qixing ksyx Xue dbfc83bdca elf: Add test for locating libraries in root dir (bug 30435)
When dlopen is being called, efforts have been made to improve
future lookup performance. This includes marking a search path
as non-existent using `stat`. However, if the root directory
is given as a search path, there exists a bug which erroneously
marks it as non-existing.

The bug is reproduced under the following sequence:

  1. dlopen is called to open a shared library, with at least:
     1) a dependency 'A.so' not directly under the '/' directory
        (e.g. /lib/A.so), and
     2) another dependency 'B.so' resides in '/'.
  2. for this bug to reproduce, 'A.so' should be searched *before* 'B.so'.
  3. it first tries to find 'A.so' in /, (e.g. /A.so):
     - this will (obviously) fail,
     - since it's the first time we have seen the '/' directory,
       its 'status' is 'unknown'.
  4. `buf[buflen - namelen - 1] = '\0'` is executed:
     - it intends to remove the leaf and its final slash,
     - because of the speciality of '/', its buflen == namelen + 1,
     - it erroneously clears the entire buffer.
  6. it then calls 'stat' with the empty buffer:
     - which will result in an error.
  7. so it marks '/' as 'nonexisting', future lookups will not consider
     this path.
  8. while /B.so *does* exist, failure to look it up in the '/'
     directory leads to a 'cannot open shared object file' error.

This patch fixes the bug by preventing 'buflen', an index to put '\0',
from being set to 0, so that the root '/' is always kept.
Relative search paths are always considered as 'existing' so this
wont be affected.

Writeup by Moody Liu <mooodyhunter@outlook.com>

Suggested-by: Carlos O'Donell <carlos@redhat.com>
Signed-off-by: Qixing ksyx Xue <qixingxue@outlook.com>
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
2023-05-25 11:10:54 -04:00
argp argp: Reformat Makefile. 2023-05-17 08:12:08 -04:00
assert assert: Reformat Makefile. 2023-05-18 12:56:45 -04:00
benchtests benchtests: Reformat Makefile. 2023-05-18 13:11:48 -04:00
bits Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1 2023-04-28 07:02:48 -07:00
catgets catgets: Reformat Makefile. 2023-05-18 13:13:32 -04:00
ChangeLog.old Create ChangeLog.old/ChangeLog.26. 2023-01-31 22:27:45 -05:00
conform hurd: Also XFAIL missing SA_NOCLDWAIT on 64bit 2023-05-01 13:28:53 +02:00
crypt Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
csu elf: Fix GL(dl_phdr) and GL(dl_phnum) for static builds [BZ #29864] 2023-01-12 13:54:34 -03:00
ctype Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
debug debug: Reformat Makefile. 2023-05-16 07:17:19 -04:00
dirent Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
dlfcn Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
elf elf: Add test for locating libraries in root dir (bug 30435) 2023-05-25 11:10:54 -04:00
gmon Use O_CLOEXEC in more places (BZ #15722) 2023-04-22 13:50:14 +02:00
gnulib Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
grp Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
gshadow Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
hesiod Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
htl hurd 64bit: Fix pthread_t/thread_t type to long 2023-05-01 15:05:09 +02:00
hurd Fix build for hurd/thread-self.c for i386. 2023-05-22 09:38:09 +02:00
iconv Use O_CLOEXEC in more places (BZ #15722) 2023-04-22 13:50:14 +02:00
iconvdata Remove --with-default-link configure option 2023-03-27 13:57:55 -03:00
include Mark various cold functions as __COLD 2023-05-01 19:33:21 +02:00
inet rcmd.c: Fix indentation in last commit 2023-04-18 09:47:40 -04:00
intl Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
io io: Re-flow and sort multiline Makefile definitions 2023-05-25 09:59:01 -03:00
libio libio: Add __nonnull for FILE * arguments of fclose and freopen 2023-05-16 06:56:32 -03:00
locale locale/programs/locarchive.c: fix warn unused result 2023-05-24 21:38:46 -04:00
localedata localedata: de_DE should not use Fräulein 2023-02-27 16:54:22 +01:00
login Use O_CLOEXEC in more places (BZ #15722) 2023-04-22 13:50:14 +02:00
mach mach: Fix mach_setup_thread_impl with NULL stack_base 2023-05-22 17:47:53 +00:00
malloc aligned_alloc: conform to C17 2023-05-08 16:40:10 -04:00
manual aligned_alloc: conform to C17 2023-05-08 16:40:10 -04:00
math math: Remove the error handling wrapper from fmod and fmodf 2023-04-03 16:45:27 -03:00
mathvec Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
misc misc: Reformat Makefile. 2023-05-18 12:34:15 -04:00
nis nis: Fix stringop-truncation warning with -O3 in nis_local_host. 2023-03-02 14:22:54 +01:00
nptl nptl: Reformat Makefile. 2023-05-18 12:39:47 -04:00
nptl_db Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
nscd Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
nss nss: Reconcile conditional declaration and use of `is_nscd' 2023-05-16 11:40:10 +02:00
po Update all PO files in preparation for release. 2023-01-31 17:51:40 -05:00
posix posix: Reformat Makefile. 2023-05-19 07:28:55 -04:00
pwd Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
resolv hurd 64bit: Re-introduce gai_suspend symbol 2023-05-19 20:44:12 +02:00
resource Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
rt aio: Fix freeing memory 2023-04-12 00:14:08 +02:00
scripts scripts: sort-makefile-lines.py 2023-05-18 12:33:24 -04:00
setjmp Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
shadow Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions 2023-03-27 13:57:55 -03:00
signal Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
socket socket: Reformat Makefile. 2023-05-16 07:19:31 -04:00
soft-fp Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
stdio-common stdio-common: Adjust tests in Makefile 2023-05-18 12:34:00 -04:00
stdlib Fix special case for C2x strtol binary constant handling (BZ# 30371) 2023-05-25 09:28:23 -03:00
string string: Add tests for strndup (BZ #30266) 2023-04-21 10:50:42 -03:00
sunrpc sunrpc/netname.c: fix warn unused result 2023-05-24 21:52:31 -04:00
support support: Reformat Makefile. 2023-05-23 22:03:41 -04:00
sysdeps sysdeps/pthread/eintr.c: fix warn unused result 2023-05-24 21:52:31 -04:00
sysvipc Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
termios Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
time time: Remove alloca() from getdate 2023-05-05 10:55:48 -04:00
timezone Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
wcsmbs Fix special case for C2x strtol binary constant handling (BZ# 30371) 2023-05-25 09:28:23 -03:00
wctype Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
.clang-format Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
.gitattributes Assume __NR_openat is always defined 2016-03-23 23:35:08 +01:00
.gitignore Add *.pyc to .gitignore 2015-05-18 15:26:26 +05:30
abi-tags Remove the bulk of the NaCl port. 2017-05-20 08:09:10 -04:00
aclocal.m4 configure: Move nm, objdump, and readelf to LIBC_PROG_BINUTILS 2023-01-12 09:05:09 -03:00
config.h.in Stop checking if MiG supports retcode. 2023-05-11 01:28:34 +02:00
config.make.in Remove --enable-tunables configure option 2023-03-29 14:33:06 -03:00
configure Remove --enable-tunables configure option 2023-03-29 14:33:06 -03:00
configure.ac Remove --enable-tunables configure option 2023-03-29 14:33:06 -03:00
CONTRIBUTED-BY Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
COPYING Update to latest versions of GPL-2.0 and LGPL-2.1 2013-09-09 12:52:48 +10:00
COPYING.LIB Update to latest versions of GPL-2.0 and LGPL-2.1 2013-09-09 12:52:48 +10:00
extra-lib.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
gen-locales.mk Improve gen-locales.mk and gen-locale.sh to make test files with @ options work 2018-02-27 17:01:57 +01:00
INSTALL Enable libmvec support for AArch64 2023-05-03 12:09:49 +01:00
libc-abis riscv: support GNU indirect function 2021-01-10 21:25:13 -05:00
libof-iterator.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
LICENSES arc4random: simplify design for better safety 2022-07-27 08:58:27 -03:00
MAINTAINERS Add MAINTAINERS 2017-05-11 13:38:30 -04:00
Makeconfig Remove --enable-tunables configure option 2023-03-29 14:33:06 -03:00
Makefile Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
Makefile.help Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
Makefile.in New make target to only build benchmark binaries 2016-04-20 10:23:28 +05:30
Makerules Remove --with-default-link configure option 2023-03-27 13:57:55 -03:00
NEWS Enable libmvec support for AArch64 2023-05-03 12:09:49 +01:00
o-iterator.mk Fri Mar 17 12:58:37 1995 Roland McGrath <roland@churchy.gnu.ai.mit.edu> 1995-03-17 18:42:51 +00:00
README hurd: Enable x86_64 build script 2023-05-02 21:40:36 +02:00
Rules libio: Do not autogenerate stdio_lim.h 2023-03-27 13:57:55 -03:00
SECURITY.md Add a SECURITY.md 2023-05-18 12:07:34 -04:00
SHARED-FILES Mention today's regex merge in SHARED-FILES 2021-09-21 18:00:10 -07:00
shlib-versions nss: Do not mention NSS test modules in <gnu/lib-names.h> 2022-03-11 08:24:04 +01:00
test-skeleton.c Update copyright dates with scripts/update-copyrights 2023-01-06 21:14:39 +00:00
version.h Open master branch for glibc 2.38 development 2023-01-31 22:39:21 -05:00

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu and x86_64-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arc*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	loongarch64-*-linux-gnu Hardware floating point, LE only.
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	or1k-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv32-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see https://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at https://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see https://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.