Go to file
Joseph Myers e6ae5b25cd Fix memmove call in vfprintf-internal.c:group_number
A recent GCC mainline change introduces errors of the form:

vfprintf-internal.c: In function 'group_number':
vfprintf-internal.c:2093:15: error: 'memmove' specified bound between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
 2093 |               memmove (w, s, (front_ptr -s) * sizeof (CHAR_T));
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is a genuine bug in the glibc code: s > front_ptr is always true
at this point in the code, and the intent is clearly for the
subtraction to be the other way round.  The other arguments to the
memmove call here also appear to be wrong; w and s point just *after*
the destination and source for copying the rest of the number, so the
size needs to be subtracted to get appropriate pointers for the
copying.  Adjust the memmove call to conform to the apparent intent of
the code, so fixing the -Wstringop-overflow error.

Now, if the original code were ever executed, a buffer overrun would
result.  However, I believe this code (introduced in commit
edc1686af0, "vfprintf: Reuse work_buffer
in group_number", so in glibc 2.26) is unreachable in prior glibc
releases (so there is no need for a bug in Bugzilla, no need to
consider any backports unless someone wants to build older glibc
releases with GCC 12 and no possibility of this buffer overrun
resulting in a security issue).

work_buffer is 1000 bytes / 250 wide characters.  This case is only
reachable if an initial part of the number, plus a grouped copy of the
rest of the number, fail to fit in that space; that is, if the grouped
number fails to fit in the space.  In the wide character case,
grouping is always one wide character, so even with a locale (of which
there aren't any in glibc) grouping every digit, a number would need
to occupy at least 125 wide characters to overflow, and a 64-bit
integer occupies at most 23 characters in octal including a leading 0.
In the narrow character case, the multibyte encoding of the grouping
separator would need to be at least 42 bytes to overflow, again
supposing grouping every digit, but MB_LEN_MAX is 16.  So even if we
admit the case of artificially constructed locales not shipped with
glibc, given that such a locale would need to use one of the character
sets supported by glibc, this code cannot be reached at present.  (And
POSIX only actually specifies the ' flag for grouping for decimal
output, though glibc acts on it for other bases as well.)

With binary output (if you consider use of grouping there to be
valid), you'd need a 15-byte multibyte character for overflow; I don't
know if any supported character set has such a character (if, again,
we admit constructed locales using grouping every digit and a grouping
separator chosen to have a multibyte encoding as long as possible, as
well as accepting use of grouping with binary), but given that we have
this code at all (clearly it's not *correct*, or in accordance with
the principle of avoiding arbitrary limits, to skip grouping on
running out of internal space like that), I don't think it should need
any further changes for binary printf support to go in.

On the other hand, support for large sizes of _BitInt in printf (see
the N2858 proposal) *would* require something to be done about such
arbitrary limits (presumably using dynamic allocation in printf again,
for sufficiently large _BitInt arguments only - currently only
floating-point uses dynamic allocation, and, as previously discussed,
that could actually be replaced by bounded allocation given smarter
code).

Tested with build-many-glibcs.py for aarch64-linux-gnu (GCC mainline).
Also tested natively for x86_64.

(cherry picked from commit db6c4935fa)
2022-08-30 10:09:58 +02:00
argp Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
assert Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
benchtests Run bench-timing-type with newly built libc. 2020-01-20 11:29:41 +00:00
bits Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
catgets Update copyright dates not handled by scripts/update-copyrights. 2020-01-01 00:21:22 +00:00
ChangeLog.old Generate ChangeLog.old/ChangeLog.20 for 2.31 2020-02-01 17:22:50 +05:30
conform Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
crypt Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
csu elf: Move vDSO setup to rtld (BZ#24967) 2020-01-03 11:22:07 -03:00
ctype Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
debug mips: Fix bracktrace result for signal frames 2020-03-30 23:18:26 +02:00
dirent Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
dlfcn Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
elf Fix SXID_ERASE behavior in setuid programs (BZ #27471) 2021-04-14 10:50:14 +05:30
gmon Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gnulib Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
grp Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
gshadow Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
hesiod Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
htl htl: Add internal version of __pthread_mutex_timedlock 2020-01-13 20:41:07 +01:00
hurd Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
iconv iconv: Fix incorrect UCS4 inner loop bounds (BZ#26923) 2021-01-03 13:20:30 +01:00
iconvdata gconv: Do not emit spurious NUL character in ISO-2022-JP-3 (bug 28524) 2021-12-05 12:04:05 +01:00
include <shlib-compat.h>: Support compat_symbol_reference for _ISOMAC 2022-01-18 11:16:50 +01:00
inet Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
intl intl: Handle translation output codesets with suffixes [BZ #26383] 2020-10-10 14:51:27 +02:00
io Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
libio Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
locale Fix locale/tst-locale-locpath cross-testing when sshd sets LANG. 2020-01-24 17:23:07 +00:00
localedata oc_FR locale: Fix spelling of April (bug 25639) 2020-05-09 17:07:24 +02:00
login Update copyright dates not handled by scripts/update-copyrights. 2020-01-01 00:21:22 +00:00
mach Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
malloc tests-mcheck: New variable to run tests with MALLOC_CHECK_=3 2020-12-24 11:20:34 +05:30
manual Linux: Require properly configured /dev/pts for PTYs 2022-08-18 12:28:36 +02:00
math Fix build with GCC 10 when long double = double. 2020-05-05 14:58:16 +01:00
mathvec Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
misc Revert "Fix __minimal_malloc segfaults in __mmap due to stack-protector" 2021-12-16 15:18:31 +01:00
nis Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
nptl nptl: Zero-extend arguments to SETXID syscalls [BZ #26248] 2020-07-29 23:18:33 +02:00
nptl_db Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
nscd nscd: Fix double free in netgroupcache [BZ #27462] 2021-03-08 15:41:29 +05:30
nss Disable warnings due to deprecated libselinux symbols used by nss and nscd 2020-07-29 20:33:35 +02:00
po Add Portuguese (Portugal) translation 2020-02-01 17:16:54 +05:30
posix wordexp: handle overflow in positional parameter number (bug 28011) 2021-07-06 21:04:26 +02:00
pwd Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
resolv Get rid of Werror=maybe-uninitialized in res_send.c. 2020-01-20 10:57:08 +01:00
resource Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
rt Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
scripts gitlog-to-changelog: Drop scripts in favour of gnulib version 2020-01-23 20:00:13 +05:30
setjmp Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
shadow Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
signal Build raise with -fasynchronous-unwind-tables. 2020-01-24 17:23:47 +00:00
socket socket: Add the __sockaddr_un_set function 2022-01-18 08:24:42 +01:00
soft-fp Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
stdio-common Fix memmove call in vfprintf-internal.c:group_number 2022-08-30 10:09:58 +02:00
stdlib support: Add capability to fork an sgid child 2021-04-14 10:48:13 +05:30
string string: Add a testcase for wcsncmp with SIZE_MAX [BZ #28755] 2022-02-17 11:33:07 -08:00
sunrpc CVE-2022-23218: Buffer overflow in sunrpc svcunix_create (bug 28768) 2022-01-18 11:17:44 +01:00
support support: Add helpers to create paths longer than PATH_MAX 2022-08-18 00:14:28 +02:00
sysdeps Linux: Require properly configured /dev/pts for PTYs 2022-08-18 12:28:36 +02:00
sysvipc Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
termios Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
time Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
timezone Update timezone/README 2020-01-09 23:00:25 -08:00
wcsmbs Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
wctype Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
.gitattributes Assume __NR_openat is always defined 2016-03-23 23:35:08 +01:00
.gitignore Add *.pyc to .gitignore 2015-05-18 15:26:26 +05:30
abi-tags Remove the bulk of the NaCl port. 2017-05-20 08:09:10 -04:00
aclocal.m4 LIBC_SLIBDIR_RTLDDIR: substitute arguments in single quotes 2018-01-25 17:20:28 +01:00
config.h.in sparc: Assume GOTDATA support in the toolchain 2019-10-09 19:15:33 +02:00
config.make.in Make --bindir effective 2019-05-14 11:04:33 -03:00
configure Improve IFUNC check [BZ #25506] 2020-03-08 13:44:12 +01:00
configure.ac Improve IFUNC check [BZ #25506] 2020-03-08 13:44:12 +01:00
COPYING
COPYING.LIB
extra-lib.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
gen-locales.mk Improve gen-locales.mk and gen-locale.sh to make test files with @ options work 2018-02-27 17:01:57 +01:00
INSTALL Linux: Require properly configured /dev/pts for PTYs 2022-08-18 12:28:36 +02:00
libc-abis libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307] 2018-07-05 18:06:43 +01:00
libof-iterator.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
LICENSES Prefer https to http for gnu.org and fsf.org URLs 2019-09-07 02:43:31 -07:00
MAINTAINERS Add MAINTAINERS 2017-05-11 13:38:30 -04:00
Makeconfig Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
Makefile Drop dependency of dist target on ChangeLog 2020-01-09 13:28:08 +05:30
Makefile.help Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
Makefile.in New make target to only build benchmark binaries 2016-04-20 10:23:28 +05:30
Makerules Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
NEWS Remove most vfprintf width/precision-dependent allocations (bug 14231, bug 26211). 2022-08-30 10:09:13 +02:00
o-iterator.mk
README Prefer https to http for gnu.org and fsf.org URLs 2019-09-07 02:43:31 -07:00
Rules tests-mcheck: New variable to run tests with MALLOC_CHECK_=3 2020-12-24 11:20:34 +05:30
shlib-versions Extend NSS test suite 2017-07-17 15:52:44 -04:00
test-skeleton.c Update copyright dates with scripts/update-copyrights. 2020-01-01 00:14:33 +00:00
version.h Update version numbers for 2.31 release 2020-02-01 17:16:54 +05:30

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see https://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at https://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see https://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.