Commit Graph

3951 Commits

Author SHA1 Message Date
Alan Baker
157fe5f8fb Update test expectations 2020-08-12 09:04:56 -04:00
Alan Baker
fe1168750e Update SPIRV-Tools and SPIRV-Headers known good 2020-08-12 09:04:24 -04:00
johnkslang
b60e067b43 SPV: Fix #1829: don't emit OpModuleProcessed use-storage-buffer 2020-08-06 01:34:14 -06:00
John Kessenich
695e1de831
Merge pull request #2365 from KhronosGroup/update-gtests
Build/Test: Dropping VS 2013 allows using the latest googletests
2020-08-05 11:45:39 -06:00
johnkslang
23f3bdfea1 Build/Test: Dropping 2013 allows using the latest googletests.
These have a new spelling: INSTANTIATE_TEST_CASE_P -> INSTANTIATE_TEST_SUITE_P
2020-08-05 11:07:07 -06:00
johnkslang
2de6d657dd SPV: Standalone; sanity check the client GLSL input semantics option value. 2020-08-04 07:17:39 -06:00
johnkslang
a1a497ffe7 SPV: Use more correct SPV-Tools environment, partially addressing #2290 2020-08-04 03:00:32 -06:00
johnkslang
f881f08358 SPV: Fix #2363: include trailing newline named text SPV output. 2020-08-04 02:13:50 -06:00
John Kessenich
5743eed4d1
Merge pull request #2362 from ShabbyX/optimize_for_angle
Use GLSLANG_ANGLE to strip features to what ANGLE requires
2020-08-03 01:28:52 -06:00
John Kessenich
928b7b26bd
Merge pull request #2361 from ben-clayton/revert-thread-local
Revert changes that migrate to `thread_local`.
2020-08-03 00:12:02 -06:00
Shahbaz Youssefi
1ef2e250fc
Use GLSLANG_ANGLE to strip features to what ANGLE requires
This change strips a few features similar to GLSLANG_WEB but doesn't
remove every detail like the latter.  It also hardcodes profile/version
to core/450.

In particular, TBuiltIns::initialize is specialized to remove most of
what is not supported or won't be supported by ANGLE.  The result of
this function is parsed with TParseContext::parseShaderStrings which is
a performance bottleneck.

This change shaves about 300KB off of ANGLE's binary size and reduces
the cost of SetupBuiltinSymbolTable to nearly a sixth.

Signed-off-by: Shahbaz Youssefi <ShabbyX@gmail.com>
2020-07-31 12:44:49 -04:00
Ben Clayton
2a44064885 Revert changes that migrate to thread_local.
iOS 8 does not support `thread_local`, which is still in use.
Another approach will have to be found.

This change is a revert of the following changes:

a3845240 - "Simplify PoolAlloc with use of thread_local."
abf92c80 - "Deprecate InitializeDll functions"
33585c87 - "Limit visibility of symbols for internal libraries"

Issue: #2346
2020-07-31 07:13:24 +01:00
John Kessenich
7ab4564696
Merge pull request #2359 from dneto0/fix-warn
Avoid spurious warning about uninit var
2020-07-28 08:39:26 -06:00
David Neto
01f2de512a Avoid spurious warning about uninit var 2020-07-27 15:33:56 -04:00
John Kessenich
3ee5f2f1d3
Merge pull request #2356 from greg-lunarg/kg112
Update spirv-tools known-good to most recent stable
2020-07-23 08:51:27 +07:00
Greg Fischer
8b96a01a6a Update spirv-tools known-good to most recent stable 2020-07-22 15:10:04 -06:00
John Kessenich
7923b3e3d9
Merge pull request #2353 from vkushwaha-nv/SPV_EXT_shader_atomic_float
Add changes for SPV_EXT_shader_atomic_float_add
2020-07-22 22:06:01 +07:00
Vikram Kushwaha
79b93923d2 Add changes for SPV_EXT_shader_atomic_float_add 2020-07-22 05:52:22 -07:00
John Kessenich
9165cbb4f4
Merge pull request #2354 from ben-clayton/limit-visibility
Limit visibility of symbols for internal libraries
2020-07-22 17:46:44 +07:00
Ben Clayton
33585c871d Limit visibility of symbols for internal libraries
Also remove `SPIRV/doc.cpp` from the `SPVRemapper` target as this
is part of `SPIRV`, causing ODR violations. Instead have
`SPVRemapper` link against `SPIRV`.

Fixes ODR violations.
2020-07-22 10:53:50 +01:00
John Kessenich
11fa4d0d56
Merge pull request #2348 from ben-clayton/thread-local
Simplify PoolAlloc by using `thread_local`
2020-07-22 11:47:06 +07:00
John Kessenich
1c42d4ee7b
Merge pull request #2345 from mbechard/master
also search global sequences for live variables
2020-07-22 11:15:24 +07:00
johnkslang
c63502cf67 SPV: Update to the latest SPIR-V headers. 2020-07-21 21:05:25 -06:00
Ben Clayton
abf92c80b9 Deprecate InitializeDll functions
These were only used for TThreadPool, which now uses `thread_local`.
2020-07-21 09:40:34 +01:00
Ben Clayton
a3845240ae Simplify PoolAlloc with use of thread_local.
glslang is using C++ 11, which has first class support for variables of the `thread_local` storage class.

By dropping the use of the `OS_[GS]etTLSValue`, we can simplify the logic, and have it support a thread-local default allocator if none is provided.

Issue: #2346
2020-07-21 09:40:34 +01:00
John Kessenich
b99a6a7273
Merge pull request #2352 from ben-clayton/vs2015
Finalize glslang 10.15.3847, start glslang 11, drop support for VS2013
2020-07-21 10:55:12 +07:00
Malcolm Bechard
5727fb313e also search global variables assignment for live variables
when traversing the AST to find live UBOs etc, also traverse
references to global module-level variables, incase they are
being filled in from UBOs etc.
2020-07-20 18:43:00 -04:00
Ben Clayton
c487d0feaa Drop support for VS2013
This was scheduled for today - 20th July 2020.

Updates Appveyor configs to use VS2015 instead.
2020-07-20 18:50:06 +01:00
Ben Clayton
70860c284e Start glslang 11.0.0 2020-07-20 16:39:42 +01:00
Ben Clayton
6c7beeafa7 Finalize glslang 10.15.3847 2020-07-20 16:39:42 +01:00
Ben Clayton
4268914774 build_info: Fix parsing of versions with no flavor 2020-07-20 16:39:42 +01:00
John Kessenich
9eef54b251
Merge pull request #2351 from ben-clayton/license-checker-cfg
Update license-checker.cfg with simplified rules
2020-07-18 16:30:04 +07:00
Ben Clayton
047425a4db Update license-checker.cfg with simplified rules
`license-checker` has been updated to support `**` wildcards simplifying the ruless, and multiple license configs.

Add a new config for the bison generated files to ensure their licenses don't change.
2020-07-17 20:08:05 +01:00
John Kessenich
ae08b5b74c
Merge pull request #2350 from ben-clayton/update-license-checker-rules
Add new rules for update of license-checker
2020-07-17 20:33:14 +07:00
Ben Clayton
5a7a7dbd1e Add new rules for update of license-checker
`license-checker` will be updated to support `**` based wildcards. As part of this, `license-checker` will now traverse into subdirectories that would previously be excluded when the parent directory is excluded.

This change adds new rules that work with both the old version and new, to ease migration.
2020-07-17 11:59:26 +01:00
John Kessenich
f3cb189697
Merge pull request #2349 from KhronosGroup/return-precision
GLSL/SPV: Propagaet precision qualifier from function to return value.
2020-07-16 14:36:51 +07:00
John Kessenich
3d2391fb25 GLSL/SPV: Propagaet precision qualifier from function to return value.
When a return value's type has no precision qualification (e.g., the return
expression is formed from a constructor), and the formal function return type
has a precision qualification, back propagate that from the return type to the
type of the return value's expression.
2020-07-15 23:38:47 -06:00
John Kessenich
4f72970ed3
Merge pull request #2347 from ben-clayton/runtests
runtests: Check error codes, set LD_LIBRARY_PATH
2020-07-16 09:45:50 +07:00
Ben Clayton
f429b72298 runtests: Check error codes, set LD_LIBRARY_PATH
`glslangValidator` will only return [the codes 0..6](b481744aea/StandAlone/StandAlone.cpp (L117-L125)). Fail the test if anything else is returned (like due to the exe crashing).

Also set `LD_LIBRARY_PATH` to contain the `lib` directory before calling glslang.
2020-07-15 11:59:44 +01:00
John Kessenich
b481744aea
Merge pull request #2335 from ben-clayton/kokoro-bazel-test-output
Kokoro: Print test output to stdout
2020-07-14 16:11:43 +07:00
John Kessenich
39b8de1e99
Merge pull request #2344 from ben-clayton/build_info-x
Give build_info.py the executable bit
2020-07-14 16:11:04 +07:00
Ben Clayton
89a5ee09d5 Give build_info.py the executable bit 2020-07-14 10:09:51 +01:00
John Kessenich
3ea2c8fc72
Merge pull request #2343 from KhronosGroup/fix-non-determinism
Fix recently found non-determinism with gl_WorldToObject3x4EXT.
2020-07-14 15:13:22 +07:00
John Kessenich
f80ef74c80 Fix recently found non-determinism with gl_WorldToObject3x4EXT. 2020-07-14 01:44:35 -06:00
John Kessenich
3aa4431460
Merge pull request #2339 from ben-clayton/cmake-project
CMake: Move project() to top of CMakeLists.txt
2020-07-14 14:12:15 +07:00
John Kessenich
7bedc52abb
Merge pull request #2341 from ben-clayton/bison-license
Add bison license to LICENSE.txt
2020-07-14 14:07:21 +07:00
John Kessenich
fe24a54808 Non-determinism: Remove test file that seems to trigger non-determinism.
This problem needs to be fixed, but in parallel, we need to see master
and any other changes to it passing all tests.

The removed test is ray-tracing centric, and may indicate non-determinism
in recent code added for that functionality.
2020-07-14 00:32:25 -06:00
Ben Clayton
14a2cfbc72 Add bison license to LICENSE.txt 2020-07-13 20:32:09 +01:00
Ben Clayton
6b20d83c41 CMake: Move project() to top of CMakeLists.txt
Also remove `NOTICE` from message() about PCHs - it seems to print this in the actual message, contrary to the documentation where it is used as a severity.
2020-07-13 19:14:02 +01:00
Ben Clayton
16ef2588ed Kokoro: Print test output to stdout 2020-07-13 16:20:06 +01:00