Arcady Goldmints-Orlov
606209e07d
Use [[fallthrough]] attribute instead of comments.
...
Now that we require C++17, the [[fallthrough]] attribute is available as
an alternative to load-bearing comments.
2024-02-20 19:12:06 -05:00
Chris Djali
8ca24e7cf1
Remove implicit fallthrough ( #3518 )
...
This is intended so that downstream projects consuming glslang with FetchContent or similar means can use `-Wimplicit-fallthrough` without getting warning spam.
I've used my best judgement to determine whether the implicit fallthrough was desired, or was simply unreachable code.
`std::unreachable` is unavailable until C++23, but I saw places where `default: assert(0);` was used, so copied that.
There were a few places where some code might actually have been reachable and intended to return a value that represented an error, so someone should double check that kind of thing.
2024-02-19 17:45:45 -05:00
dependabot[bot]
339552c5c3
Bump github/codeql-action from 3.24.0 to 3.24.3
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.0 to 3.24.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...379614612a
2024-02-19 17:24:26 -05:00
AnyOldName3
b8421d7fcc
Quote paths in runtest
...
This means it won't die if the build path contains spaces.
2024-02-19 14:29:42 -05:00
AnyOldName3
fb23503f12
-Wmissing-field-initializers fixes
...
Like with the last few PRs from me, it fixes a warning that's commonly enabled in downstream projects that might want to consume glslang via FetchContent or equivalent.
It doesn't actually enable the warning, but that might be desirable.
I think I found a bug in the Spv.FromFile.cpp tests that would have been prevented had this warning been enabled all along.
I had to guess the value for the missing field, so went for the most common one in the list.
The only test case that used a different value before had an RWTexture1D, so if baseImageBinding is meaning the same kind of image as image load store in OpenGL, it would make sense that that would be the only one to need a non-zero value for the binding.
I'm a little concerned that the test wasn't previously failing with the incorrectly-assigned fields as it implies they don't make any difference, so the test might be too permissive.
2024-02-19 12:20:43 -05:00
Chris Djali
6340ba901a
Document that the only supported dependency commits are the ones in known_good.json
2024-02-19 11:26:07 -05:00
Bjorn
d84255296c
Clear spirv vector before generating spirv output
...
This makes spir-v generation idempotent.
2024-02-14 19:44:34 -05:00
Sajjad Mirza
7a2a1623d8
Emit debug info for accelerationStructure and rayQuery variables. ( #3502 )
...
* Add debug info for accelerationStructure and rayQuery variables.
* Add test case for accelerationStructure and rayQuery
2024-02-14 19:43:02 -05:00
Jeff Bolz
114dae9114
Add a string 'StartsWith' helper function
2024-02-14 18:55:55 -05:00
Jeff Bolz
48702616ec
NV_shader_atomic_fp16_vector
2024-02-14 18:55:55 -05:00
Sven van Haastregt
9fd0fcd737
Add GL_EXT_expect_assume support
...
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
2024-02-13 16:13:35 -08:00
David Neto
b4a6efcda2
Allow external control of whether Glslang will be tested or installed
...
Expose GLSLANG__TESTS and GLSLANG_ENABLE_INSTALL as options
that can be controlled from an enclosing project, or from the
command line.
They retain the prior default behaviour. In particular, if Glslang
is not the top level project, then they default to OFF.
Fixes : #3507
2024-02-13 15:35:02 -08:00
dependabot[bot]
47a02a987c
Bump actions/upload-artifact from 4.3.0 to 4.3.1
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](26f96dfa69...5d5d22a312
2024-02-12 09:06:53 -08:00
dependabot[bot]
43dd32396f
Bump lukka/get-cmake from 3.28.2 to 3.28.3
...
Bumps [lukka/get-cmake](https://github.com/lukka/get-cmake ) from 3.28.2 to 3.28.3.
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](23a189c2ed...139aae9631
2024-02-12 09:05:58 -08:00
Qingyuan Zheng
30661abd9c
Clean up the debug line info tracking and generation.
...
- Correctly populate the field `currentFileId` with the presence of include directive
- Support lazy OpLine/OpDebugLine generation only when a real instruction is added instead of a debug location is set
- Improve the debug location tracking to per-block instead of just per-builder
- A few bug fixes related to debug source info
2024-02-09 10:27:40 -08:00
Sven van Haastregt
b1f7affe94
Add GL_KHR_shader_subgroup_rotate support
...
Co-authored-by: Neil Hickey <neil.hickey@arm.com>
Co-authored-by: Stuart Brady <stuart.brady@arm.com>
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
2024-02-06 11:04:16 -08:00
dependabot[bot]
8c3dbb3596
Bump github/codeql-action from 3.23.2 to 3.24.0
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.23.2 to 3.24.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b7bf0a3ed3...e8893c57a1
2024-02-05 12:28:39 -05:00
dependabot[bot]
ff49bc4c83
Bump lukka/get-cmake from 3.28.1 to 3.28.2
...
Bumps [lukka/get-cmake](https://github.com/lukka/get-cmake ) from 3.28.1 to 3.28.2.
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](2654d8ee38...23a189c2ed
2024-02-05 12:28:17 -05:00
Alexandre Bouvier
82e0d00b32
cmake: add missing SPIRV-Tools-opt dependency
2024-02-02 17:52:16 -05:00
dependabot[bot]
9aaba37665
Bump github/codeql-action from 3.23.1 to 3.23.2
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.23.1 to 3.23.2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](0b21cf2492...b7bf0a3ed3
2024-01-30 17:40:17 -05:00
dependabot[bot]
9679a505df
Bump hendrikmuhs/ccache-action from 1.2.11 to 1.2.12
...
Bumps [hendrikmuhs/ccache-action](https://github.com/hendrikmuhs/ccache-action ) from 1.2.11 to 1.2.12.
- [Release notes](https://github.com/hendrikmuhs/ccache-action/releases )
- [Commits](2a51777f6f...faf867a11c
2024-01-30 17:39:52 -05:00
dependabot[bot]
343b9761d3
Bump actions/upload-artifact from 4.2.0 to 4.3.0
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](694cdabd8b...26f96dfa69
2024-01-30 17:39:26 -05:00
laddoc
fc3bbbb0ff
Update test output typo.
2024-01-30 16:28:38 -05:00
laddoc
2ed435cb58
Update dependent repo's commits points.
2024-01-30 16:28:38 -05:00
laddoc
457fc12b54
Fix build issue.
2024-01-30 16:28:38 -05:00
laddoc
ee62f72137
Fix build issue.
2024-01-30 16:28:38 -05:00
laddoc
725017a588
Support extension EXT_shader_quad_control
2024-01-30 16:28:38 -05:00
Younggwan Kim
f6f9840eab
SPV: Complete OpAssumeTrueKHR, OpExpectKHR
2024-01-26 14:21:54 -05:00
Jeff Bolz
79536da264
Fix 'maximally_reconverges' token to match the GLSL spec
2024-01-25 19:30:47 -05:00
Jeff Bolz
8066fa086b
Implement GL_EXT_maximal_reconvergence
2024-01-25 13:46:25 -05:00
dependabot[bot]
7eea61b5a3
Bump github/codeql-action from 3.23.0 to 3.23.1
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.23.0 to 3.23.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e5f05b81d5...0b21cf2492
2024-01-23 19:04:31 -05:00
dependabot[bot]
043446f949
Bump actions/upload-artifact from 4.1.0 to 4.2.0
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](1eb3cb2b3e...694cdabd8b
2024-01-23 19:03:40 -05:00
dependabot[bot]
866462f8e4
Bump mymindstorm/setup-emsdk from 13 to 14
...
Bumps [mymindstorm/setup-emsdk](https://github.com/mymindstorm/setup-emsdk ) from 13 to 14.
- [Release notes](https://github.com/mymindstorm/setup-emsdk/releases )
- [Commits](d233ac12b0...6ab9eb1bda
2024-01-23 19:02:59 -05:00
Arcady Goldmints-Orlov
57d86ab763
cmake: remove generation of deprecated *Targets.cmake files
...
These files have had a deprecation notice for a few years now and the
cmake find_package mechanism should be used instead.
2024-01-17 16:43:13 -05:00
dependabot[bot]
0f7d3a0776
Bump actions/upload-artifact from 4.0.0 to 4.1.0
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](c7d193f32e...1eb3cb2b3e
2024-01-16 17:03:17 -05:00
dependabot[bot]
adfeb67bac
Bump github/codeql-action from 3.22.12 to 3.23.0
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.22.12 to 3.23.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](012739e508...e5f05b81d5
2024-01-16 17:02:53 -05:00
dependabot[bot]
1952e63d43
Bump hendrikmuhs/ccache-action from 1.2.10 to 1.2.11
...
Bumps [hendrikmuhs/ccache-action](https://github.com/hendrikmuhs/ccache-action ) from 1.2.10 to 1.2.11.
- [Release notes](https://github.com/hendrikmuhs/ccache-action/releases )
- [Commits](6d1841ec15...2a51777f6f
2024-01-08 18:20:11 -05:00
jimihem
db4d6f85af
The array size of gl_SampleMask and gl_SampleMaskIn is ceil(gl_MaxSamples/32)
...
Oes spec says:
For the both the input array gl_SampleMaskIn[] and the output array gl_SampleMask[], bit B of mask M
(gl_SampleMaskIn[M] or gl_SampleMask[M]) corresponds to sample 32*M+B. These arrays have
ceil(gl_MaxSamples/32) elements, where gl_MaxSamples is the maximum number of color samples
supported by the implementation.
But glslang report error "array must have size before use length".
layout(location = 0) out mediump vec4 fragColor;
void main (void)
{
for (int i = 0; i < gl_SampleMask.length(); ++i)
gl_SampleMask[i] = int(0xAAAAAAAA);
fragColor = vec4(0.0, 1.0, 0.0, 1.0);
}
* Add two test items, one is for gl_MaxSapmles = 32 and the other one is for gl_MaxSapmles = 64.
2023-12-29 16:23:16 -05:00
jimihem
88c5373ee4
support GL_ARB_texture_multisample extension.
...
This extension allows the use of "texelFetch" and "textureSize" with 2DMS sampler.
2023-12-28 18:38:39 -05:00
Sajjad Mirza
e17ecb0e80
Emit DebugTypePointer when non-semantic debug info is enabled
2023-12-28 11:00:37 -05:00
dependabot[bot]
89824a83b7
Bump github/codeql-action from 3.22.11 to 3.22.12
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.22.11 to 3.22.12.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b374143c11...012739e508
2023-12-26 16:43:57 -05:00
Nathaniel Cesario
809fd43ed6
Fix MinGW build
2023-12-24 00:55:17 -07:00
Nathaniel Cesario
0ae8960087
Use C++ containers for builtin versioning
...
Removes some of the pointers/"end markes" used in the BuiltInFuntion
versioning, replacing them with std::arrays and spans.
NOTE: The span class used is a copy of the span class that has been in
use in the Vulkan-ValidationLayers as a temporary solution until C++20
is available.
NOTE: The std::arrays could be constexprs, but this requires some extra
work pre-C++20, and is therefore not included in this change, but could
be done in a follow up PR.
2023-12-22 14:19:22 -05:00
Jeremy Hayes
a91631b260
Update CHANGES for release 14.0.0
2023-12-22 12:11:28 -05:00
Jeremy Hayes
abb79089a8
Update known_good.json
2023-12-20 20:52:38 -05:00
dependabot[bot]
c155f881ee
Bump github/codeql-action from 2.22.9 to 3.22.11
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.22.9 to 3.22.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](c0d1daa7f7...b374143c11
2023-12-18 12:17:27 -07:00
dependabot[bot]
89477a5db0
Bump actions/upload-artifact from 3.1.3 to 4.0.0
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 3.1.3 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](a8a3f3ad30...c7d193f32e
2023-12-18 12:16:57 -07:00
dependabot[bot]
ffb1b07d30
Bump lukka/get-cmake from 3.28.0 to 3.28.1
...
Bumps [lukka/get-cmake](https://github.com/lukka/get-cmake ) from 3.28.0 to 3.28.1.
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](98fde40bf9...2654d8ee38
2023-12-18 10:58:57 -07:00
Nathaniel Cesario
5ad3d41364
Output 8 and 16 bit capabilities OpSpecConstantOp
...
OpSpecConstants with 8 or 16 width types require the corresponding
capabilities.
Fixes #3449 .
2023-12-15 18:36:00 -05:00
Herman Semenov
db933d7743
Fixed check uint64 before set bool
2023-12-14 16:27:44 -05:00
