Commit Graph

10153 Commits

Author SHA1 Message Date
Matthias Clasen
2855f81636 Fixes
svn path=/trunk/; revision=20197
2008-05-27 23:02:02 +00:00
Matthias Clasen
8d5e58b632 106574 - Inconsistent increment behavior for gtkspinbutton
* gtk/gtkspinbutton.c (gtk_spin_button_real_value_change):
        Commit the entry text before doing an increment. Patch by
        Björn Lindqvist.


svn path=/trunk/; revision=20196
2008-05-27 22:50:49 +00:00
Federico Mena Quintero
4b1bba8af1 bgo533891 - disallow DnD from the file list into itself
2008-05-27  Federico Mena Quintero  <federico@novell.com>

	http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow
	drag and drop from the file list into itself, as it doesn't make
	sense (it would just change the current folder).

	* gtk/gtkfilechooserdefault.c (file_list_dest_targets): Use
	GTK_TARGET_OTHER_WIDGET so we don't DnD from the file list into
	itself.

Signed-off-by: Federico Mena Quintero <federico@novell.com>

svn path=/trunk/; revision=20194
2008-05-27 20:33:23 +00:00
Michael Natterer
a4f8d6ccff move deprecated guards around everything, including includes and include
2008-05-27  Michael Natterer  <mitch@imendio.com>

	* gtk/gtksignal.h: move deprecated guards around everything,
	including includes and include guards (just as in all other
	deprecated files).


svn path=/trunk/; revision=20191
2008-05-27 15:07:26 +00:00
Tor Lillqvist
ff89f9050d Use simpler mode for open() on Windows. (No S_I?GRP and S_I?OTH bits are
2008-05-27  Tor Lillqvist  <tml@novell.com>

	* gtk/updateiconcache.c (build_cache): Use simpler mode for open()
	on Windows. (No S_I?GRP and S_I?OTH bits are defined in
	<sys/stat.h> on Windows, and the mode used in open() doesn't
	matter much as there are no rwxrwxrwx bits on Windows anyway.)
	Open file in binary mode. Passing "b" to fdopen() later isn't
	enough.


svn path=/trunk/; revision=20190
2008-05-27 13:03:49 +00:00
10:33:41 Tim Janik
727a7dbf46 guard gtk_widget_get_snapshot() against invalid or invisible widgets.
2008-05-27 10:33:41  Tim Janik  <timj@imendio.com>

        * gtk/gtkwidget.c: guard gtk_widget_get_snapshot() against
        invalid or invisible widgets.


svn path=/trunk/; revision=20187
2008-05-27 08:35:24 +00:00
Matthias Clasen
3f26314d0f Bug 531008 – Crash in gtkprintunixdialog.c
* gtk/gtkprintunixdialog.c: Disconnect signal handlers when
        the dialog closes. Patch by Yevgen Muntyan.


svn path=/trunk/; revision=20186
2008-05-27 04:48:31 +00:00
Matthias Clasen
fd5035c2bd RH bug 248245: cups client printing from gnome applications fail
* modules/printbackends/cups/gtkprintbackendcups.c
        (gtk_print_backend_cups_print_stream): Specify the right server.


svn path=/trunk/; revision=20185
2008-05-27 04:43:41 +00:00
Carlos Garnacho
cdaca42be3 Enable rubberbanding when "select-multiple" is TRUE. Bug #446068.
2008-05-27  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkfilechooserdefault.c (set_select_multiple): Enable
        rubberbanding when "select-multiple" is TRUE. Bug #446068.

svn path=/trunk/; revision=20184
2008-05-27 00:20:18 +00:00
Carlos Garnacho
5d224f01e6 Enable correctly dialog buttons sensitivity when the anonymous option is
2008-05-27  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkmountoperation.c (gtk_mount_operation_ask_password): Enable
        correctly dialog buttons sensitivity when the anonymous option is
        enabled by default. Bug #531865.

svn path=/trunk/; revision=20183
2008-05-27 00:12:33 +00:00
Carlos Garnacho
416bda1204 Set password dialog modal and transient for the parent window also if it
2008-05-27  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkmountoperation.c (gtk_mount_operation_ask_password): Set
        password dialog modal and transient for the parent window also if it
        was specified in the constructor. Bug #531864.

svn path=/trunk/; revision=20182
2008-05-27 00:08:00 +00:00
Richard Hult
f3a6fecb67 Try setting the default font, might need to tweak this.
2008-05-26  Richard Hult  <richard@imendio.com>

	* gdk/quartz/gdkevents-quartz.c: (gdk_screen_get_setting): Try
	setting the default font, might need to tweak this.

svn path=/trunk/; revision=20181
2008-05-26 18:51:35 +00:00
Michael Natterer
a21f711c67 examples/gtkdial/gtkdial.h use G_BEGIN/END_DECLS.
2008-05-26  Michael Natterer  <mitch@imendio.com>

	* examples/gtkdial/gtkdial.h
	* modules/input/gtkimcontextthai.h: use G_BEGIN/END_DECLS.


svn path=/trunk/; revision=20179
2008-05-26 14:34:24 +00:00
Michael Natterer
49bd7edac0 fix indentation.
2008-05-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkimmodule.h: fix indentation.


svn path=/trunk/; revision=20177
2008-05-26 13:07:38 +00:00
Michael Natterer
27dbd9a425 include "gdk/gdk.h" instead of "gdk/gdkscreen.h"
2008-05-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkshow.h: include "gdk/gdk.h" instead of "gdk/gdkscreen.h"

	* gtk/gtkshow.c: remove inclusion of single files from gdk/

	Removed trailing whitespace in both files.


svn path=/trunk/; revision=20176
2008-05-26 09:51:48 +00:00
Richard Hult
6fb474f223 Bug 530353 – Mac-like gtk_accelerator_get_label()
2008-05-26  Richard Hult  <richard@imendio.com>

	Bug 530353 – Mac-like gtk_accelerator_get_label()

	* gtk/gtkaccellabel.c: (gtk_accel_label_class_init),
	(append_keyval_symbol), (_gtk_accel_label_class_get_accelerator_label):
	On quartz, make gtk_accelerator_get_label() format a Mac-like
	string, using unicode characters for modifier keys, arrows, delete
	etc. Patch from Yevgen Muntyan.

svn path=/trunk/; revision=20175
2008-05-26 08:54:00 +00:00
Richard Hult
8ae8e8e307 Bug 534869 – Length miscalculation in
2008-05-26  Richard Hult  <richard@imendio.com>

	Bug 534869 – Length miscalculation in
	_gtk_quartz_get_selection_data_from_pasteboard

	* gtk/gtkquartz.c: (_gtk_quartz_get_selection_data_from_pasteboard):
	Get the number of bytes, not the number of characters, patch from
	Yevgen Muntyan.

svn path=/trunk/; revision=20174
2008-05-26 07:40:17 +00:00
Matthias Clasen
e19eee548f Some doc formatting fixes.
svn path=/trunk/; revision=20172
2008-05-26 05:38:20 +00:00
Matthias Clasen
f7f1dabdf9 Bug 511163 – Remove pango_extents_to_pixels() calls
* gtk/gtkcellrenderertext.c (get_size): Use
        pango_layout_get_pixel_extents.

        * configure.in: Bump Pango requirement to 1.20

        * INSTALL.in: Update required versions


svn path=/trunk/; revision=20171
2008-05-26 04:33:25 +00:00
Matthias Clasen
9ec6a65901 Bug 513811 – Use cairo_format_stride_for_width()
* gtk/gtkhsv.c (paint_ring, paint_triangle):
        * gdk/gdkcairo.c (gdk_cairo_set_source_pixbuf): Use
        cairo_format_stride_for_width, proposed by Behdad Esfahbod.

        * configure.in: Bump cairo requirement to 1.6.0

        * INSTALL.in: Update required versions


svn path=/trunk/; revision=20170
2008-05-26 04:25:25 +00:00
Matthias Clasen
4d734c0e6a Formatting fixes
2008-05-26  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkshow.[hc]: Formatting fixes

        * gtk/gtkmountoperation.c: Add docs


svn path=/trunk/; revision=20169
2008-05-26 04:05:17 +00:00
Cody Russell
d46b2c14a8 Bug 507389 – use gslice for gtksettings
2008-05-25  Cody Russell  <bratsche@gnome.org>

        Bug 507389 – use gslice for gtksettings

        * gtk/gtksettings.c: Change from g_new0/g_free to use GSlice.
        Report and patch by Christian Persch.


svn path=/trunk/; revision=20168
2008-05-25 23:47:36 +00:00
Cody Russell
6b06d71c2a Bug 523562 - gtk-update-icon-cache core dumps when run concurrently and
2008-05-25  Cody Russell  <bratsche@gnome.org>

        Bug 523562 - gtk-update-icon-cache core dumps when run concurrently and
        when options are missing

        * gtk/updateiconcache.c: Open the cache file (O_CREAT | O_EXCL) so     
        that other processes that try to open it will fail gracefully.  Also
        fix a crasher caused by lack of a NULL check.  Report and patch
        by Erwann Chenede.


svn path=/trunk/; revision=20167
2008-05-25 23:41:43 +00:00
Cody Russell
4f84a5f292 Bug 526635 - _gdk_window_get_toplevel handles FOREIGN windows
2008-05-25  Cody Russell  <bratsche@gnome.org>

        Bug 526635 - _gdk_window_get_toplevel handles FOREIGN windows

        * gdk/x11/gdkwindow-x11.c (_gdk_window_get_toplevel): Check
        !WINDOW_IS_TOPLEVEL instead of checking for GDK_WINDOW_CHILD,
        so that we also take into account for foreign windows.
        Report and patch by Nathaniel Smith.


svn path=/trunk/; revision=20166
2008-05-25 23:27:34 +00:00
Cody Russell
a0e6b36478 Bug 525461 - Don't invalidate under an input-only child
2008-05-25  Cody Russell  <bratsche@gnome.org>

        Bug 525461 - Don't invalidate under an input-only child

        * gdk/x11/gdkgeometry-x11.c (_gdk_window_move_resize_child):
        Check that the window is not input-only before invalidating.
        Report and patch by Owen Taylor.


svn path=/trunk/; revision=20165
2008-05-25 23:21:40 +00:00
Cody Russell
4a5da1a18d Bug 524110 - Gdk should not assume reparenting WMs when retrieving window
2008-05-25  Cody Russell  <bratsche@gnome.org>

        Bug 524110 - Gdk should	not assume reparenting	WMs when retrieving
        window	frame extents

        * gdk/x11/gdkwindow-x11.c (gdk_window_get_frame_extents):
        Use _NET_FRAME_EXTENTS,	if available. Patch by Danny Baumann.


svn path=/trunk/; revision=20164
2008-05-25 23:14:39 +00:00
Cody Russell
030ff5b10a Bug 522269 - Evince windows sometimes incorrectly unmaximized, caused by
2008-05-25  Cody Russell  <bratsche@gnome.org>

        Bug 522269 - Evince windows sometimes incorrectly unmaximized,
        caused by missing flag initialization

        * gdk/x11/gdkwindow-x11.c (set_initial_hints): Initialize
        top-level private flags correctly.  Patch by Danny Baumann.


svn path=/trunk/; revision=20163
2008-05-25 23:09:09 +00:00
Cody Russell
cd7376dd5e Bug 534463 - non-editable GtkTextView should not call
2008-05-25  Cody Russell  <bratsche@gnome.org>

        Bug 534463 - non-editable GtkTextView should not call
        gtk_im_context_focus_in	in focus	event

        * gtk/gtktextview.c: Add checks	to see	if the textview	is
        editable.  Patch by Wang Diancheng.


svn path=/trunk/; revision=20162
2008-05-25 22:58:55 +00:00
Matthias Clasen
b0ea8e9f85 Bug 501730 – use GSlice for small allocs
* gtk/gtkmenuitem.c:
        * gtk/gtkmenu.c: Use the slice allocator for small allocations.
        Patch by Christian Persch.


svn path=/trunk/; revision=20161
2008-05-25 22:33:34 +00:00
Matthias Clasen
fa4fb90ee6 Bug 523930 – sort -> search in gtktreeview.c
* gtk/gtktreeview.c (gtk_tree_view_set_search_column): Fix a doc
        glitch, pointed out by Björn Lindqvist.


svn path=/trunk/; revision=20159
2008-05-25 20:41:55 +00:00
Matthias Clasen
4e89e57d1f Bug 479384 – gtk_selection_data_targets_include_uri docs buglet
2008-05-25  Matthias Clasen  <mclasen@redhat.com>

        Bug 479384 – gtk_selection_data_targets_include_uri docs buglet

        * gtk/gtkselection.c (gtk_selection_data_targets_include_uri): Fix
        doc glitch, pointed out by Christian Persch.


svn path=/trunk/; revision=20158
2008-05-25 20:37:15 +00:00
Matthias Clasen
2bf2b07c13 Bug 534694 – Col id in GtkListStore could be out of range
2008-05-25  Matthias Clasen  <mclasen@redhat.com>

        Bug 534694 – Col id in GtkListStore could be out of range

        * gtk/gtkliststore.c (list_store_start_element): Fix up error handling
        a bit. Pointed out by Jan Arne Petersen.

svn path=/trunk/; revision=20157
2008-05-25 20:28:54 +00:00
Matthias Clasen
bd4acfe467 Bug 532497 – Configure problem when cross-compiling
2008-05-25  Matthias Clasen  <mclasen@redhat.com>

        Bug 532497 – Configure problem when cross-compiling

        * configure.in: Use AC_CHECK_TOOLS to find C++ compiler,
        pointed out by Marko Lindqvist.


svn path=/trunk/; revision=20156
2008-05-25 20:18:16 +00:00
Tristan Van Berkom
cd697bb2e3 Enhanced pango attribute tests, Added tests for requires tag handling.
* tests/buildertest.c: Enhanced pango attribute tests, Added tests
	for requires tag handling.


svn path=/trunk/; revision=20154
2008-05-25 15:16:52 +00:00
Richard Hult
97902c7c6a Slight coding style cleanup.
2008-05-25  Richard Hult  <richard@imendio.com>

	* gtk/gtkquartz.c: (_gtk_quartz_set_selection_data_for_pasteboard):
	Slight coding style cleanup.

svn path=/trunk/; revision=20153
2008-05-25 15:15:02 +00:00
Tristan Van Berkom
7b0ef2095a Added support for parsing required toolkit versions (so that ui
* gtk/gtkbuilderprivate.h, gtk/gtkbuilder.h, gtk/gtkbuilderparser.c:
	Added support for parsing required toolkit versions (so that ui descriptions
	can target specific versions of the backend widget libraries) bug 527612.

	* gtk/docs/reference/gtk/tmpl/gtkbuilder.sgml: Added documentation
	for the added xml tags to the ui description.


svn path=/trunk/; revision=20152
2008-05-25 15:12:39 +00:00
Richard Hult
18e3aedbf0 Run gtk_drag_source_info_destroy in an idle, workaround for bug #501588,
2008-05-25  Richard Hult  <richard@imendio.com>

	* gtk/gtkdnd-quartz.c: (gtk_drag_drop_finished): Run
	gtk_drag_source_info_destroy in an idle, workaround for bug
	#501588, that makes any code that uses the context returned from
	gtk_drag_begin() crash, like treeview/iconview dnd.
	(GdkDragSourceOwner::provideDataForType): only use the data if we
	got any.

svn path=/trunk/; revision=20151
2008-05-25 15:11:11 +00:00
Jan Arne Petersen
1d946af2f3 Add GDK_ACTION_MOVE to the drag actions to allow trash (#137717).
2008-05-25  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtkfilechooserdefault.c: (create_file_list): Add GDK_ACTION_MOVE
	to the drag actions to allow trash (#137717).


svn path=/trunk/; revision=20150
2008-05-25 14:24:42 +00:00
Josselin Mouette
d8f3119f30 check that tracker is actually working before using it. Fixes bug #479197.
* gtk/gtksearchenginetracker.c: (_gtk_search_engine_tracker_new):
        check that tracker is actually working before using it. Fixes
        bug #479197.

svn path=/trunk/; revision=20149
2008-05-25 14:19:16 +00:00
Sven Neumann
d0ffa630f5 respect the GTK_NO_WINDOW flag and don't create an output window if it is
2008-05-25  Sven Neumann  <sven@gimp.org>

	* gtk/gtkdrawingarea.c (gtk_drawing_area_realize)
	(gtk_drawing_area_size_allocate): respect the GTK_NO_WINDOW flag
	and don't create an output window if it is set.

	* gtk/gtkprintunixdialog.c: set the GTK_NO_WINDOW flag for the
	drawing areas. Fixes bug #519317.


svn path=/trunk/; revision=20148
2008-05-25 12:53:59 +00:00
Jan Arne Petersen
4ebacd8376 Reorder strange window hierarchy of the GtkSpinButton (#466000).
2008-05-25  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtkentry.c: (gtk_entry_class_init), (get_text_area_size),
	(gtk_entry_get_text_area_size), (gtk_entry_draw_frame):
	* gtk/gtkentry.h:
	* gtk/gtkspinbutton.c: (gtk_spin_button_class_init),
	(gtk_spin_button_realize), (gtk_spin_button_size_allocate),
	(gtk_spin_button_expose), (gtk_spin_button_draw_arrow),
	(gtk_spin_button_enter_notify), (gtk_spin_button_leave_notify),
	(gtk_spin_button_grab_notify), (gtk_spin_button_state_changed),
	(start_spinning), (gtk_spin_button_button_release),
	(gtk_spin_button_motion_notify), (gtk_spin_button_value_changed),
	(gtk_spin_button_get_text_area_size), (gtk_spin_button_real_spin),
	(gtk_spin_button_update): Reorder strange window hierarchy of the
	GtkSpinButton (#466000).


svn path=/trunk/; revision=20147
2008-05-25 12:46:26 +00:00
Jan Arne Petersen
0fea8c56d2 Subtract logical.x from x to fix the wrong position for right and center
2008-05-25  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtklabel.c: (get_layout_location): Subtract logical.x from x to
	fix the wrong position for right and center justified labels with
	logical.x > 0 (#530255).


svn path=/trunk/; revision=20146
2008-05-25 12:29:19 +00:00
Jan Arne Petersen
242f330920 Ignore G_IO_ERROR_FAILED_HANDLED errors (#532262).
2008-05-25  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtkfilechooserdefault.c:
	(shortcuts_activate_volume_mount_cb): Ignore G_IO_ERROR_FAILED_HANDLED
	errors (#532262).


svn path=/trunk/; revision=20145
2008-05-25 12:22:30 +00:00
Björn Lindqvist
6eb51d28e3 tests/pixbuf-lowmem.c tests/pixbuf-random.c
2008-05-25  Björn Lindqvist  <bjourne@gmail.com>

	* tests/pixbuf-lowmem.c
	* tests/pixbuf-random.c
	* tests/pixbuf-randomly-modified.c
	* tests/pixbuf-read.c
	* tests/pixbuf-threads.c
	* tests/testgtk.c
	* tests/testtreeview.c: Fix remaining compiler warnings in these
	files (#523751).

svn path=/trunk/; revision=20144
2008-05-25 08:41:15 +00:00
Jaap A. Haitsma
53c45d129a reviewed by: Matthias Clasen
2008-05-25  Jaap A. Haitsma  <jaap@haitsma.org>

	reviewed by: Matthias Clasen

	* gtk/Makefile.am:
	* gtk/gtk.h:
	* gtk/gtk.symbols:
	* gtk/gtkshow.c: (gtk_show_uri):
	* gtk/gtkshow.h:
	Add gtk_show_uri to make showing uris really easy. Fixes bug #514396

svn path=/trunk/; revision=20143
2008-05-25 08:20:37 +00:00
Jan Arne Petersen
10e8e7d27a Use type of the correct column (#529535). Add test.
2008-05-25  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtkliststore.c: (list_store_text): Use type of the correct
	column (#529535).
	* tests/buildertest.c: (test_list_store): Add test.


svn path=/trunk/; revision=20142
2008-05-24 23:32:13 +00:00
Matthias Clasen
c30e303c35 Make the iconfactory buildable implementation less strict
svn path=/trunk/; revision=20141
2008-05-24 23:19:01 +00:00
Matthias Clasen
66fe5e606f Bug 387972 – gtkassistant drawing problem
* gtk/gtkassistant.c (gtk_assistant_size_allocate): Make
        GtkAssistant work better in glade.


svn path=/trunk/; revision=20140
2008-05-24 20:42:09 +00:00
Jan Arne Petersen
f9d2caa868 Change defaults of child properties "expand" and "homogeneous" from TRUE
2008-05-24  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtktoolbar.c: (gtk_toolbar_class_init): Change defaults of child
	properties "expand" and "homogeneous" from TRUE to FALSE (as they are
	used in GtkToolItem) (#532787).


svn path=/trunk/; revision=20139
2008-05-24 19:03:33 +00:00
Jan Arne Petersen
adcf2fd3f3 Don't try to toggle the visibility of the location entry field in search
2008-05-24  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtkfilechooserdefault.c: (location_toggle_popup_handler): Don't
	try to toggle the visibility of the location entry field in search and
	recent mode (#526422)


svn path=/trunk/; revision=20138
2008-05-24 18:59:56 +00:00