Matthias Clasen
65f0e194e0
Fix a small memory leak
2013-06-15 23:35:25 -04:00
Matthias Clasen
5707e81c81
GtkBuilder: don't leak callbacks
...
This was noticed while running the testsuite under valgrind.
2013-06-15 23:33:51 -04:00
Matthias Clasen
da208f89d5
Avoid an uninitialized variable access
...
https://bugzilla.gnome.org/show_bug.cgi?id=702370
2013-06-15 22:00:51 -04:00
Matthias Clasen
2220845b2b
Fix iconview-empty reftest
...
The reference image for this test was inadvertedly relying
on an incorrect initial icon-size property of GtkImage.
2013-06-15 21:31:41 -04:00
Matthias Clasen
059385b7b8
Remove testing test again
...
This one fails on the build servers.
2013-06-15 21:18:12 -04:00
Matthias Clasen
c5e241147b
Add a few tests back
...
These were lost in the Makefile cleanup.
2013-06-15 20:23:01 -04:00
Matthias Clasen
c9ec4ba5a1
GtkImage: Fix the initial value of icon-size
...
Since we are pulling the icon-size out of the icon helper now,
we should set its icon-size when constructing it.
2013-06-15 20:23:01 -04:00
Matthias Clasen
fdb983f67e
Fix object test
2013-06-15 20:23:01 -04:00
Matthias Clasen
949402ebed
Fix defaultvalue test
2013-06-15 20:23:01 -04:00
Matthias Clasen
864ca76bf9
testsuite: Avoid g_test_trap_fork
...
Fix cellarea tests to use g_test_trap_subprocess instead.
2013-06-15 16:27:04 -04:00
Matthias Clasen
8fbe284c5f
Add listbox tests
2013-06-15 16:03:43 -04:00
Matthias Clasen
e4af0e9bed
testsuite: clean up build machinery a bit
...
No point in setting LDADD for every single binary,
when we can do it just once. Also, generate test.in files.
2013-06-15 16:03:19 -04:00
Matthias Clasen
3e70c283e2
GtkListBox: fix docs
...
New types need to be added to gtk3.types.in to have introspected
data (type hierarchy, properties, signals) show up in the docs.
2013-06-15 13:56:34 -04:00
Piotr Drąg
e27b2519c2
Updated POTFILES.in
2013-06-15 19:09:35 +02:00
Matthias Clasen
87190233ef
GtkListBox: cosmetics
...
Clean up formatting trivia, adjust includes to gtk conventions,
use P_() for properties, etc.
2013-06-15 12:32:59 -04:00
Bastien Nocera
3d11b9b758
GtkSearchBar: Mention we don't handle Ctrl+F for the app
...
There's probably an expectation from the app developers that
Ctrl+F or similar common shortcuts for starting a search will
be handled by the widget, when this is not the case. Explicitely
mention it in the docs to avoid confusion.
https://bugzilla.gnome.org/show_bug.cgi?id=701523
2013-06-14 19:10:39 +02:00
Bastien Nocera
19c5b37d9d
GtkHeaderBar: Fix buildable function names
...
It's a GtkHeaderBar, not GtkHeader.
https://bugzilla.gnome.org/show_bug.cgi?id=701346
2013-06-14 19:10:39 +02:00
Bastien Nocera
8a45cb5762
GtkHeaderBar: Make labels creation available privately
...
So it can be reused in subclasses
https://bugzilla.gnome.org/show_bug.cgi?id=701345
2013-06-14 19:10:39 +02:00
Piotr Drąg
419b25b643
Updated POTFILES.in
2013-06-13 23:09:45 +02:00
Alexander Larsson
264cbc9e35
GtkStack: Switch order on left/right up/down transitions.
...
When the new child is on the left, scroll right. This makes the
thing look physically "real".
2013-06-13 20:55:05 +02:00
Alexander Larsson
418ac673a3
GtkStack: Fix drawing of sliding
...
We were not drawing the view window, so the old widget
was clipped for the sliding transitions.
2013-06-13 20:50:41 +02:00
Erick Pérez Castellanos
33a1c4d6e0
GtkStack: Add position-dependent slide transitions
...
These go left/right or up/down depending on the relative
order of the children being switched between.
2013-06-13 20:33:42 +02:00
Tarnyko
53a9311e2c
broadway: Add win32 support
2013-06-13 19:35:43 +02:00
Tarnyko
e2da2259ad
broadway: Support TCP displays
2013-06-13 19:12:46 +02:00
Tarnyko
d4dacc596f
broadway: Only use gio-unix on G_OS_UNIX
2013-06-13 18:15:10 +02:00
Tarnyko
050702494b
broadway: Remove unused includes
2013-06-13 18:09:32 +02:00
Tarnyko
b20d949470
broadway: Add configure checks for sys/mman.h
2013-06-13 18:01:44 +02:00
Alexander Larsson
0451d2c9b8
docs: Add GtkListBox to docs
2013-06-13 17:55:35 +02:00
Benjamin Otte
860639e796
reftests: Fix for state propagation changes
2013-06-13 15:31:35 +02:00
Benjamin Otte
7ce198ea6f
x11: Remove motif dnd leftovers
2013-06-13 15:31:35 +02:00
Benjamin Otte
0d55d9b96b
treeview: Use gtk_adjustment_configure()
...
... instead of manually setting all the values. Makes for nicer code and
less signal emissions.
2013-06-13 15:31:35 +02:00
Alexander Larsson
61f44628d6
GtkListBox: Consider width of filtered rows
...
Without this lists keep shrinking in width as they are filtered, whic
looks really bad.
2013-06-13 12:17:08 +02:00
Alexander Larsson
220eb45ef0
GtkListBox: Protect against reentrancy.
...
Activating a row may destroy the widget, so keep a ref since
we're doing thing to the listbox after emission.
2013-06-13 12:17:08 +02:00
Alexander Larsson
0f93b7f6c4
GtkListBox: minor fix
...
Move the check inside the existing chech which also checks
for active_row != NULL for extra safety.
2013-06-13 12:17:08 +02:00
Alexander Larsson
1dd0b468a7
GtkListBox: Add style classes for lists and rows
2013-06-13 12:17:07 +02:00
Alexander Larsson
3bb2d15195
GtkListBox: Add getter for activate_on_single_click
2013-06-13 12:17:07 +02:00
Alexander Larsson
90ff262df6
GtkListBox: Rename reXXX to invalidate_XXX
...
This is lets us later move to a setup where the rows are not
immediately resorted but queued until next layout.
2013-06-13 12:17:07 +02:00
Alexander Larsson
6d71f7f61b
testgtk: Test GtkListBox placeholder widgets
2013-06-13 12:17:07 +02:00
Alexander Larsson
caacce6d44
GtkListBox: Add placeholder widget support
2013-06-13 12:17:07 +02:00
Alexander Larsson
b0b746b2ea
GtkListBox: Track the number of visible children
2013-06-13 12:17:07 +02:00
Alexander Larsson
9510b79d78
GtkListBox: Track visible in the row
...
This is a minor performance improvement, but its mainly to
allow us to track when n_visible_children changes.
2013-06-13 12:17:07 +02:00
Alexander Larsson
217c2bb087
GtkListBox: Open code the update_header calls in add()
...
Rather than reusing row_visibility_changed. This means
row_visibility_changed really means that the row visibility changed.
2013-06-13 12:17:07 +02:00
Alexander Larsson
1eb729dcd9
GtkListBox: Make reseparate a no-op for hidden lists
...
We already take care to not track headers when the listbox is hidden,
because that can be very expensive during creation, so we might as
well skip reseparate() too. The only time we don't want to skip it
is when we're about to show the list.
2013-06-13 12:17:07 +02:00
Alexander Larsson
cbf294b27e
GtkListBox: Remove some unnecessary code
...
the unhighlight call already NULLs out drag_highlighted_row
2013-06-13 12:17:07 +02:00
Alexander Larsson
2ba67a0b8b
GtkListBox: Fix docs
...
Removed some cut/paste leftovers
2013-06-13 12:17:07 +02:00
Alexander Larsson
b119b022a7
GtkListBox: Allow unselecting of rows in SINGLE mode
2013-06-13 12:17:07 +02:00
Alexander Larsson
cc4ac1ee70
GtkListBox: Rename separators to headers
2013-06-13 12:17:07 +02:00
Alexander Larsson
4a0b6e5479
GtkListBox: Remove refilter signal
...
This was added from https://bugzilla.gnome.org/show_bug.cgi?id=691979
where it was wanted in order to get a "all children filtered" kind
of row. However, the solution is not really generic enough, because
filtering can happen for other reasons than a full refilter (i.e. due
to a row change), and the partial fix you can get by counting children
after refilter can be achieved by manually doing it whenever you manually
called refilter anyway.
Its possible we should have some better solution for the "empty state"
though.
2013-06-13 12:17:07 +02:00
Alexander Larsson
c6ac711508
GtkListBox: Add docs
2013-06-13 12:17:07 +02:00
Alexander Larsson
6a77754c77
GtkWidget: Change which states propagate
...
Historically the following states propagated to children:
GTK_STATE_FLAG_ACTIVE
GTK_STATE_FLAG_PRELIGHT
GTK_STATE_FLAG_SELECTED
GTK_STATE_FLAG_INSENSITIVE
GTK_STATE_FLAG_INCONSISTENT
GTK_STATE_FLAG_BACKDROP
However, several of these are problematic on containers like GtkListBox.
For instance, if a row is ACTIVE or SELECTED then all children (like e.g
a button) inside the row will *also* look active/selected. This is almost
never right. The right way to theme this is to catch e.g. SELECTED on the
container itself and set e.g. the color and let the children inherit
the color instead of the flag.
We now propagate only these flags:
GTK_STATE_FLAG_INSENSITIVE
GTK_STATE_FLAG_BACKDROP
Which make sense to be recursive as they really affect every widget
inside the container.
However, this is a CSS theme break, and while most things continue working
as-is some themes may need minor tweaks.
2013-06-13 12:17:07 +02:00