Matthias Clasen
72614fdb67
gsk: Normalize node bounds upon creation
...
We lost this when a bunch of rect code was inlined in
commit 36314f28e2
, and as it turns out, that broke some
applications. So, bring it back.
Fixes : #6435
2024-02-13 20:06:16 -05:00
Matthias Clasen
230ee92857
Add gsk_rect_normalize
...
This is an inline version of graphene_rect_normalize_in_place.
2024-02-13 20:06:16 -05:00
Matthias Clasen
fd4f22bba5
Merge branch 'matthiasc/for-main' into 'main'
...
tests: Remove xfails for tests that work now
See merge request GNOME/gtk!6900
2024-02-13 23:54:23 +00:00
Matthias Clasen
1e8d7c7891
tests: Add a new xfail for a failing test
...
This is filed as #6439
2024-02-13 18:35:13 -05:00
Matthias Clasen
73316a83c4
tests: Remove xfails for tests that work now
...
We fixed some things, yay.
2024-02-13 17:31:18 -05:00
Matthias Clasen
b2d22d8125
Merge branch 'wip/abono/fallthrough' into 'main'
...
gsk: Remove unnecessary G_GNUC_FALLTHROUGH
See merge request GNOME/gtk!6898
2024-02-13 22:17:50 +00:00
Benjamin Otte
afb75bedfe
Merge branch 'wip/otte/for-main' into 'main'
...
gpu: Don't oversize node image
Closes #6380 and #6425
See merge request GNOME/gtk!6899
2024-02-13 21:14:20 +00:00
Benjamin Otte
ee34781a13
gpu: Pixel-align the blur rectangle
...
Fixes blurriness in shadows.
Not sure to do a proper test for this feature. Usually proper pixel
alignment is tested by drawing a crips line and checking that it is
indeed crisp. But we are testing the blur operation here...
Fixes #6380
2024-02-13 21:56:01 +01:00
Benjamin Otte
9fc80a0bd5
gpu: Update blur code to newer internal API
...
The recommended way to draw offscreens has been init_draw() for a bit,
but apparently this code wasn't updated.
2024-02-13 21:56:01 +01:00
Benjamin Otte
d4203d147a
testsuite: Add a test for shadow offset clipping
2024-02-13 21:56:01 +01:00
Benjamin Otte
a1dda0ec3c
gpu: Adjust shadows clip by shadow offset
...
When computing the clip of the shadow rect, don't forget that it will
ultimately be offset by the shadow offset.
Fixes #6425
2024-02-13 21:56:01 +01:00
Benjamin Otte
f9b66dff8b
testsuite: Add a test for shadows with large offset
...
This was causing crashes in the GPU renderer.
Related: #6425
2024-02-13 21:56:01 +01:00
Benjamin Otte
dbbc16947f
gpu: Handle one layer of NULL return
...
This isn't really a useful thing in itself, because none of the callers
handle the NULL return.
But the resulting crash is easier to debug when it's a NULL image than
when add_node() is called on an uninitializes NodeProcessor.
2024-02-13 21:56:01 +01:00
Benjamin Otte
dc47abc60e
gpu: Don't oversize node image
...
There's no need - even if given clip bounds - to render the parts
outside the node.
So clip to the node bounds.
2024-02-13 21:56:01 +01:00
Alessandro Bono
ca9ba3cc80
gsk: Remove unnecessary G_GNUC_FALLTHROUGH
...
In GSK the following pattern is used four times:
```
switch (self->filter)
{
default:
g_assert_not_reached ();
G_GNUC_FALLTHROUGH;
case GSK_GPU_BLIT_LINEAR:
filter = GL_LINEAR;
break;
case GSK_GPU_BLIT_NEAREST:
filter = GL_NEAREST;
break;
}
```
The G_GNUC_FALLTHROUGH macro is not required. When G_DISABLE_ASSERT
is defined the body of the `default` case is empty, thus there is
no need. When G_DISABLE_ASSERT is not defined the body of the `default`
case contains g_assert_not_reached() thus it won't fallthrough.
This resolves the following:
```
[221/1379] Compiling C object gsk/libgsk.a.p/gpu_gskgpublitop.c.o
[...]
error: fallthrough annotation in unreachable code [-Werror,-Wimplicit-fallthrough]
1 error generated.
```
2024-02-13 18:29:03 +01:00
Artur S0
59f6218426
Update Russian translation
2024-02-13 16:32:44 +00:00
Matthias Clasen
f533d08537
Merge branch 'matthiasc/for-main' into 'main'
...
gpu: Print globals when being verbose
See merge request GNOME/gtk!6897
2024-02-13 14:00:30 +00:00
Matthias Clasen
230aa7899e
Merge branch 'wip/abono/dma-buf' into 'main'
...
dmabufformats: Include gdkdmabuffourccprivate.h
See merge request GNOME/gtk!6896
2024-02-13 13:59:26 +00:00
Alessandro Bono
cc51604267
dmabufformats: Include gdkdmabuffourccprivate.h
...
It includes a fallback list of fourccs. Otherwise we might miss some
DRM_FORMAT definition.
This happens in SLES12:
```
../testsuite/gdk/dmabufformats.c: In function ‘test_dmabuf_formats_basic’:
../testsuite/gdk/dmabufformats.c:29:56: error: ‘DRM_FORMAT_ABGR16161616F’ undeclared (first use in this function); did you mean ‘DRM_FORMAT_ABGR2101010’?
29 | g_assert_true (gdk_dmabuf_formats_contains (formats, DRM_FORMAT_ABGR16161616F, DRM_FORMAT_MOD_LINEAR));
```
2024-02-13 14:15:32 +01:00
Alessandro Bono
3b2622267d
testdmabuf: Include gdkdmabuffourccprivate.h
...
It includes a fallback list of fourccs. Otherwise we might miss some
DRM_FORMAT definition.
2024-02-13 14:15:32 +01:00
Alessandro Bono
4fc05e7c64
dmabuftexture: Include gdkdmabuffourccprivate.h
...
It includes a fallback list of fourccs. Otherwise we might miss some
DRM_FORMAT definition.
2024-02-13 14:15:32 +01:00
Alessandro Bono
4e680cae48
gtkgstsink: Include gdkdmabuffourccprivate.h
...
It includes a fallback list of fourccs. Otherwise we might miss some
DRM_FORMAT definition.
2024-02-13 14:15:32 +01:00
Alessandro Bono
d957e40a63
gdkglcontext: Include gdkdmabuffourccprivate.h
...
It includes a fallback list of fourccs. Otherwise we might miss some
DRM_FORMAT definition.
2024-02-13 14:15:32 +01:00
Alessandro Bono
d1bc8e580d
gdkdmabuffourccprivate: Include config.h
...
Do so before checking HAVE_DMABUF presence.
2024-02-13 14:15:32 +01:00
Sabri Ünal
5dadee1591
Update Turkish translation
2024-02-13 12:10:05 +00:00
Matthias Clasen
ea7a61a763
gpu: Print globals when being verbose
...
This can be helpful to see that there is an enormous scale blowing
things up. We omit the matrix, since it is 16 floats that are hard
to interpret at a glance.
2024-02-13 06:59:58 -05:00
Matthias Clasen
8bd6927daf
Merge branch 'dboles/CSSProvider-to_string-load_from_string' into 'main'
...
CSSProvider: Mention non-deprecated fn @ to_string
See merge request GNOME/gtk!6894
2024-02-12 23:32:23 +00:00
Matthias Clasen
67912c1051
Merge branch 'inspector-gl-extensions' into 'main'
...
gl: Check for the right extension name
See merge request GNOME/gtk!6893
2024-02-12 22:55:05 +00:00
Matthias Clasen
6314a5240d
inspector: Show more gl extensions
2024-02-12 16:57:46 -05:00
Daniel Boles
e7f55d8706
CSSProvider: Mention non-deprecated fn @ to_string
...
load_from_data() is deprecated, so don't cite it in to_string(); rather,
mention load_from_string() instead.
2024-02-12 21:28:24 +00:00
Matthias Clasen
671756cb13
Merge branch 'llvmpipe-be-gone' into 'main'
...
gsk: Don't use gpu renderers with llvmpipe
See merge request GNOME/gtk!6890
2024-02-12 21:16:48 +00:00
Matthias Clasen
7cf567b4f9
gl: Check for the right extension name
...
The extension is called GL_OES_vertex_half_float.
2024-02-12 16:13:54 -05:00
Yuri Chornoivan
82e695d94a
Update Ukrainian translation
2024-02-12 20:09:57 +00:00
Matthias Clasen
2104d7b062
fixup! gsk: Don't use gpu renderers with llvmpipe
2024-02-12 14:41:14 -05:00
Matthias Clasen
6c4739a2f1
gsk: Don't use gpu renderers with llvmpipe
...
Unless the renderer has been explicitly selected via the
GSK_RENDERER environment variable, don't use it with llvmpipe.
It is important that we allow explicit setting to override
this, so we can continue to use ngl in ci, where we don't
have hw and want to test with llvmpipe.
This should address many of the "performance is terrible in
GNOME OS" complaints that are coming from people running in
VMs, etc.
2024-02-12 14:19:57 -05:00
Matthias Clasen
f858daeca4
node-editor: Don't help too much
...
This was somehow duplicated when the reload action was added.
2024-02-12 14:19:21 -05:00
Matthias Clasen
efa0033fb4
inspector: Spell out Vulkan device types
...
We know what these are, no need to be mysterious about it.
2024-02-12 14:19:21 -05:00
Matthias Clasen
546378e65c
Merge branch 'no_duplicate_descriptions' into 'main'
...
a11y: When using the tooltip for accessible name, don't use it for description
See merge request GNOME/gtk!6829
2024-02-12 17:04:43 +00:00
Matthias Clasen
a997dea414
Merge branch 'link-to-code-formatting-changed' into 'main'
...
clang-format: The link to code formatting has changed
See merge request GNOME/gtk!6891
2024-02-12 17:03:37 +00:00
Danial Behzadi
e75af999dc
Update Persian translation
2024-02-12 15:56:40 +00:00
Ahmed Baizid
e8dcbbe86f
clang-format: The link to code formatting has changed
2024-02-12 15:51:41 +01:00
Matthias Clasen
3c048caa30
Merge branch 'wip/nacho/scale-button-has-frame' into 'main'
...
scalebutton: add api to get/set whether it has a frame
See merge request GNOME/gtk!6779
2024-02-12 14:19:45 +00:00
Matthias Clasen
925d2ba9ae
Merge branch 'wip/otte/for-main' into 'main'
...
gpu: Avoid offscreens for disjoint containers
See merge request GNOME/gtk!6889
2024-02-12 12:58:14 +00:00
Ekaterine Papava
645070ef7f
Update Georgian translation
2024-02-12 11:41:10 +00:00
Benjamin Otte
2fe1f47e6d
gpu: Avoid offscreens for disjoint containers
...
When opacity is set but the container is disjoint - ie no children
overlap - don't redirect into an offscreen, because it's not necessary.
2024-02-12 08:34:18 +01:00
Matthias Clasen
db8f87d539
Post-release version bump
2024-02-11 22:45:59 -05:00
Matthias Clasen
a75d97c788
4.13.7
2024-02-11 22:38:52 -05:00
Matthias Clasen
ea9e414ad6
Skip one more failing clipped render test
2024-02-11 22:38:52 -05:00
Matthias Clasen
c1bcbcdee5
Merge branch 'offload-padding' into 'main'
...
offload: handle dmabufs with viewports
See merge request GNOME/gtk!6833
2024-02-12 03:12:46 +00:00
Robert Mader
8f293f3153
gstreamer: Bump required version for offloading
...
This version is guaranteed to have all features in place.
2024-02-11 21:50:50 -05:00