Matthias Clasen
7b76be5360
button: Add explicit key bindings for activation
...
We should not rely on GtkWindow to have global
"activate-default" key bindings that happen to
fall back to activating the focus widget. This is
unreliable, since the bubbling up from the button
to the toplevel may run across other widgets that
may want to use Enter for their own purpose, and
then the button loses out. By adding our own
key bindings, the button gets to handle it before
its ancestors.
This fixes check buttons in the inspector property
list not reacting to Enter despite having focus.
2020-07-18 12:53:10 -04:00
Matthias Clasen
2e2336ffce
text: Claim clicks when grabbing focus
...
If we don't, an ancestor (such a GtkListItemWidget)
may interpret the click as "I should grab focus!",
and still our focus away. This was causing hard-to-focus
entries in the property list in the inspector.
2020-07-18 12:47:47 -04:00
Matthias Clasen
76d80ef516
inspector: Add focus handling to the property editor
...
We want to focus the actual control here.
2020-07-18 11:55:19 -04:00
Matthias Clasen
287d80bd36
editablelabel: Stop editing on focus-out
...
This is the expected behavior for the main use case,
treeview-like 'edit one cell at a time'.
2020-07-18 10:45:27 -04:00
Matthias Clasen
77072b3eaa
fixup editing style class
2020-07-18 10:10:28 -04:00
Matthias Clasen
c7833bb090
editablelabel: Document css nodes
...
Just the usual.
2020-07-18 09:55:46 -04:00
Matthias Clasen
899024cef7
editablelabel: Add a style class while editing
...
Add the .editing style class to the editable label
while it is editing. The idea is that themes can
show a frame around the entry.
2020-07-18 09:54:55 -04:00
Matthias Clasen
7c02ae00c2
inspector: Clean up GtkInspectorGeneral
...
Drop the Private struct.
2020-07-18 00:31:04 -04:00
Matthias Clasen
80e29a3627
inspector: Clean up GtkInspectorMiscInfo
...
Drop the Private struct.
2020-07-18 00:25:46 -04:00
Matthias Clasen
26163a4f30
inspector: Clean up GtkInspectorVisual
...
Drop the Private struct, and do all cleanup in dispose.
2020-07-18 00:17:42 -04:00
Matthias Clasen
dbd88fc210
inspector: Clean up GtkInspectorActions
...
Drop the Private struct, dispose properly,
and don't derive from GtkBox.
2020-07-17 23:59:49 -04:00
Matthias Clasen
2de31e4cac
inspector: Clean up GtkInspectorActionEditor
...
Drop the Private struct, dispose properly,
and don't derive from GtkBox.
2020-07-17 23:36:05 -04:00
Matthias Clasen
1bff328895
inspector: Clean up GtkInspectorLogs
...
Drop the Private struct, dispose properly,
and don't derive from GtkBox.
2020-07-17 23:24:14 -04:00
Matthias Clasen
facf78a5b6
inspector: Allow disposing the inspector
...
We were hiding the inspector when the window
is closed, but that has the side-effect of
keeping references to application windows,
so we would keep them artificially alive,
which can have side-effects.
So, make the inspector go away when closed.
2020-07-17 23:15:42 -04:00
Matthias Clasen
6b19fcd859
inspector: Properly dispose GtkInspectorWindow
2020-07-17 23:15:25 -04:00
Matthias Clasen
ca784e3e1a
inspector: Properly dispose GtkInspectorShortcuts
2020-07-17 23:13:29 -04:00
Matthias Clasen
314c8558d7
inspector: Properly dispose GtkInspectorListData
2020-07-17 23:13:07 -04:00
Matthias Clasen
af30a7fe06
inspector: Dispose tree data properly
...
Another place where we were leaking children.
2020-07-17 22:54:19 -04:00
Matthias Clasen
9ffd7d1970
inspector: Dispose the recorder properly
...
We were leaking children here.
2020-07-17 22:54:10 -04:00
Matthias Clasen
cb906c80eb
inspector: Drop the recorder Private struct
2020-07-17 22:37:24 -04:00
Matthias Clasen
96ce0eb600
Merge branch 'matthiasc/for-master' into 'master'
...
gtk-demo: Don't use GtkColorSwatch
See merge request GNOME/gtk!2262
2020-07-18 01:17:43 +00:00
Matthias Clasen
0e476c1f28
gtk-demo: Don't use GtkColorSwatch
...
Making our own is 80 lines of code, so just do it.
2020-07-17 20:44:06 -04:00
Matthias Clasen
f2924988db
Merge branch 'ebassi/for-master' into 'master'
...
Fix typo in the GtkStrinFilter constructor declaration
See merge request GNOME/gtk!2261
2020-07-17 13:18:59 +00:00
Emmanuele Bassi
671435e07f
Fix typo in the GtkStrinFilter constructor declaration
2020-07-17 14:16:46 +01:00
Emmanuele Bassi
b17cfb9b65
Merge branch 'ebassi/for-master' into 'master'
...
Fix typo in the gtk-doc stanza for gtk_string_filter_new()
See merge request GNOME/gtk!2259
2020-07-17 13:09:55 +00:00
Emmanuele Bassi
0385f1aaf4
Fix typo in the gtk-doc stanza for gtk_string_filter_new()
2020-07-17 12:03:17 +01:00
Matthias Clasen
8611faf338
Merge branch 'wip/baedert/for-master' into 'master'
...
Wip/baedert/for master
Closes #2776
See merge request GNOME/gtk!2258
2020-07-17 10:56:16 +00:00
Timm Bäder
7e19911d3f
testwidgettransforms: Fix GtkBox casts
2020-07-17 07:14:50 +02:00
Timm Bäder
c1f5153f6d
boxlayout: Remove unnecessary checks
...
The pointers passed to GtkLayoutManager::measure() are never NULL. The
ones passed to gtk_layout_manager_measure() can be, however.
2020-07-17 06:31:57 +02:00
Timm Bäder
2bd87ce771
boxlayout: Remove unused include
2020-07-17 06:27:50 +02:00
Timm Bäder
de0547ede7
migration guide: Remove a stray html tag
2020-07-17 06:27:23 +02:00
Timm Bäder
14589c2a59
widget: Save a gtk_css_node_get_style call
2020-07-17 05:49:12 +02:00
Timm Bäder
f678b3804d
widget: Remove useless if statement
...
filter_value is never NULL anyway.
2020-07-17 05:49:12 +02:00
Timm Bäder
720c298786
snapshot: Use collect_default directoy in push_debug()
...
Instead of going through collect_debug and then doing a collect_default
anyway if the message is NULL.
2020-07-17 05:49:12 +02:00
Timm Bäder
f721d2de15
debug: Remove resize highlighting
...
This has been broken ever since the debug highlighting moved to
inspector overlays.
2020-07-17 05:49:12 +02:00
Timm Bäder
11f07cb5ad
GdkRGBA: Fix typo in documentation
2020-07-17 05:49:11 +02:00
Timm Bäder
37d7ab88dc
gl renderer: Avoid 9-slicing things that can't be
...
The outline needs to be large enough so changing the size of the outline
does not affect the resulting blurred texture.
Fixes #2776
2020-07-17 05:49:11 +02:00
Timm Bäder
6cde64072d
gl renderer: Remove outdated comment
2020-07-17 05:49:11 +02:00
Timm Bäder
6a60b0f591
gl renderer: Try to intersect rounded clips more often
2020-07-17 05:49:11 +02:00
Timm Bäder
339d9f05e4
gl renderer: Remove unused flag
2020-07-17 05:49:11 +02:00
Timm Bäder
4e4207457f
adwaita: Remove header bar border radius
...
We get this from the window node these days.
2020-07-17 05:49:11 +02:00
Timm Bäder
46bb3e3046
icontheme: Indentation
2020-07-17 05:49:11 +02:00
Timm Bäder
34008e6aab
gl renderer: Ignore rounded clip that only increase the clip
...
This fixes the widget factory rendering too much.
In the widget-factory, we generally have a pretty small update area (two
spinners and a progressbar). We take the extents of that as a update
area and inital clip.
However, the first clip node we see is from the toplevel window, which
essentially increases the clip again to almost the entire window.
Fix that by ignoring such cases.
2020-07-17 05:49:11 +02:00
Timm Bäder
d6b3ac850d
testsuite: Fix test case indentation
2020-07-17 05:49:11 +02:00
Matthias Clasen
9742200ff6
Merge branch 'matthiasc/for-master' into 'master'
...
Matthiasc/for master
See merge request GNOME/gtk!2257
2020-07-17 03:20:20 +00:00
Matthias Clasen
ec10857b84
docs: Move columns below columnview
2020-07-16 22:14:39 -04:00
Matthias Clasen
353d4d161c
Cosmetic docs change
2020-07-16 22:08:15 -04:00
Matthias Clasen
bcd650f169
docs: Revise the filter docs a bit
2020-07-16 21:48:08 -04:00
Matthias Clasen
72d66dfcdd
docs: Revise sorter docs a bit
2020-07-16 21:45:11 -04:00
Matthias Clasen
5e97df5058
bitset: try again
2020-07-16 21:44:31 -04:00