Chun-wei Fan
ba7ec29dc0
gdksurface-win32.c: Fix up popup placement
...
If we are undergoing a surface move, just apply the next_layout anyways,
even if we are not moving a toplevel surface.
Update the way how we obtain the x and y coordinates of a surface, if it
is a toplevel, apply the x and y coordinates from the results from we
obtained the underlying Win32 HWND, as we did before. But if it is a
popup, use gdk_win32_surface_get_geometry() to obtain the correct x and
y coordinates to place our popup surface.
Also correct how we compute the shadow dimensions, and the final popup
rectangle as we attempt to layout the popup surface, since GDK-Win32
keeps track of the shadow dimensions in system (unscaled) units, not GDK
units.
Fixes issue #3793 .
2021-06-16 16:25:29 +08:00
Chun-wei Fan
85b595bd14
gdksurface-win32.c: Fix formatting for popup functions
2021-06-16 15:02:56 +08:00
Matthias Clasen
56c486abbf
Merge branch 'drop-target-name-collision' into 'master'
...
droptarget: Rename :drop to :current-drop
Closes #4028
See merge request GNOME/gtk!3669
2021-06-16 00:12:53 +00:00
Matthias Clasen
b09087d634
droptarget: Rename :drop to :current-drop
...
Rename the GtkDropTraget:drop property to :current-drop,
to avoid naming collision with the signal of the same
name.
We leave the old property and getter in place, deprecated
and marked as non-introspectable.
Fixes : #4028
2021-06-15 18:21:28 -04:00
Matthias Clasen
5e99513507
Merge branch 'cherry-pick-4ba89f25' into 'master'
...
cellarea: Don't shrink area too much
See merge request GNOME/gtk!3672
2021-06-15 20:29:28 +00:00
Matthias Clasen
0a9d2f248e
Merge branch 'label-underline-markup' into 'master'
...
label: Fix mnemonic handling
Closes #4041
See merge request GNOME/gtk!3670
2021-06-15 19:43:40 +00:00
Benjamin Otte
16ff055b42
cellarea: Don't shrink area too much
...
Do not compute rectangles with negative width/height. This avoids
assertion failures further down when those rectangles were actually
checked.
https://bugzilla.redhat.com/show_bug.cgi?id=1962215
(cherry picked from commit 4ba89f25b8
2021-06-15 18:00:25 +00:00
Matthias Clasen
89f57d4ff6
Add a mnemonic testcase
...
Add a testcase that tests the label mnemonic handling
that was fixed in the previous commit.
2021-06-15 13:32:31 -04:00
Matthias Clasen
c4a2234a28
label: Fix mnemonic handling
...
We were not handling the case right in which we
want to use underlines, but not use markup. Since
we are now using pango_parse_markup for this case,
we need to escape the xml markup.
Fixes : #4041
2021-06-15 13:06:10 -04:00
Matthias Clasen
a3882763d8
Revert "progressbar: Avoid redundant storage"
...
This reverts commit 95747b1a40Fixes : #4037
2021-06-15 07:37:57 -04:00
Emin Tufan Çetin
787fa6bd0d
Update Turkish translation
2021-06-15 09:02:34 +00:00
Matthias Clasen
a6b4e53dca
Merge branch 'macos-input-method' into 'master'
...
fix: make input method work again in gtk4
Closes #3968
See merge request GNOME/gtk!3668
2021-06-14 19:20:06 +00:00
Matthias Clasen
00d25ae89c
Merge branch 'media-stream-name-collision' into 'master'
...
mediastream: Rename an api to avoid name collisions
Closes #4023
See merge request GNOME/gtk!3667
2021-06-14 18:44:10 +00:00
Zhi
5776fcd955
fix: make the new nsview as the first responder.
...
Make the new view as the first responder(focused) so the new view can
accept events from input method.
Fixes #3968 .
2021-06-15 00:09:46 +08:00
Matthias Clasen
86b5dba43b
mediastream: Rename an api to avoid name collisions
...
Some bindings can't handle the coexistence of
GtkMediaStream:prepared and gtk_media_stream_prepared.
Help them out by renaming the function to
gtk_media_stream_set_prepared, and rename
gtk_media_stream_unprepared as well, to match.
The existing entry points still exist, deprecated.
Update all internal uses.
Fixes : #4023
2021-06-14 07:50:12 -04:00
Matthias Clasen
e888364d3c
Merge branch 'columnview-double-activation' into 'master'
...
listitemwidget: Claim gesture when activating
Closes #4015
See merge request GNOME/gtk!3663
2021-06-14 10:39:43 +00:00
Matthias Clasen
276f85c9e3
listitemwidget: Claim gesture when activating
...
Claim the gesture when we are activating a list item.
Otherwise we end up with double activations in
columnviews: first GtkColumnViewCell handles
the event, and then GtkListItemWidget handles
it again.
Fixes : #4015
2021-06-13 08:03:39 -04:00
Matthias Clasen
68eb422333
listitemwidget: Match activation conditions
...
Make the conditions used for activation in the single-
and double-click case properly match, so that it is
obvious that we won't trigger both of them.
2021-06-13 08:02:06 -04:00
Matthias Clasen
c0f54f899d
Merge branch 'filename-annotations' into 'master'
...
Add type annotations for filename arguments
Closes #633
See merge request GNOME/gtk!3665
2021-06-13 11:38:50 +00:00
Matthias Clasen
65212535df
Merge branch 'msvc-fix' into 'master'
...
Fix illegal instruction crash on x64 CPUs without POPCNT instruction when compiled with MSVC
See merge request GNOME/gtk!3664
2021-06-13 11:38:22 +00:00
Sebastian Cherek
106ac7c782
Update gtkpopcountprivate.h: undefined macro outside msvc
2021-06-12 17:35:13 +00:00
scherek
bc7b6a0e53
Dropped defined() for readability
2021-06-12 19:10:11 +02:00
scherek
e5b89569fd
Replaced && with || for POPCNT checks to fix the logic.
2021-06-12 17:32:19 +02:00
Matthias Clasen
938bfff3dd
Add type annotations for filename arguments
...
Add missing "(type filename)" annotations for string
arguments that are filenames.
Fixes : #633
2021-06-12 11:12:06 -04:00
scherek
6835fcf3cf
Fix illegal instruction crash on x64 CPUs without POPCNT instruction when compiled with MSVC
2021-06-12 16:18:26 +02:00
Matthias Clasen
2554ee27d9
Merge branch 'listmodel-get-item' into 'master'
...
docs: Mention the GtkWidget.destroy vfunc
Closes #4024
See merge request GNOME/gtk!3662
2021-06-11 19:56:06 +00:00
Matthias Clasen
007cdf8787
Add tests for empty list models
...
Test that all our models return NULL for out-of-range
get_item calls, as expected.
2021-06-11 15:38:20 -04:00
Matthias Clasen
a526daf310
selectionfiltermodel: Fix an oversight
...
When the position is out of range, get_item needs
to return NULL.
Fixes : #4024
2021-06-11 15:37:16 -04:00
Matthias Clasen
ee34e1acc5
docs: Mention the GtkWidget.destroy vfunc
...
Mention GtkWidget.destroy in the migration guide.
2021-06-11 10:11:53 -04:00
Matthias Clasen
a08fbfa586
docs: Fix a typo in the migration guide
2021-06-11 07:52:30 -04:00
Matthias Clasen
d29f57fd1d
Merge branch 'wip/chergert/fix-delayed-focus' into 'master'
...
window: clear move_focus when focus is already set
See merge request GNOME/gtk!3658
2021-06-10 21:31:47 +00:00
Christian Hergert
a4c5d1d94d
window: clear move_focus when focus is already set
...
This can get set in other places, so we need to ensure it is cleared so
that an after-paint handler does not move the focus to a new widget.
2021-06-10 14:01:41 -07:00
Matthias Clasen
17f1bb1632
Merge branch 'actionable-fixes' into 'master'
...
tests: Fix check vs toggle button confusion
Closes #4022
See merge request GNOME/gtk!3656
2021-06-10 13:30:25 +00:00
Matthias Clasen
3418504b4b
checkbutton: Fix actionable state tracking
...
If we have a GAction as model, we just have to
call gtk_action_helper_activate() and let
the action helper handle the state updates,
Fixes : #4022
2021-06-10 08:38:12 -04:00
Matthias Clasen
0a78a592ff
togglebutton: Fix actionable state tracking
...
If we have a GAction as model, we just have to let
the action helper handle the state updates. GtkButton
already calls gtk_action_helper_activate() for us.
2021-06-10 08:36:08 -04:00
Matthias Clasen
208c527fb3
button: Add a private getter for the action helper
...
GtkToggleButton needs to know if it needs to actively
maintain its state, or defer to the action helper.
2021-06-10 08:36:01 -04:00
Matthias Clasen
28990285e2
testgaction: Add more widgetry
...
Add some toggle and check buttons to test that they
work as expected as GtkActionables.
2021-06-10 08:10:25 -04:00
Matthias Clasen
c7ad8d29e9
Fix the GAction test
...
We weren't setting the state of the stateful actions.
2021-06-10 08:10:08 -04:00
Matthias Clasen
dba8d1ff77
tests: Fix check vs toggle button confusion
...
Check buttons aren't toggle buttons anymore.
2021-06-10 07:49:08 -04:00
Matthias Clasen
143770f16d
4.3.1
2021-06-09 18:23:47 -04:00
Matthias Clasen
8a890238f5
Merge branch 'ebassi/docs-for-master' into 'master'
...
docs: Mention Window::close-request in the migration guide
See merge request GNOME/gtk!3655
2021-06-09 17:30:02 +00:00
Emmanuele Bassi
71be3a8de1
docs: Mention the ::damage-event signal in the migration guide
...
There is no replacement for damage event tracking.
2021-06-09 18:11:10 +01:00
Emmanuele Bassi
17373c3e77
docs: Mention GdkSurface:mapped
...
It replaces the ::map-event and ::unmap-event signals on GtkWidget.
2021-06-09 18:08:31 +01:00
Emmanuele Bassi
078ada75d4
docs: Mention Window::close-request in the migration guide
...
The Widget::delete-event signal was moved to Window::close-request.
2021-06-09 18:03:12 +01:00
Matthias Clasen
51a60b88b7
Merge branch 'ci-install-build' into 'master'
...
Make a standalone hello world
See merge request GNOME/gtk!3652
2021-06-09 12:59:46 +00:00
Matthias Clasen
193903ce4a
ci: Update the image
...
v32 of the image includes wayland-protocols 1.21, and
other updates from Fedora 34.
While we are at it, drop gtk-doc from the image, and drop
the separate DOCS_IMAGE - no longer used.
2021-06-09 08:42:37 -04:00
Matthias Clasen
386002597b
ci: Collect hello build logs
2021-06-09 08:42:30 -04:00
Matthias Clasen
e5a6d4a1c8
ci: Test building against installed GTK
...
This is meant to ensure that we e.g. install the
right header files, and so on.
2021-06-09 08:42:30 -04:00
Matthias Clasen
06caa57f9a
Make a standalone hello world
...
We want to test building against the installed GTK
in ci, so lets add a standalone project.
2021-06-08 17:41:11 -04:00
Matthias Clasen
5ef6944a41
Merge branch 'row-activated-annotation' into 'master'
...
treeview: Add a few missing annotations
Closes #3828
See merge request GNOME/gtk!3647
2021-06-08 17:17:45 +00:00
