Benjamin Otte
bc1a689e55
reftests: Add another background-size test
...
This one tests the keywords for the background-size property
2012-02-02 03:14:02 +01:00
Benjamin Otte
e84af235ee
css: Implement padding as numbers
...
Also remove the now unused border parsing function for shorthands.
2012-02-02 03:14:02 +01:00
Benjamin Otte
f2352a5f35
reftests: Fix border-image-url reftest
...
"border-style: none;" sets border widths to 0. So no border was drawn.
Use "border-style: groove" instead. (If the border was drawn that way,
it'd look noticably different.)
Also include reset-to-defaults.css so we really get default CSS.
2012-02-02 03:14:02 +01:00
Benjamin Otte
2fdadb053c
tests: Add 'px' to css tests
2012-02-02 03:14:02 +01:00
Benjamin Otte
f1c73fcc0c
reftests: Add 'px' to all properties
2012-02-02 03:14:02 +01:00
Benjamin Otte
cc83986eb8
reftests: Make test runner always use image surfaces
...
See comment in code for why.
2012-02-02 03:14:01 +01:00
Benjamin Otte
3c4b8a676f
css: Port margin properties to GtkCssNumber
2012-02-02 03:14:01 +01:00
Benjamin Otte
cfebd1ec06
reftests: Add reftest for background-size
2012-02-02 03:14:01 +01:00
Benjamin Otte
1eeafcf569
reftests: Put border-image-repeat test back
...
This reverts commit 001d42f369
.
Because now that we have background-size support, we can use it to make
stuff work!
2012-02-02 03:14:01 +01:00
Benjamin Otte
ceed732d65
reftests: set style properties to 0 in reset-to-defaults
...
GtkButton doesn't conform to CSS with these properties.
Bad GtkButton!
2012-02-02 03:14:01 +01:00
Benjamin Otte
2434dbc10a
themingbackground: Implement background-size support
2012-02-02 03:14:01 +01:00
Benjamin Otte
82b739c490
tests: Add parsing test for background-size
2012-02-02 03:14:01 +01:00
Benjamin Otte
1979d048d3
css: Implement parsing for 'background-size'
2012-02-02 03:14:01 +01:00
Benjamin Otte
d56ac0d4df
reftests: Add a bunch of linear gradient tests
2012-02-02 03:14:01 +01:00
Benjamin Otte
2e901752b1
tests: Add parsing tests for linear gradients
2012-02-02 03:14:01 +01:00
Benjamin Otte
811e848832
css: Implement repeating linear gradients
2012-02-02 03:14:00 +01:00
Benjamin Otte
5df9b0188a
css: Implement CSS 3 linear-gradient() syntax
2012-02-02 03:14:00 +01:00
Benjamin Otte
f22c986102
tests: Update CSS tests for borders
...
Borders now expect 'px'.
2012-02-02 03:14:00 +01:00
Benjamin Otte
0c140daff2
css: Implement support for angles
2012-02-02 03:14:00 +01:00
Benjamin Otte
a63ff72406
css: Convert border-radius to GtkCssNumber
...
We can do % now, wohoo!
2012-02-02 03:14:00 +01:00
Benjamin Otte
82c2dad178
themingengine: Add a private function to query lengths
2012-02-02 03:14:00 +01:00
Benjamin Otte
762ea4793f
css: Make border-width a length property
2012-02-02 03:14:00 +01:00
Benjamin Otte
a81ac3d5cd
css: Add a check function for specified types
...
... and use it.
It seems kinda necessary for the refactoring I'm about to do...
2012-02-02 03:14:00 +01:00
Benjamin Otte
9551f542bd
css: Ensure proper type for parsing custom properties
2012-02-02 03:14:00 +01:00
Benjamin Otte
893807bee0
css: Add GtkCssNumber
2012-02-02 03:14:00 +01:00
Benjamin Otte
bd8fefb20e
styleproperties: Add a warning
...
GtkStyleProperties stores computed values. Make sure it does.
2012-02-02 03:14:00 +01:00
Benjamin Otte
032e8f9f9b
styleproperty: Simplifiy registering function
...
... and rename it to conform to the actual type.
We don't need 2 registering functions anymore now that we can use the
specified type.
2012-02-02 03:13:58 +01:00
Benjamin Otte
6ba33e7af5
css: Allow bypassing the compute_value() stage
...
This is useful when overriding values.
2012-02-02 03:13:38 +01:00
Benjamin Otte
e4c2d9b259
csslookup: Query the bitmask
...
Checking if the value is NULL is the wrong thing to do - the bitmask is
usd to keep track of that.
The reason for that will become apparent in the next patch.
2012-02-02 03:13:38 +01:00
Benjamin Otte
4c8e9ee6b6
css: Remove two unused declarations
2012-02-02 03:13:38 +01:00
Benjamin Otte
c8786c3b97
css: color_compute no longer needs to check type
...
The input is always a symbolic color.
2012-02-02 03:13:38 +01:00
Benjamin Otte
5e5e8367ce
css: Initialize value before calling compute function
2012-02-02 03:13:38 +01:00
Benjamin Otte
f7e0ce3b28
css: Initialize values to their specified type
...
.. when parsing.
2012-02-02 03:13:38 +01:00
Benjamin Otte
25affd4766
css: Create SymbolicColor fallback properties for colors
2012-02-02 03:13:38 +01:00
Benjamin Otte
c2fb315878
css: parse 'currentColor' for symbolic colors
2012-02-02 03:13:38 +01:00
Benjamin Otte
9fa764abec
styleproperty: Introduce "specified type" and "computed type"
...
Make the types explicit. This way, we can actually do useful stuff with
them (like sanity checks, d'oh).
2012-02-02 03:13:34 +01:00
Benjamin Otte
05f14af24c
css: Make the 'currentColor' keyword a symbolic color
...
This is the first step on a quest to ensure that there is only ever one
GType in use for GValues in every stage of the CSS resolving process.
2012-02-02 00:40:33 +01:00
Benjamin Otte
6b04c0f828
raleigh: remove general 'padding' declaration
...
Fixes reftests that were broken after images and labels applied padding.
Things look much more cramped now. On the plus side, treeview headers
and comboboxes have better spacing. Menubars look like crap now though.
Needs someone with artistical talent to figure out.
2012-02-02 00:14:01 +01:00
Benjamin Otte
21e20b0d5b
raleigh: Remove unnecessary border-width declaration
2012-02-02 00:09:05 +01:00
Benjamin Otte
4dd9a73c8a
raleigh: Don't set bg-color for all widgets
...
Just set oit for things that need it.
(FIXME: Buttons should probably not need it, but spinbuttons and
treeview headers don't have a proper background without it.)
2012-02-02 00:05:51 +01:00
Cosimo Cecchi
95f5ca062b
reftests: set border-image: none in border-image-url's reference CSS
...
Fix border-image-url reftest
2012-02-01 17:59:28 -05:00
Cosimo Cecchi
d61a84bb3a
reftests: add a bunch of missing reset-to-defaults
...
Fix the css-match-* reftests.
2012-02-01 17:59:27 -05:00
Cosimo Cecchi
2ae2c443d0
app-chooser-dialog: cancel the PK operation when the dialog is dismissed
...
This doesn't really seem to have any effect; probably PK doesn't listen
for changes on the passed-in cancellable, but it's correct.
Related to: https://bugzilla.gnome.org/show_bug.cgi?id=649121
2012-02-01 13:21:43 -05:00
Cosimo Cecchi
623b5192cc
app-chooser-dialog: make sure to hold a ref when doing async ops
...
Hold a ref to the GtkDialog while doing async operations with the
GtkAppChooserOnline object.
This is needed, since somebody could call gtk_widget_destroy() on us
while an async operation is in progress. We don't want to be finalized
in that case, but mark the fact that we were dismissed and just return
from the callback in that case.
This avoids crashing if the dialog is destroyed in the middle of a PK
operation.
https://bugzilla.gnome.org/show_bug.cgi?id=649121
2012-02-01 13:21:43 -05:00
Benjamin Otte
c0ee68b7fe
gtkmain: Invoke keysnoopers unconditionally
...
Now that ATK no longer uses a key snooper but is invoked directly,
checking in advance for existing snoopers is wrong and stops ATK from
working.
Also: code reduction without performance loss == good thing.
https://bugzilla.gnome.org/show_bug.cgi?id=669176
2012-02-01 15:45:49 +01:00
Cosimo Cecchi
26ff536069
combobox: fix cell area allocation in menu mode for RTL
...
We were missing a padding to subtract from the child widget here.
2012-01-31 20:30:43 -05:00
Cosimo Cecchi
aa16f469bc
combobox: fix dropdown menu alignment for RTL languages
...
We need to add in the left padding, instead of subtracting it in that
case.
2012-01-31 20:30:43 -05:00
Cosimo Cecchi
65e6248542
combobox: use gtk_container_class_handle_border_width()
...
Avoids us fiddling with the border width manually in our size request
and allocation cycles.
2012-01-31 20:30:43 -05:00
Cosimo Cecchi
cf7f0cb27a
combobox: always trim the allocated area by padding and border for child
...
When we're size allocating the children widgets, always trim the
allocation for padding and border of GtkComboBox, as that's all the area
they have available.
2012-01-31 20:30:42 -05:00
Cosimo Cecchi
ec6b36add5
combobox: cleanup allocation of children in list mode
...
Instead of setting the same values for child allocation in different
places, just do it once.
2012-01-31 20:30:42 -05:00