Benjamin Otte
bcafd9ba3c
a11y: Add _gtk_cell_accessible_set_cell_data()
...
See the function documentation for details.
Also included is the implementation for the treeview, but no users yet.
2011-11-24 18:29:45 +01:00
Benjamin Otte
416b3ed204
treeview: Notify a11y about reordered rows
...
That way, no more signal handler is needed in the a11y code. Plus, we
avoid needless signal emissions for rows we don't care about.
2011-11-24 18:29:44 +01:00
Benjamin Otte
fbfbaa3d50
a11y: Don't create fake cell renderers
2011-11-24 18:29:44 +01:00
Florian Müllner
b72b4e79cf
build: Add gmodule-2.0 dependency for gtk-query-immodules-3.0
2011-11-24 16:33:02 +01:00
Alexander Larsson
35ffd4cfea
win32-theme: Fix up radio and menus in various states
...
This makes all states in widget-factory look ok
2011-11-24 11:50:02 +01:00
Alexander Larsson
c066136c3a
win32-theme: Theme column headers
2011-11-24 11:50:01 +01:00
Christian Persch
af0537bce1
prop-editor: Implement property editing for GdkRGBA properties
...
Bug #664467 .
2011-11-23 18:25:29 -05:00
Christian Persch
2831151405
Revert "tests: use GdkRGBA instead GdkColor"
...
This reverts commit 85747da972
.
Conflicts:
tests/prop-editor.c
Bug #664467 .
2011-11-23 18:25:27 -05:00
Christian Persch
3abc31a2d1
color-button: Notify "color" and "alpha" properties when changing the rgba
...
Bug #664469 .
2011-11-23 18:19:48 -05:00
Matthias Clasen
b84d37af4d
GtkIconView: Fix a segfault
...
Keynav on an empty iconview was causing segfaults. This
was reported in https://bugzilla.gnome.org/show_bug.cgi?id=664456
2011-11-23 17:51:58 -05:00
Federico Mena Quintero
e8be9ec01f
bgo#662814 - Don't print a g_warning() when GtkRecentManager can't find a file
...
Also, *do* add the file to the recently-used list, even if the file does not
exist yet. This is used from the Save dialog, so even shitty apps which don't
add the file to GtkRecentManager, will get the file added from the Save dialog.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-11-23 09:44:26 -06:00
Cosimo Cecchi
92e6444163
widgetpath: correctly print the siblings index
...
In gtk_widget_path_to_string() we were counting siblings from zero
instead of one, resulting in confusing output.
2011-11-23 11:22:30 -05:00
Cosimo Cecchi
0d71f62388
frame: don't access padding before it's initialized
...
Move padding initialization before its first access.
2011-11-23 11:21:29 -05:00
Benjamin Otte
6a6af8464b
gtk-demo: Fix segfault in editable cells demo
...
The strings can be freed when edting the description column. This does
not work with constant strings.
2011-11-22 23:29:04 +01:00
Benjamin Otte
6d0499a500
rbtree: Rewrite to not lose node order
...
_gtk_rbtree_reorder() was moving the node's data while reordering. As we
use the node pointer in the a11y code as a hash key, this didn't work.
So this rewrite changes that. As a bonus, it is less code and faster.
Woohoo!
2011-11-22 23:29:04 +01:00
Benjamin Otte
3166457802
tests: Add test for _gtk_rbtree_reorder()
2011-11-22 23:29:04 +01:00
Benjamin Otte
c1124df1f2
tests: Speed up rbtree test
...
We don't need so many tree consistency checks while creating when the
test is about something else.
2011-11-22 23:29:04 +01:00
Matthias Clasen
2b6f639bfa
Fix a typo
2011-11-22 14:55:46 -05:00
Matthias Clasen
251ee41d8d
Revert "Clean up includes"
...
This reverts commit c5e4af761c
.
2011-11-22 13:41:59 -05:00
Matthias Clasen
abc787a5ac
Move pangoft2 to Requires.private
...
We have pango in Requires anyway, and this is just so we
can call pangofc api ourselves.
2011-11-22 09:42:31 -05:00
Matthias Clasen
c5e4af761c
Clean up includes
...
There's no sign of Pango in this header, so no need to include
pangocairo.h
2011-11-22 08:25:24 -05:00
Benjamin Otte
d8b6414567
rbtree: Remove needless tests
...
if the checks are run on the nil node, they will get the second test the
way we expect it anyway, so it's unnecessary.
2011-11-22 03:42:31 +01:00
Benjamin Otte
ae99a9e04a
rbtree: Simplify rotation functions
...
- Make sure the rotated nodes aren't nil
- Use existing functions for complex computations
- Don't use NULL checks for variables guaranteed to not be NULL/nil
2011-11-22 03:32:56 +01:00
Benjamin Otte
37786804e1
rbtree: Remove the nil member
2011-11-22 03:32:56 +01:00
Benjamin Otte
a4630d0e7b
rbtree: Introduce _gtk_rbtree_is_nil()
...
Makes for more readable code than "== tree->nil" and allows removing the
nil member later.
2011-11-22 03:32:56 +01:00
Benjamin Otte
c3056951db
rbtree: Introduce _gtk_rbtree_first()
...
... and use it.
2011-11-22 03:32:56 +01:00
Benjamin Otte
73a834336f
rbtree: Replace nil node allocation with a preallocated nil
...
This has one major caveat: The new value is const, so read-only memory.
Any attempt to write to it will cause a crash. Note that we are not ever
supposed to write to it, but bugs happen...
2011-11-22 03:32:56 +01:00
Matthias Clasen
fa89423346
Bump version
2011-11-21 18:34:11 -05:00
Matthias Clasen
84c0ccad47
3.3.4
2011-11-21 18:14:13 -05:00
Matthias Clasen
7c6bbf59d7
More updates
2011-11-21 17:12:27 -05:00
Benjamin Otte
e2f2289d72
tests: Add a test for the rbtree code.
2011-11-21 22:33:46 +01:00
Benjamin Otte
647c441e26
rbtree: Don't write to nil node
...
The code used to set nil->parent, which could cause segfaults. Don't do
that. We also need to pass the parent explicitly to the fixup code,
because the node during fixup may be the nil node.
2011-11-21 22:33:46 +01:00
Benjamin Otte
f4fe921a17
rbtree: Add a local variable
...
This will be needed in the next patch, and I wanted to split that patch
up.
2011-11-21 22:33:46 +01:00
Benjamin Otte
02671f9ec9
rbtree: Move to an approach where we don't move contents
...
So instead of copying the children and height to the new node, we keep
the old node and copy all the old stuff to it.
This is necessary so the accessibility code can use the node as a key in
the hash table or store the node as a reference to the row instead of
GtkTreeRowReference. And because it already does that (oops), this fixes
a bunch of segfaults with a11y enabled.
2011-11-21 22:33:45 +01:00
Benjamin Otte
1dd9dd45c1
rbtree: Use gtk_rbnode_adjust() even more
...
Use it for the modified node in gtk_rbnode_remove(). Cleans up the code
quite a lot.
2011-11-21 22:33:45 +01:00
Benjamin Otte
769186dbff
rbtree: Use gtk_rbnode_adjust()
...
Make gtk_rbnode_remove() use it when unlinking the node.
2011-11-21 22:33:45 +01:00
Benjamin Otte
ba7a0a0188
rbtree: Use gtk_rbnode_adjust() more.
...
Make _gtk_rbtree_node_set_height() use it.
2011-11-21 22:33:45 +01:00
Benjamin Otte
7b2d414222
rbtree: Use gtk_rbnode_adjust() more
...
Make _gtk_rbtree_insert_before() use it.
2011-11-21 22:33:45 +01:00
Benjamin Otte
01a44e2a16
rbtree: Use gtk_rbnode_adjust()
...
Make _gtk_rbtree_insert_after() use it.
2011-11-21 22:33:45 +01:00
Benjamin Otte
22a4c15b4f
rbtree: Split out a common function
...
gtk_rbtree_adjust() will adjust the summed values of a node and all its
parents in the tree. Currently only implemented by splitting out the
function from gtk_rbtree_free().
2011-11-21 22:33:45 +01:00
Benjamin Otte
54f3fbfe26
rbtree: Don't set variable twice
2011-11-21 22:33:45 +01:00
Benjamin Otte
6168a64713
rbtree: Add assertions to clarify usage
2011-11-21 22:33:45 +01:00
Benjamin Otte
69a516018f
rbtree: Mark all debug sections as debug
2011-11-21 22:33:45 +01:00
Benjamin Otte
af2ebe638c
rbtree: Make debug functions private
...
They're not used elsewhere
2011-11-21 22:33:45 +01:00
Cosimo Cecchi
79bbce5577
notebook: use the current page allocation when computing the redraw area
...
Instead of taking the first page and trying to adjust the rect with
random padding values, take the current page, as it's always guaranteed
to be at least as tall as inactive tabs.
This fixes some annoying 1px drawing artifacts while switching tabs when
the theme disables notebook padding.
https://bugzilla.gnome.org/show_bug.cgi?id=664494
2011-11-21 14:19:36 -05:00
Cosimo Cecchi
f01162c727
notebook: properly subtract the initial_gap width from the tab space
...
Instead of modifying the allocation.
https://bugzilla.gnome.org/show_bug.cgi?id=664494
2011-11-21 14:19:36 -05:00
Matthias Clasen
7814718152
Drop uses of @returns syntax
2011-11-21 13:12:58 -05:00
Matthias Clasen
7e8b7a72ac
Prevent local filesystem influence in the a11y tests
...
By using the 'unix' gio volume monitor, we avoid variation
in the file chooser that otherwise breaks the 'pickers' test.
2011-11-21 13:05:47 -05:00
Alexander Larsson
9275b87b6a
win32: Don't double free stuff when finalizing drag context
...
We were freeing stuff that was already freed in the parent class
finalizer.
2011-11-21 15:03:53 +01:00
Alexander Larsson
0d94b974b3
win32: Don't dereference keyboard_grab if it is NULL
...
This fixes a crash in e.g. testdnd
2011-11-21 14:37:57 +01:00