AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Fix transfer annotation for tree_model parameter of gtk_tree_get_row_drag_data() and add nullable, optional

Browse Source 
The GtkSelectionData does not own the model set with
gtk_tree_set_row_drag_data so change the out param to "transfer none".
This fixes a crash after multiple DnD actions due to the bindings
stealing a reference each time this function is called.

This also adds nullable and optional annotations for tree_model and path while at it.

https://bugzilla.gnome.org/show_bug.cgi?id=743193
This commit is contained in:
Christoph Reiter 2015-01-19 18:06:03 +01:00 committed by Matthias Clasen
parent 9668962da1
commit f4dee9b682
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtk/gtktreednd.c
View File

@ -305,8 +305,8 @@ gtk_tree_set_row_drag_data (GtkSelectionData *selection_data,
/**
* gtk_tree_get_row_drag_data:
* @selection_data: a #GtkSelectionData
* @tree_model: (out): a #GtkTreeModel
* @path: (out): row in @tree_model
* @tree_model: (nullable) (optional) (transfer none) (out): a #GtkTreeModel
* @path: (nullable) (optional) (out): row in @tree_model
*
* Obtains a @tree_model and @path from selection data of target type
* %GTK_TREE_MODEL_ROW. Normally called from a drag_data_received handler.