Matthias Clasen
0f10b170f4
widget: Drop gtk_widget_destroy
2020-05-11 12:20:59 -04:00
Matthias Clasen
6aebedb8bc
window: Implement gtk_window_destroy
...
Don't call gtk_widget_destroy; instead implement
gtk_window_destroy outselves by removing the window
from the toplevel lista and dropping the reference that
GTK holds.
2020-05-11 12:20:59 -04:00
Matthias Clasen
025375ff5f
Replace gtk_widget_destroy everywhere
...
Replace all remaining uses of gtk_widget_destroy
by gtk_container_remove or g_object_unref.
2020-05-11 12:20:59 -04:00
Matthias Clasen
cd0081d08a
Use gtk_window_destroy
...
Replace calls to gtk_widget_destroy on windows
with gtk_window_destroy.
2020-05-11 12:20:57 -04:00
Matthias Clasen
48821a64d0
window: Add gtk_window_destroy
...
This is a replacement for gtk_widget_destroy for toplevels.
For now, it is just a wrapper.
2020-05-11 12:19:39 -04:00
Matthias Clasen
81340da8b6
nativedialog: Do not ref the transient_for parent
...
gtk_window_set_transient_for does not ref its parent either. This is
important because a child widget of the parent might be the one calling
this function.
This was showing up as widget-factory not existing on close after
opening the file chooser.
2020-05-11 12:19:39 -04:00
Matthias Clasen
466d2a84de
testsuite: Clean up unexpected children
...
If you call gtk_widget_set_parent on an unsuspecting
parent widget, it is your reponsibility to clean up
before the parent gets finalized.
2020-05-11 12:19:39 -04:00
Matthias Clasen
ddebf07236
popover: Fix a reference leak
...
Don't leak the reference to the default widget.
2020-05-11 12:19:39 -04:00
Matthias Clasen
0ba1aad4e3
filechooserdialog: Fix disposing
...
We need to drop our widgetry in dispose to prevent
leakage.
2020-05-11 12:19:39 -04:00
Matthias Clasen
4b144855b9
colorchooserdialog: Fix disposing
...
We need to drop our widgetry in dispose to prevent
leakage.
2020-05-11 12:19:39 -04:00
Matthias Clasen
b6bfeb786f
fontchooserdialog: Fix disposing
...
We need to drop our widgetry in dispose to prevent
leakage.
2020-05-11 12:19:39 -04:00
Matthias Clasen
573b20a8f8
Drop gtk_widget_destroyed
...
Use g_object_add_weak_pointer or a weak reference instead.
2020-05-11 12:19:39 -04:00
Matthias Clasen
8f9c3ed44a
Stop using gtk_widget_destroyed
...
Replace all internal use of gtk_widget_destroyed
by g_object_add_weak_pointer.
2020-05-11 12:19:37 -04:00
Matthias Clasen
9ce7b16dd8
Merge branch 'wip/exalm/test' into 'master'
...
Fix (most of the) tests
See merge request GNOME/gtk!1873
2020-05-11 15:52:24 +00:00
Matthias Clasen
597665517c
Merge branch 'teardown-cleanup-2' into 'master'
...
Treeview teardown cleanup
See merge request GNOME/gtk!1872
2020-05-11 15:23:40 +00:00
Alexander Mikhaylenko
228b3fc622
tests: Stop explicitly showing widgets
2020-05-11 20:15:57 +05:00
Alexander Mikhaylenko
ea9cea9be7
tests: Remove redundant image from testdialog
2020-05-11 20:04:23 +05:00
Alexander Mikhaylenko
56f56e6352
tests: Connect signal properly for testvolumebutton
2020-05-11 19:54:32 +05:00
Alexander Mikhaylenko
2323e8d77d
tests: Remove orientation from testvolumebutton
...
GtkVolumeButton isn't orientable anymore.
2020-05-11 19:53:31 +05:00
Alexander Mikhaylenko
531468cab6
test: Stop using stock-size for teestverticalcells
2020-05-11 19:51:18 +05:00
Alexander Mikhaylenko
58fcd09cff
tests: Fix testtreeelistmodel
...
Stop using GtkContainer API for GtkListBoxRow and GtkToggleButton.
2020-05-11 19:47:58 +05:00
Alexander Mikhaylenko
2940b17a8e
tests: Fix teststackedheader
...
Connect to signals programmatically.
2020-05-11 19:33:05 +05:00
Matthias Clasen
b8c5bf8af8
testsuite: Enable the remaining template tests
...
These are no longer failing.
2020-05-11 10:30:03 -04:00
Matthias Clasen
d061bcad52
treeview: Break reference cycles on unroot
...
It is a bad idea to have such cycles in the first place,
and there is no need to let them linger past unroot.
This stop the treeview depending on run_dispose to get
freed, a simple unparent will work now.
2020-05-11 10:30:03 -04:00
Alexander Mikhaylenko
1d2af907fc
tests: Fix teststack "add icon" button
2020-05-11 19:27:41 +05:00
Matthias Clasen
329994291a
Merge branch 'wip/baedert/for-master' into 'master'
...
Wip/baedert/for master
See merge request GNOME/gtk!1867
2020-05-11 14:24:45 +00:00
Alexander Mikhaylenko
b2da99fd4e
tests: Fix testselectionmode
...
Stop using <packing/> and GtkContainer API for random widgets.
2020-05-11 19:21:03 +05:00
Yuri Chornoivan
2d97357136
Update Ukrainian translation
2020-05-11 14:20:13 +00:00
Alexander Mikhaylenko
4361a884bf
tests: Fix testoverlay
...
Stop using child properties and margin property.
2020-05-11 19:13:04 +05:00
Alexander Mikhaylenko
14dc92c747
tests: Simplify testorientable
...
Since GtkButtonBox is gone, remove the separator and change grid to box.
2020-05-11 19:08:56 +05:00
Alexander Mikhaylenko
c9760ed456
tests: Remove testmodelbutton
...
GtkModelButton is private now, so it can't work anymore.
2020-05-11 19:03:53 +05:00
Alexander Mikhaylenko
7c148bebef
tests: Remove use-popover from testmenubutton
...
The corresponding property doesn't exist anymore.
2020-05-11 18:55:15 +05:00
Alexander Mikhaylenko
7aeb504652
tests: Fix testlogout
...
Stop using GtkApplication::quit signal.
2020-05-11 18:54:53 +05:00
Alexander Mikhaylenko
e0d36d1f2d
tests: Fix testiconview
...
Stop using GtkContainer API for GtkPopover.
2020-05-11 18:54:23 +05:00
Alexander Mikhaylenko
68fb643a7e
tests: Fix testheightforwidth layout
...
Stop using child properties and setting visible=true everywhere.
2020-05-11 18:39:32 +05:00
Alexander Mikhaylenko
fb0dcaf066
tests: Expand content for testheaderbar
2020-05-11 18:31:59 +05:00
Alexander Mikhaylenko
4277eeee1b
tests: Fix testgtk
...
An assorted collection of fixes.
2020-05-11 18:12:18 +05:00
Matthias Clasen
9f3fb69dce
Merge branch 'matthiasc/for-master' into 'master'
...
Matthiasc/for master
Closes #2729 and #2730
See merge request GNOME/gtk!1870
2020-05-11 12:51:08 +00:00
Matthias Clasen
0e18e52f00
menubutton: Cosmetics
...
Fix a few typos in the docs.
2020-05-11 08:15:56 -04:00
Matthias Clasen
d2430c70bd
Refresh the tutorial examples
...
Redo this series of examples from 2013, and adapt it to modern
way of doing things. The biggest differences are that we use
a headerbar right from the start, and don't mention the app
menu.
Fixes : #2730
2020-05-11 08:15:56 -04:00
Matthias Clasen
4de4957aa3
applicationswindow: Make show-menubar FALSE by default
...
The fallback to the menubar is not a good sight,
we should not do that by default.
2020-05-11 08:15:56 -04:00
Matthias Clasen
0fc1a290e2
docs: Cosmetic updates to the tutorial
...
Since the meson conversion, we are no longer expanding
gtk-doc references in this file, so take them out. And
touch up the wording in various places.
2020-05-11 08:15:55 -04:00
Matthias Clasen
1b8a025a5f
Clean up a leak in a test
...
One of the treeview tests was calling gtk_widget_destroy
on a child instead of the toplevel, which leaks the toplevel
unnecessarily. Plus, we're moving towards allowing destroy
only on toplevels.
2020-05-11 08:15:55 -04:00
Matthias Clasen
d798527290
treeviewcolumn: Another case of box <> frame confusion
...
Don't call your boxes frames, folks!
2020-05-11 08:15:55 -04:00
Matthias Clasen
6140dafecf
builderscope: Fix finalize <> dispose confusion
...
Don't chain up to dispose if you implement finalize.
This fix s courtesy of GOBJECT_DEBUG=objects.
2020-05-11 08:15:55 -04:00
Matthias Clasen
3a5cf61a4d
print dialog: Fix frame <> box confusion
...
It is a bad idea to have a GtkBox called frame, event
if it started out its existence as a GtkFrame.
2020-05-11 08:15:55 -04:00
Matthias Clasen
a11119d317
treeview: Ensure search popover is properly inserted
...
The css tree and the widget tree are not in sync, so we need
to explicitly set the parent of the css node before inserting
the widget, or else we end up with critical warnings and a
non-working popover.
This can be seen in the print dialog, when moving the focus
to the printer list.
2020-05-11 08:15:55 -04:00
Matthias Clasen
756720fde4
print-editor: Cosmetics
...
Make the about dialog a bit less barren.
2020-05-11 08:15:55 -04:00
Matthias Clasen
2b920b22c1
print-editor: Fix a critical
...
GtkWindow is no longer a container, so don't call
gtk_container_add on it.
2020-05-11 08:15:55 -04:00
Matthias Clasen
bb8fa045c2
Merge branch 'focusable-property' into 'master'
...
Focusable property
See merge request GNOME/gtk!1834
2020-05-11 11:23:15 +00:00